From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5E2FC021B0 for ; Wed, 19 Feb 2025 15:23:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25095280237; Wed, 19 Feb 2025 10:23:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B10228022F; Wed, 19 Feb 2025 10:23:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05481280237; Wed, 19 Feb 2025 10:23:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D487E28022F for ; Wed, 19 Feb 2025 10:23:33 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 23627A1D96 for ; Wed, 19 Feb 2025 15:23:33 +0000 (UTC) X-FDA: 83137063506.12.59F39BA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 25B51100028 for ; Wed, 19 Feb 2025 15:23:30 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Cd9Mm5MZ; spf=pass (imf05.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739978611; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/0kmnhcuXSDK/VJa/ZW0gcKx1grCl+oTBF/dgOBkbx8=; b=4q1IezlCtBlUVhNAgQrb4o1WTLc2di58VcimnnX/SFXfFLM5yg7burfWBXb3+fRldi3NAp jqMLg5KLqLmhbf696dqdvui0vUZnBusc4eA4ygK1y04SkI77SRStaBSP4Fl3bbsatgD2VE N0Y7+caW0mznYnnmkqXlEDKWNV8klsw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739978611; a=rsa-sha256; cv=none; b=voQL75ZSj7hghojM6rYV9jQNDl2cXviPC5nzgXKAEZ7rme+nLLs31erOjAKhofq5CuMwxm MzZ7jRDbupEgJrMG1hs62DjOXAyMYHHGUyuFOLsXJxzk++B4wyhrYZ5+RRaxVADdOwyb84 wtB4kcfVfUMEuzVr7HPe6RslInf3ghw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Cd9Mm5MZ; spf=pass (imf05.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739978610; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/0kmnhcuXSDK/VJa/ZW0gcKx1grCl+oTBF/dgOBkbx8=; b=Cd9Mm5MZNS3z07sHkLsx3dBldfuR5guE8U2UZk3F+BziKCZ0vWFaIi/8Egd0bUc/sNsTMf 4KskhN8ezNOUGM2v/tDEtWzpEmRAnJWHOduLsW9l8SpxbU3BvT3jyIzKZJ+5GbR0B1E2SN 9gBmGjCiPxGgu8+3egpvIGnrX4XRX3k= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-629-wy_-NrPsPJOUKZFcVv0X_g-1; Wed, 19 Feb 2025 10:23:27 -0500 X-MC-Unique: wy_-NrPsPJOUKZFcVv0X_g-1 X-Mimecast-MFC-AGG-ID: wy_-NrPsPJOUKZFcVv0X_g_1739978604 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8F12119783BC; Wed, 19 Feb 2025 15:23:23 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.44.33.102]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 910421956094; Wed, 19 Feb 2025 15:23:08 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Wed, 19 Feb 2025 16:22:53 +0100 (CET) Date: Wed, 19 Feb 2025 16:22:38 +0100 From: Oleg Nesterov To: Tong Tiangen Cc: David Hildenbrand , Masami Hiramatsu , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Andrew Morton , Peter Xu , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, bpf@vger.kernel.org, wangkefeng.wang@huawei.com, linux-mm Subject: Re: Add Morton,Peter and David for discussion//Re: [PATCH -next] uprobes: fix two zero old_folio bugs in __replace_page() Message-ID: <20250219152237.GB5948@redhat.com> References: <20250217123826.88503-1-tongtiangen@huawei.com> <3b893634-5453-42d0-b8dc-e9d07988e9e9@redhat.com> <24a61833-f389-b074-0d9c-d5ad9efc2046@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <24a61833-f389-b074-0d9c-d5ad9efc2046@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Rspam-User: X-Rspamd-Queue-Id: 25B51100028 X-Rspamd-Server: rspam07 X-Stat-Signature: rzt1esiba11qo7pnoy9kyike36y8nzmq X-HE-Tag: 1739978610-137764 X-HE-Meta: U2FsdGVkX18JF+jdXqQ6U0fXg8t0ptYoefzS4iXlOKlpwK49GtLsa5JcDBXest42QnyCCxin484GYJjFH+8BU4kOFVIa7rakRke9JHcabiLGCvOy9/3jHwkvraEHh/OihRIU9nYYCE4wupzVXYB/nwo31Ko+Hj4oK62jLVenIEQZXIk5IB3iPtCJgzCDdtYD+JOu0njZIpMt/quPjnG0lV6STkRjXrHV4qBoc3itIt0ktn81TVKjaxOYjNYDCrVXIdGFGqOgnofurOsJ8KdiPK9peqv3n9ypUMKgWBnLW0U8lugLwoJDiivP1X9LMpIL7p01+DUp24Fc9aA7+N900mRKvZAI33ZWX1cg3LengaTr2B8FYQ5LXmUj2nlE54NUE4eGp6saztG/pfRgUpyxe31f7bjamalkbEfVI+LZ41MFRTjkcC9L+g+5dkfQDQgmftVzD+eS1fpa+aUUc/TuDOHknUjIrR285yjBeQP7xc4KCXgstIAIADwWTASHnen7+7qz7Xa7wBN8IGQN9g7rzc33CDCaRN0Ruq546crEd0Cg2HYmlITSytzbBGlA6Q0ubk995xcOII3Ev4vc4WrjHvruGWdfBQ1x/u9SNLvaohh8BcPSQmwSTZlQctMTPdtnHLmqVdiUk1ij+c2PwOm/RYowbCE7VFK4T0rrt+S3HavVJn4wERWbbralx7yOdOqL9W7JXiPo8erzVf5ZrcA2kABrUy66SgJdmJ7xxoheAXPv8uRADAkheqBLy8RTe/cvy3nyKsJ36kHKv2WHHBtCHrdcymwPiRkVwdZUOcTJv8MgSsy+EMK2CcJ/PMaDKX4AdE5GPlkK9xwh/0y+w27rfNbxfFzW0mCCEmXxST/uxN2di9nMfTCTX3/x9u451H/fLt78UyfUSyuxsgtFsGzfmnSym/brqtVNi0znQvXBNP1yUTbAssNEGuqJp3JaBqmyspVeUlMVxxVfpXBeUlM DH38aWWH EXLu2QTSVPyXuWqh7ivwvIexMnpc432kfn1mFHruQZNuSCsEOM+fej1ffzgHe/UJM5GonmmjXVUJql4hAsSvqxTg/pj1Ju63NzViXtErenZP+fAvyK9Id3Rg5sCipgN6ZgO2HrSId19pHecWrEXqM/Ig13CO6V9nm24cZo8a50J6G+O2rTHOiaTxIWH8yxHxvuIz6PTmWdPjZ7Q2egJlSgR0yswKUsjk1kJDebDmG9H45DShpeT/oUS7aK5g88nKLML3mhpbXoDMWpOT4RF6dm1k+bRnkNNFGaEKrPMf5vfW/9SEoj4kRKRBfABWRakmDDkMDT9l5ftQAXFIIVAFqB+11wjN+xiU/suCKXqRxvYi4KI4MihPlp19xj/4G1ngSd18M X-Bogosity: Ham, tests=bogofilter, spamicity=0.000625, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/18, Tong Tiangen wrote: > > OK, Before your rewrite last merged, How about i change the solution to > just reject them immediately after get_user_page_vma_remote()？ I agree, uprobe_write_opcode() should simply fail if is_zero_page(old_page). Oleg.