From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 178ABC021AA for ; Wed, 19 Feb 2025 12:05:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8002E28022B; Wed, 19 Feb 2025 07:05:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B04F280226; Wed, 19 Feb 2025 07:05:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DC0A28022B; Wed, 19 Feb 2025 07:05:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3DDD7280226 for ; Wed, 19 Feb 2025 07:05:09 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E764A12161F for ; Wed, 19 Feb 2025 12:05:08 +0000 (UTC) X-FDA: 83136563496.12.82AA085 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf11.hostedemail.com (Postfix) with ESMTP id DA9EC4001B for ; Wed, 19 Feb 2025 12:05:06 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=KIvsZxZP; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf11.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739966707; a=rsa-sha256; cv=none; b=LeVilZpxrwsyGfqBpMRNv7lEh47ZMw6OFVH/FZti2CPQ7lM9lUSgtP2dgnXuJ2Ujxn8qg2 vXZrNVr2pZQzr4VWeVjfKwHVaq4kwQcmEFWtf7xZQ5WVQsJi+A6x9GzndEJT8tccgdNF6z nqsHhonIYwMb3yydYBS+GsClCsUka+U= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=KIvsZxZP; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf11.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739966707; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IlEwYGsWU+HgFJw77Yn9NIdwvzcfp45kelarRrAI4mE=; b=7rvcOLql7MkAFHEKNqM7f+WKJW8s0pLOYe3KAkf6tngbWno/LbdGHeMj5hEmHk7f91ruHD tjsUrDmESOxSRXH+RAnMHe4tzL6ePB+A5A1vJYcdQJx4XLqJZ6bA+J79NM/C8npuqdi7cL rx0gAUcnjcmv5HLDVRTQwOimmcm1O04= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 819F340E0221; Wed, 19 Feb 2025 12:05:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Bh14lVrcUpQq; Wed, 19 Feb 2025 12:04:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1739966698; bh=IlEwYGsWU+HgFJw77Yn9NIdwvzcfp45kelarRrAI4mE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KIvsZxZPY0a6o6WJhwtxdezGe4Uiy20yMdMpxP6FYqbu44KgSczMiKnruyzFqfnyA l7dan9nOmgIU7dhqKXLfNQRfNyHAticSbZ3LBesmKQBj4v9HQ19rVBwyutUI0663Qr SYiPeamIYDYzGNdtHN7bp1lOLERAcOljOW7nGDP/o/s2PwSLmC4OvL81bqfzNO5362 r7c+MKBNtvO10r5kEyRu7CXChvkgDOuUhtPaDHAa3LI/tks/kV6rOfOHsEezgT15Gc mDUDiBV/EeOBXFufVwa7rcMb5C8VtQezwTNSz/Efl/9cs+IBBj8f2451mhGhVPJ4cU KATPfUuMjtxwgKkFIdoMqhOK229JrYQvfFm43ihq+X8bmmJZD61mN0gtdjRwcrrfk8 4oXK8tn6sH1oM443FikbakoCj0Q42dQyHgg4bSd7dKwOyJHhJAirlSwBb2bcbPjdUW UQVmf2BIDcxwH82Y0uDhAImbgCuvtL4CNHg4YIRshYmqgrITZpQF8RwPqcOgEQhX6h bwsQ0+L2Jz2/syfPQ9eKKqmWjs/nsW0MRFLrWssUWCN3O3hWwTpJnnNa0etsURyM0k 5g6XcQjATVT/CV8dbHEpdBZFe+SH4jAp6+ttVs1SmekDC3LaWLRAdkH2anBJgPu9W/ o0Mweqmc3Hwp/wyn4a3rzpBk= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2FC2240E0220; Wed, 19 Feb 2025 12:04:42 +0000 (UTC) Date: Wed, 19 Feb 2025 13:04:41 +0100 From: Borislav Petkov To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla Subject: Re: [PATCH v11 05/12] x86/mm: add INVLPGB support code Message-ID: <20250219120441.GNZ7XI2aWWUmXh2H2m@fat_crate.local> References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-6-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250213161423.449435-6-riel@surriel.com> X-Rspam-User: X-Rspamd-Queue-Id: DA9EC4001B X-Rspamd-Server: rspam12 X-Stat-Signature: q6bsb9fct99kg6wtoom1dy1zaq1peow4 X-HE-Tag: 1739966706-617298 X-HE-Meta: U2FsdGVkX1/OvwtmeFDmrwp0lGk9OXbX5WpUQ6Aiuvb8GrLoFqBosvPiPtHxy+BQRaxEa2WoDbLwEO4qF7CT35HLXMi7xOs1wabpzfoxMWOGUF+NuchrtwFl8DRzAtWO/GdB+VvAiz4LswSNHxDzuAFzgyMRa7flSuNrgfVqgNBAgc23+4aAN2KC/BfM1RDjeHNPVAWq0Rh2eBxWAKTeVznFEY+p3gXpBnBFpAyP+wsfrsF9qlYrp6MoCLfnCsIqwxuynPg0AAKhAiGJo95PE8fELJkEKCBYX18nDgFoxAwvPymbKDQryMBgP3SOuI/N2vd0sGeNvt9vAw4EoUX+Fx+wJm08VCUdtlSaDPL2+ChoNiFXwDMURRR7nBndFzpkvBIckEePYsNcX+m9P7QA808dN+5Ur33INjvQUPPs81Ykrsrk3BzGN7f56jI7BDyZqta6xCJhVmeAT/70cTDv2tbgWKC4AcP2Q/QVUfXOySjfFYTAGKECGAGQeX9vgivNBji5kyMJa/VoFV122NmhudgMtJOLwlCbTSjofCKwmrSrq7oCjxbr4cDL1tifqeb1SFQVwhxCzcDMjwCxR3oqxvl+cuueqapigYoAZnaXLAwYeJiqwX1aJX7ZK8Tzky9RFW2Y40e21A5s3Om3GoMMwhiOoErwax6+EJ192PTAesWTx/5uqdA/OIVqje91TorGbSTHf2mdfCq8AMcXbcr2GaBW4D1ZyFMpSnIt/S/84nmgj/9pCC6cCYkEyB1DjyOjordx0/xByAZ6tr3clogzV3QuZEIaltbvM1KppA6tjb6XkYj8eMu/e7GsrUh1vpeRc0UOLFRHHxSK7yjOezlVZu7Jc0bVHK/UFuwps+Q5QnWhwPEO0TYfg18te8dI8FigDqq3iS5aEIQfHoiS6BFAXNwHUpr4vb0A97O1B5SU7p0eIpLQn2PHK2MhoO8kk1Sb4TOSJQ9nlMVXxET4SeS XOWoBXgM MmsZwdkG4naUb9IzeqsLIiDPwUtT0PKZeagzZkEsc36hneB59MUfNphOKNqvSNzj+dx5rbtreq4GJm+uK/fGbz0xK/UQw1ScaFgAmJ+xEU9m4T+sgEiacRR6kZKfZ0oi+vq6tnavqy2lkVn9z8sPrtCwFZcAYbqWG2skB9cVFEia68bUl8HFRE6fM2RaLwxOw0bX4g8lXk16gY8P+k38yEULrAqiJNms8Fc502k4IVYErs30Txd+z8L8WmgQl3GLW2RrAsAgpTWAGj5124MXE9vzZMC1AY4MMixj/ZpEkSU1P9cmBJNB7TmxNYEfO2XzCh8982wboYiwHyUPGTr43ozEOLFMzdsLdDxYX2pDoOjYqaG32WI5BMZ+qao/OSkndaGp8USi6E9hdzSoU6jUT7NYjT9jTA5OoyZIlORVVygDB7pOq1Kv+GFVrWN4sxjC271r4HzgR9+8E7zLciHA2oG7k1g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 13, 2025 at 11:13:56AM -0500, Rik van Riel wrote: > Add invlpgb.h with the helper functions and definitions needed to use > broadcast TLB invalidation on AMD EPYC 3 and newer CPUs. > > Signed-off-by: Rik van Riel > Tested-by: Manali Shukla > Tested-by: Brendan Jackman > Tested-by: Michael Kelley > --- > arch/x86/include/asm/disabled-features.h | 8 +- > arch/x86/include/asm/invlpgb.h | 101 +++++++++++++++++++++++ > arch/x86/include/asm/tlbflush.h | 1 + > 3 files changed, 109 insertions(+), 1 deletion(-) > create mode 100644 arch/x86/include/asm/invlpgb.h > > diff --git a/arch/x86/include/asm/disabled-features.h b/arch/x86/include/asm/disabled-features.h > index c492bdc97b05..625a89259968 100644 > --- a/arch/x86/include/asm/disabled-features.h > +++ b/arch/x86/include/asm/disabled-features.h > @@ -129,6 +129,12 @@ > #define DISABLE_SEV_SNP (1 << (X86_FEATURE_SEV_SNP & 31)) > #endif > > +#ifdef CONFIG_X86_BROADCAST_TLB_FLUSH > +#define DISABLE_INVLPGB 0 > +#else > +#define DISABLE_INVLPGB (1 << (X86_FEATURE_INVLPGB & 31)) > +#endif > + What does that bring you really in savings? > /* > * Make sure to add features to the correct mask > */ > @@ -146,7 +152,7 @@ > #define DISABLED_MASK11 (DISABLE_RETPOLINE|DISABLE_RETHUNK|DISABLE_UNRET| \ > DISABLE_CALL_DEPTH_TRACKING|DISABLE_USER_SHSTK) > #define DISABLED_MASK12 (DISABLE_FRED|DISABLE_LAM) > -#define DISABLED_MASK13 0 > +#define DISABLED_MASK13 (DISABLE_INVLPGB) > #define DISABLED_MASK14 0 > #define DISABLED_MASK15 0 > #define DISABLED_MASK16 (DISABLE_PKU|DISABLE_OSPKE|DISABLE_LA57|DISABLE_UMIP| \ > diff --git a/arch/x86/include/asm/invlpgb.h b/arch/x86/include/asm/invlpgb.h > new file mode 100644 > index 000000000000..a1d5dedd5217 > --- /dev/null > +++ b/arch/x86/include/asm/invlpgb.h I remember asking you to add all that gunk to arch/x86/include/asm/tlb.h. Please do so. > +#define INVLPGB_VA BIT(0) > +#define INVLPGB_PCID BIT(1) > +#define INVLPGB_ASID BIT(2) > +#define INVLPGB_INCLUDE_GLOBAL BIT(3) > +#define INVLPGB_FINAL_ONLY BIT(4) > +#define INVLPGB_INCLUDE_NESTED BIT(5) > + > +/* Flush all mappings for a given pcid and addr, not including globals. */ > +static inline void invlpgb_flush_user(unsigned long pcid, > + unsigned long addr) Please drop this unused function. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette