From: Andrew Morton <akpm@linux-foundation.org>
To: Barry Song <21cnbao@gmail.com>
Cc: gaoxu <gaoxu2@honor.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Yosry Ahmed <yosry.ahmed@linux.dev>
Subject: Re: [PATCH v4] mm: Fix possible NULL pointer dereference in __swap_duplicate
Date: Tue, 18 Feb 2025 20:03:55 -0800 [thread overview]
Message-ID: <20250218200355.959a79bf9b6253772a95e782@linux-foundation.org> (raw)
In-Reply-To: <CAGsJ_4y9eoHRSUSzs96UWUVygEDcoTQqFM1uyEtr_VHcmAmVDw@mail.gmail.com>
On Wed, 19 Feb 2025 15:28:26 +1300 Barry Song <21cnbao@gmail.com> wrote:
> > The patch seems to only provide a workaround, but there are no more
> > effective software solutions to handle the bit flips problem. This path
> > will change the issue from a system crash to a process exception, thereby
> > reducing the impact on the entire machine.
> >
> > Signed-off-by: gao xu <gaoxu2@honor.com>
>
> Regardless of whether the above statement is 100% accurate or whether
> a bit-flip actually exists, providing this check still seems useful,
> at least for
> defensive programming.
I'm doubtful as well.
How often has this crash been observed?
next prev parent reply other threads:[~2025-02-19 4:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 1:56 gaoxu
2025-02-19 2:28 ` Barry Song
2025-02-19 4:03 ` Andrew Morton [this message]
2025-02-19 6:23 ` 回复: " gaoxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250218200355.959a79bf9b6253772a95e782@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=21cnbao@gmail.com \
--cc=gaoxu2@honor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=surenb@google.com \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox