From: Frank van der Linden <fvdl@google.com>
To: akpm@linux-foundation.org, muchun.song@linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: yuzhao@google.com, usamaarif642@gmail.com,
joao.m.martins@oracle.com, roman.gushchin@linux.dev,
Frank van der Linden <fvdl@google.com>
Subject: [PATCH v4 11/27] mm/hugetlb: set migratetype for bootmem folios
Date: Tue, 18 Feb 2025 18:16:39 +0000 [thread overview]
Message-ID: <20250218181656.207178-12-fvdl@google.com> (raw)
In-Reply-To: <20250218181656.207178-1-fvdl@google.com>
The pageblocks that back memblock allocated hugetlb folios might
not have the migrate type set, in the CONFIG_DEFERRED_STRUCT_PAGE_INIT
case.
memblock allocated hugetlb folios might be given to the buddy allocator
eventually (if nr_hugepages is lowered), so make sure that the migrate
type for the pageblocks contained in them is set when initializing them.
Set it to the default that memmap init also uses (MIGRATE_MOVABLE).
Signed-off-by: Frank van der Linden <fvdl@google.com>
---
mm/hugetlb.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 1a200f89e21a..19a7a795a388 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -3254,6 +3254,26 @@ static void __init hugetlb_folio_init_vmemmap(struct folio *folio,
prep_compound_head((struct page *)folio, huge_page_order(h));
}
+/*
+ * memblock-allocated pageblocks might not have the migrate type set
+ * if marked with the 'noinit' flag. Set it to the default (MIGRATE_MOVABLE)
+ * here.
+ *
+ * Note that this will not write the page struct, it is ok (and necessary)
+ * to do this on vmemmap optimized folios.
+ */
+static void __init hugetlb_bootmem_init_migratetype(struct folio *folio,
+ struct hstate *h)
+{
+ unsigned long nr_pages = pages_per_huge_page(h), i;
+
+ WARN_ON_ONCE(!pageblock_aligned(folio_pfn(folio)));
+
+ for (i = 0; i < nr_pages; i += pageblock_nr_pages)
+ set_pageblock_migratetype(folio_page(folio, i),
+ MIGRATE_MOVABLE);
+}
+
static void __init prep_and_add_bootmem_folios(struct hstate *h,
struct list_head *folio_list)
{
@@ -3275,6 +3295,7 @@ static void __init prep_and_add_bootmem_folios(struct hstate *h,
HUGETLB_VMEMMAP_RESERVE_PAGES,
pages_per_huge_page(h));
}
+ hugetlb_bootmem_init_migratetype(folio, h);
/* Subdivide locks to achieve better parallel performance */
spin_lock_irqsave(&hugetlb_lock, flags);
__prep_account_new_huge_page(h, folio_nid(folio));
--
2.48.1.601.g30ceb7b040-goog
next prev parent reply other threads:[~2025-02-18 18:17 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 18:16 [PATCH v4 00/27] hugetlb/CMA improvements for large systems Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 01/27] mm/cma: export total and free number of pages for CMA areas Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 02/27] mm, cma: support multiple contiguous ranges, if requested Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 03/27] mm/cma: introduce cma_intersects function Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 04/27] mm, hugetlb: use cma_declare_contiguous_multi Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 05/27] mm/hugetlb: remove redundant __ClearPageReserved Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 06/27] mm/hugetlb: use online nodes for bootmem allocation Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 07/27] mm/hugetlb: convert cmdline parameters from setup to early Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 08/27] x86/mm: make register_page_bootmem_memmap handle PTE mappings Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 09/27] mm/bootmem_info: export register_page_bootmem_memmap Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 10/27] mm/sparse: allow for alternate vmemmap section init at boot Frank van der Linden
2025-02-26 18:09 ` Johannes Weiner
2025-02-27 16:47 ` Frank van der Linden
2025-02-27 17:20 ` Johannes Weiner
2025-02-27 17:32 ` Frank van der Linden
2025-02-27 17:56 ` Frank van der Linden
2025-02-27 18:03 ` Frank van der Linden
2025-02-27 19:36 ` Johannes Weiner
2025-02-18 18:16 ` Frank van der Linden [this message]
2025-02-18 18:16 ` [PATCH v4 12/27] mm: define __init_reserved_page_zone function Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 13/27] mm/hugetlb: check bootmem pages for zone intersections Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 14/27] mm/sparse: add vmemmap_*_hvo functions Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 15/27] mm/hugetlb: deal with multiple calls to hugetlb_bootmem_alloc Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 16/27] mm/hugetlb: move huge_boot_pages list init " Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 17/27] mm/hugetlb: add pre-HVO framework Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 18/27] mm/hugetlb_vmemmap: fix hugetlb_vmemmap_restore_folios definition Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 19/27] mm/hugetlb: do pre-HVO for bootmem allocated pages Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 20/27] x86/setup: call hugetlb_bootmem_alloc early Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 21/27] x86/mm: set ARCH_WANT_SPARSEMEM_VMEMMAP_PREINIT Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 22/27] mm/cma: simplify zone intersection check Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 23/27] mm/cma: introduce a cma validate function Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 24/27] mm/cma: introduce interface for early reservations Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 25/27] mm/hugetlb: add hugetlb_cma_only cmdline option Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 26/27] mm/hugetlb: enable bootmem allocation from CMA areas Frank van der Linden
2025-02-18 18:16 ` [PATCH v4 27/27] mm/hugetlb: move hugetlb CMA code in to its own file Frank van der Linden
2025-02-19 18:09 ` [PATCH v4 00/27] hugetlb/CMA improvements for large systems Frank van der Linden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250218181656.207178-12-fvdl@google.com \
--to=fvdl@google.com \
--cc=akpm@linux-foundation.org \
--cc=joao.m.martins@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=usamaarif642@gmail.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox