From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44FE0C021AA for ; Wed, 19 Feb 2025 00:08:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7F1F2801BF; Tue, 18 Feb 2025 19:08:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C071C2801BB; Tue, 18 Feb 2025 19:08:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA7852801BF; Tue, 18 Feb 2025 19:08:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8AAC02801BB for ; Tue, 18 Feb 2025 19:08:46 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 40D7414077C for ; Wed, 19 Feb 2025 00:08:46 +0000 (UTC) X-FDA: 83134758252.24.8EF9CEB Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf28.hostedemail.com (Postfix) with ESMTP id 5F575C0003 for ; Wed, 19 Feb 2025 00:08:44 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=nevgMhPm; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739923724; a=rsa-sha256; cv=none; b=YD0A3TMTtEjDBAPQ+aPRjhOduOFcHXtpZYoz2t9HagPZhvXv8FTIptFb4DLHHCrtM1i/J0 UDtdSHFbZE5w6G2dZXJDRcm/9tYbg9iAy4Dq6D02ws//tVCdSqmwooUxod4VRaXY2Z1vOF q/fWaSfi0U5vQcI6orWTXoiJ1qj3gV8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=nevgMhPm; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739923724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fYEP5sjpeUc2Y0nGaXQQfZ+FHbFNe9e6LvBIvoWMnEo=; b=VN8qF411SF8/j/xA90lNllgGEHHytHXhFx5sbHpB/yOKACBV9iwGZS2KedaQiuW1JQcZ3u 6hO/cgERoZC4UbUGXnDGlx/dwhnys0feYaP1lXoru31S3Rpc2JgqGthrTIqjlJK7vap5bZ +wj1tKlCsfsQZLr9LCJuGc9FG+4bfbg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 96D1AA41E13; Wed, 19 Feb 2025 00:06:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C28C0C4CEE2; Wed, 19 Feb 2025 00:08:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1739923722; bh=yEwLVxfjgxCsvIUwG0Nns7OEvptA/tamjhpAsrlueIU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nevgMhPmZfs35Lx75GBafIpWH/HozlYHwfXLhMOcdU/oeI7gsLup1xn1MdYv3ovkt zCMLnT2FHCgaGErSWJuKgySdpAq3aq04pRj9HPcYsPosmH10IaYusE0AnXdXSrGkWQ s2TVUOBlVqjywg61C4seFztePff2msU6iU9ZShtM= Date: Tue, 18 Feb 2025 16:08:42 -0800 From: Andrew Morton To: "Colin King (gmail)" Cc: Matthew Wilcox , linux-mm@kvack.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] mm/mincore: improve performance by adding an unlikely hint Message-Id: <20250218160842.2fd9fd47b47704681cad1e5b@linux-foundation.org> In-Reply-To: References: <20250217170934.457266-1-colin.i.king@gmail.com> <08e4a7fc-bd06-4c8c-96e2-84991c4ce891@gmail.com> <20250217191351.0003a6f07d017d80762fae41@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5F575C0003 X-Stat-Signature: 16zijd75rkw646hnrhjfwc8bf4qmq7st X-Rspam-User: X-HE-Tag: 1739923724-143265 X-HE-Meta: U2FsdGVkX18HC/rqzQJpFsD4HQyGJ1Z8Z5kdT+1N7f4RRBFftZ+NOh4PW/A1yznYBP9fvLdSE8Gl2sXjEkk4xOWhcBCh9WIQWLisNkA1wFKVwzzsb7q3Uk2Tz8bzop+Pffp0FRjyxT5SeKAl/sIdPZQPGC5IuiGXKZXYB6ZRO41QhQ++Lz3WpjvRFR5PCgRuXC53iX7r3IS/gcqr+1RxJy44PWTsdjbjCRoAEQkZEWjr16TygUvn3bZAIODdE67CQ1VENDOiUX9ofrFjfKnkAt1QaLsISzpCrJusucUsuaVZ2GzdzlR2p1qMpOhcI/4IlHXKjvYoFGMqMcpapyaK9Ggipwyhl7EDMQQXsyxyTfNEVVCh5+NLSufnFnAxeipsqtCdcLS8jINwtTiAeoi1ykMnZkXIv1oO9C+zlMvCZ24QYZV0ef7qWu5VQ5YBoGKhk8pG0TdEOWZO3h3V/In2wsxEoBmGH22iE04M1N+6lFuO1e8yh+xK9gJ71F1UDmd4iMvOMlT0RIP7BUnGXR3lgJnxKUVcGJ0RXViFQM+ePyJNnX2I0IE6NKEHLteR5xpasEAMuZBCqO5aUO9DTjJwn1EFsV+p1Tlw9uZkMVsazY9Ib1ro3+SiuVFFX44ZtqkyX8ZnL0KxWF7yT5wNHjPRKM4n/Ewm9KcSp/NowVkuaLnB7+q7iUBqQCtryQ2tGjb1RX25LxWC1BQsJCM10qGhWjjucLOZ6c/vziNmWLASdgpMK3GI70ZnPSKP5ljknd7bQmF1lgy/Sjrg2wtnBHcVbMSyCVmli8nwWwZ+MO1y8mGpfJj9IJI8kUfH8g457EJsWKxEvoEgJoZyHwzATe3CljaL520vSW1C0Qdz5GG6gzkInyOZLYlqINS+G6J75m6ExmrX3YLYuuENFLI8GLaBBqxc0N949xC2KCZNZ8blHe8ReShAOw2MY6gSg8ScL4lbq9qasLYNHFNbIyfdiRp FXa8IL+h YtRmiH0Q6a7MqmdRttdamwRvBFBoL3xd+iOwtJzQivF6AUUrQI92fZBdYCJ9MyIJfik280BBvResqpZgJHX1Iijp8co/hlE8eNYsUJfZID7Ea3ndbnPl91Fbt6TBE+/nt0BGYcAmqNeGx6v9xGycikAQY76hp1rrHopdHU8TVSADhhIcrTWhpcOsDht60V1Acmo+Elc+Jdi3rW1Rw1RS+eX6jv9u6DNo8oENhzEEQJKJSIfOQvT8b1rENg2JqlBI11A/cLBNSsG1kJKOSzUea5b/JTg7yndl03WsgDv08nVCGbBPs2kN9mEpAbdcvSdh6mU2OcNEPUl5ZbiIikW7WFedUpw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 18 Feb 2025 14:16:20 +0000 "Colin King (gmail)" wrote: > >> Improvement was from ~970 down to 963 ns, so small ~0.7% improvement. > >> > > > > It actually doesn't change the generated code: > > I've compare the generated x86 object code using gcc 14.2.1 20240912 > (Fedora 41) and 14.2.0 (Debian 14.2.0-17), 14.2.1 20250211 (Clear Linux) > and I get differences in the generated object code comparing old and > new, and the improvement on ClearLinux is more significant too because > it uses -O3. So I'm confident the change is generating improved object code. I was using gcc-13.2.0. Please resend, with a Matthew-friendly changelog?