From: Andrew Morton <akpm@linux-foundation.org>
To: "Colin King (gmail)" <colin.i.king@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] mm/mincore: improve performance by adding an unlikely hint
Date: Tue, 18 Feb 2025 16:08:42 -0800 [thread overview]
Message-ID: <20250218160842.2fd9fd47b47704681cad1e5b@linux-foundation.org> (raw)
In-Reply-To: <cbb812ea-4585-4777-aaae-3dcdcd0bd8d9@gmail.com>
On Tue, 18 Feb 2025 14:16:20 +0000 "Colin King (gmail)" <colin.i.king@gmail.com> wrote:
> >> Improvement was from ~970 down to 963 ns, so small ~0.7% improvement.
> >>
> >
> > It actually doesn't change the generated code:
>
> I've compare the generated x86 object code using gcc 14.2.1 20240912
> (Fedora 41) and 14.2.0 (Debian 14.2.0-17), 14.2.1 20250211 (Clear Linux)
> and I get differences in the generated object code comparing old and
> new, and the improvement on ClearLinux is more significant too because
> it uses -O3. So I'm confident the change is generating improved object code.
I was using gcc-13.2.0.
Please resend, with a Matthew-friendly changelog?
prev parent reply other threads:[~2025-02-19 0:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 17:09 Colin Ian King
2025-02-17 17:58 ` Matthew Wilcox
2025-02-17 18:00 ` Colin King (gmail)
2025-02-18 3:13 ` Andrew Morton
2025-02-18 14:16 ` Colin King (gmail)
2025-02-19 0:08 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250218160842.2fd9fd47b47704681cad1e5b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox