From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99DC2C02198 for ; Tue, 18 Feb 2025 08:54:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1ACC8280101; Tue, 18 Feb 2025 03:54:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 13729280100; Tue, 18 Feb 2025 03:54:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF1E4280101; Tue, 18 Feb 2025 03:54:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D1E5B280100 for ; Tue, 18 Feb 2025 03:54:14 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 805A2C0AAA for ; Tue, 18 Feb 2025 08:54:14 +0000 (UTC) X-FDA: 83132453628.30.8D24C3C Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by imf01.hostedemail.com (Postfix) with ESMTP id 68DB340007 for ; Tue, 18 Feb 2025 08:54:12 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=i3wm.org header.s=google header.b=ODbeG0mr; dkim=pass header.d=stapelberg.ch header.s=google header.b=jXNVxP7B; spf=pass (imf01.hostedemail.com: domain of michael@i3wm.org designates 209.85.221.44 as permitted sender) smtp.mailfrom=michael@i3wm.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739868852; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=758zpFMpsf4T0pGdRX7PvDeXZaVnukHdlST1KAQoIy8=; b=w8QMY/v9Tz/HI2+8UO3cKPY8i6A4HRLpEhD0TH1l7M1xhmUezEiwJboHJH+gf4VGkbgr5Y qkJKgx7vR+TWhzKThLGmUA2MUnnjT/osLlUKT5u8Fzd+BC4/yrmcR8xJEgzUL29cqUvaf0 DVuZE2uiA7nssqb41R4qePG2OyyJvUw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=i3wm.org header.s=google header.b=ODbeG0mr; dkim=pass header.d=stapelberg.ch header.s=google header.b=jXNVxP7B; spf=pass (imf01.hostedemail.com: domain of michael@i3wm.org designates 209.85.221.44 as permitted sender) smtp.mailfrom=michael@i3wm.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739868852; a=rsa-sha256; cv=none; b=4N9GdW7Hed83jjM7ov7M2n8JLbmSfqrU/tqPoRLPDqXEpMKW9zfAv0K2GYsCJ5opkN1pAb McjgVF+gvTDgJFFqq152eXVAYcKwslSFLe3MbPt6+EBJqqNzMpUak9fzQkXMnEQPHIx0hs k89Y70mHXbANO7QOPvHM+Z/L4TMf9qM= Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-38f2cb1ba55so2956334f8f.3 for ; Tue, 18 Feb 2025 00:54:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=i3wm.org; s=google; t=1739868851; x=1740473651; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=758zpFMpsf4T0pGdRX7PvDeXZaVnukHdlST1KAQoIy8=; b=ODbeG0mrRAhcSagzzikHB/GczpeaSSjzIhP/uC2dih5zU817SpYhsRdeqdliZW8Wz6 0CDOop21ACM5jAg5qrxbXONKPpEIKWMdyvEt/IaXDl6yuhFNQZXKvyzR2hXHh52zR4fg Uv96XlWnaRhNOeH/nS5sIwygI5eh4xetydz31jxJ83U81UjKVygIxNvGIKrPpK5GzSsl HfYkZ5u+6ChWd9kcDHwDAXgrsHQ4nLsFBEQ0J3AKKsj6PPr3qP2f203WmD2DsQiqOSK/ MkK0RnPZ0dKkNm4heXmvVkAT9fp1IZabej1vUwfe7jzGIgPymNSkOlSkZTSQusU6Y2Pn yK4g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stapelberg.ch; s=google; t=1739868851; x=1740473651; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=758zpFMpsf4T0pGdRX7PvDeXZaVnukHdlST1KAQoIy8=; b=jXNVxP7BKEWRe5ZLQSNudjLkkG75AwUX9qdxSWsGBp/74M2fOcKsRV9M5mx9qUH+qT 6OLzcwcuMsh1EIWC9ixFi1LCJ0zTjfVhgG88NLgiZ03VW68kjKtrPm7EZezdXuW+kPwD 66N8KBvmZFR5ZYqv7qa0aOEqEc0NV4Xyr5nXDrMyOun9PC9wh1VFiWgR0Zha5Xy40Gkv f00UYWCaXKr8/EmV3JEZaa6sLGwqHPpWIk3/imS4miM9JmJFwtXLz3JYzIQHa/WXdAEK Bv03ITvJ+g2R+Nz0jV0RkqFd3HqPJqvWgGNdI7CuQejH55YYhKjcvNTH5bP0UmeDBSGJ KDbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739868851; x=1740473651; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=758zpFMpsf4T0pGdRX7PvDeXZaVnukHdlST1KAQoIy8=; b=QOqiAqNnAyNQHOOQy3HLI0/ZOmzbKdHuOt/JJ/QYCuiESV2SBtyL1YE4LE0kaAjurv An0xRjtBAU6ps53GMDHaQ6uRw2avIgwa9QQID2XeY4NCspNDYajO97TKtAx44e3KupmP FZnIYtPEoXA9dQBsbR5WG7NQNelSwl9ueDEx78h4Wj4e2bWVWHeywd8eH33t24qOojVw xNtKeF7/UL7FJZGwSwW1ddzCgFHxZQf+PAq2N1m+SWvH7Mb4KaWg4nl+UMXTnn9uZ0VU xRJmkzJorDQJL1E/igXLXzwy08RZAtExPWt1YVyItQ8il+gp6d7ORIOXOv4kV7tqutOG fNtw== X-Forwarded-Encrypted: i=1; AJvYcCVxUHDpAeiL5Lhy0032RqFar5jRZx+Ce9FHpjDl1XtTi2/nNMMEENHB2A9/TsYJLg1Wwi7ZydNNHw==@kvack.org X-Gm-Message-State: AOJu0YxHsJQtQySEK7KwV3NjUrd0jJ5OiAJk4O+51RcAJ4ed3BuYdCvA s5sIkbnjUvJsTMGhbE81rxaBiuvDbUG8jpmTBPcqmjLw0LDH5fnHVhfXFlJHJZM= X-Gm-Gg: ASbGncsH3bHMrka9/MpjcerYziwtY1pBObFLBp6VDNU32wgq70j4Un5WYpV0FneKQj2 jJ0FP2Z1tNtfl2cJts6a6ACksb0yikN7pdcP5PNUyVnmO1QLg8aa5AgZEF2tpqAVQYyzWiAyn/Z g/uv0T0sgyKcl1XFWgMU2MIjOQO5O8yeT8sOKIOlM28m73J6ry4zlq6VseH0Ka1Xo1zwezgTtmb BH1pb3UJr+hbzOJZ6dejT8TbVxqpvO9DzgUHiX81dBjOP5O84cgLnZib1a6Vh+sedrCv0h7Ji4+ M2x1xmAiziF43w== X-Google-Smtp-Source: AGHT+IG9SYoRvEq3m0HtuwXoCMJqDOynlqQun7kLkdRbUn0QNGwSb00dHbCF/DGeSWjnCNLlYUxPOQ== X-Received: by 2002:a5d:498b:0:b0:38d:e411:7dcc with SMTP id ffacd0b85a97d-38f33f44cd8mr7957635f8f.37.1739868850622; Tue, 18 Feb 2025 00:54:10 -0800 (PST) Received: from midna.lan ([2a02:168:4a00:0:62cf:84ff:fe65:d9e3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4396b5267eesm76997295e9.0.2025.02.18.00.54.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2025 00:54:09 -0800 (PST) From: Michael Stapelberg X-Google-Original-From: Michael Stapelberg To: makb@juniper.net Cc: brauner@kernel.org, ebiederm@xmission.com, jack@suse.cz, kees@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, oleg@redhat.com, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk Subject: [PATCH v3] binfmt_elf: Dump smaller VMAs first in ELF cores Date: Tue, 18 Feb 2025 09:54:04 +0100 Message-ID: <20250218085407.61126-1-michael@stapelberg.de> X-Mailer: git-send-email 2.48.1 In-Reply-To: <036CD6AE-C560-4FC7-9B02-ADD08E380DC9@juniper.net> References: <036CD6AE-C560-4FC7-9B02-ADD08E380DC9@juniper.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 68DB340007 X-Stat-Signature: otr8kteauut9zxkzourwgdg385hn793w X-HE-Tag: 1739868852-766601 X-HE-Meta: U2FsdGVkX193jJmRkV9gOLU7/i0gVz7bzIr+wZQTnro6AqjUUVhy1U9/v31xsIPkuqLqjJBX1sczJmhbixVw4QvA6NkM68OU2RAdj1nNYaoVINHvBMdZ2OYo1/jWPHWk26unyD8gNvPSFnneVcqEGgKvG2vVut58WOHo6jnndpby6b5Tb5KaKb/j1nNeMX2eosYzCWC+utZ++qCprUHixi/wpCHebftTQxSysUuA7vU4IkWcCAAQDXfkePtSi7wAedP0LxtrwnPwaYXk/YalF+EJzI3zbxNJa1rkUCRF3UBDX9REroVs+LSGGkyAXZuDQHuIWyPxKfuOenpoSUENMc1v7syT3YUdFmMwHtmTemUSxsW+rlMKrdt06G7aeZXvA2a5JyGIhOkKsURv+AB9aUiajf69DpN5arG1Bbqzr3WR7jAurZXkw6g7POETwH/gurXZ5ENZ17+pzxvbPSLDuhPncU7O/DGZn9IwtQ4xMdj13rrjgAqMYmN/10oraQG9DtkOrfOcyVqpumZX4W0dXxpd4ncI1ZwNVIIx/fbp+eoQQBRy+7io/M0wbpPtS8sxx+xodfP8J+o6wJkhD9gj+AHtx8eaIjst8DUegOneis9eSShitqnA85guSrJkKS6Jc68ldWQ4MZy+ZbYeJQXG9tHCvDjEXllU+h4CLzptY2YteuzvyhoKI6yyqwZx01O8he5aXFa0G0dmADsbFBMMSOz6cbl/c0mG/wGmGVt/s5ycX0YHSfVVmwPfDMblic8XA9M7dmvokRiMcaIyiSaz+mvDCSSUzlu2GwqYLCTxlESp6X9eRWc/yIrbc+cNvBD7mLhKm1MeAW3ZNSYhSuYp21IIPqe8pjhRj1ZeZf9zITphGqET9vSkPnSH0MfqIlkaACn1vZacf4pbouySvzFhr7C1YmBc8nnUXhBpaKWKq34hKZUYSMAVJgwOwKXEDr/iV6Cz2EpbXOT1D2s3iET WwQfZFK8 S/vKe7Sp6x8mCE9M3kLiL/pPv7JCXG6IF6xQbrhfK4awidMOE3zztFN0tcfc3JGum7SJdqEAJetvEOj6bffQcnsoVLyUAfv2caKGHJzndOM6ueYgmg/Mp+9g6tGOSL4vmxOBpuypdAG19Cbd+0cyslBCdh5oVb/Q5PWPvbv4GyXt7bqdLrmETFGmjF3WwfaL0vJhbna6mRq8Rx3Ghl7XQ8BYpKf/jRihG5Zd0CYRkShYTl59TFbYivQiHBufnnEdF+ERWD4Wwz+taot49ru4LDf8x3N0HEsbpuTfPNTI73VVf5veqpnBjlbWonYyKBGcli0oXRRtJ44825u3d7WbQF1p3O+cFioSR07ODagNt+Te9LBo5ZuoUh4Vhj4+KSfRBVMJINedMIipZtmASUxwgcYg51imqopOL5zAuupAcAzI/I6OQdtxm08yZb9IpvON/ePOAntkswcVri5UNcfmmqKuuYCuUcsIu1TWq3n9+rRg3qy/Enzs7hpPM5umSqrd2ph1T5NljeOa6G+njkgdZQVzoMA6ggBunlyetCJQN50HGTnpBUXv/wofJz73QuyuNe9sREyn8/sNXB0eOGZ84Omrw92sdue/lCxq903KkqJ1KwryggmWu3kx4OGk3QuzGX4YRCONgu0KPoQtqZC9L8bvUqO+0H1v3Tqwk X-Bogosity: Ham, tests=bogofilter, spamicity=0.424041, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hey Brian and folks > […] > backtrace, and it turned out to be a non-trivial problem. Instead, we > try simply sorting the VMAs by size, which has the intended effect. > […] > Still need to run rr tests on this, per Kees Cook's suggestion, will > update back once done. GDB and readelf show that this patch works > without issue though. I think in your testing, you probably did not try the eu-stack tool from the elfutils package, because I think I found a bug: Current elfutils cannot symbolize core dumps created by Linux 6.12+. I noticed this because systemd-coredump(8) uses elfutils, and when a program crashed on my machine, syslog did not show function names. I reported this issue with elfutils at: https://sourceware.org/bugzilla/show_bug.cgi?id=32713 …but figured it would be good to give a heads-up here, too. Is this breakage sufficient reason to revert the commit? Or are we saying userspace just needs to be updated to cope? Thanks Best regards Michael