From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71025C021A9 for ; Tue, 18 Feb 2025 08:28:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AF222800FE; Tue, 18 Feb 2025 03:28:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 05E322800F9; Tue, 18 Feb 2025 03:28:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E69442800FE; Tue, 18 Feb 2025 03:28:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C499D2800F9 for ; Tue, 18 Feb 2025 03:28:01 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 51DBA1609CD for ; Tue, 18 Feb 2025 08:28:01 +0000 (UTC) X-FDA: 83132387562.14.5044A10 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf03.hostedemail.com (Postfix) with ESMTP id 672B220004 for ; Tue, 18 Feb 2025 08:27:59 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=UoKlHSOz; spf=pass (imf03.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739867279; a=rsa-sha256; cv=none; b=rxOuuzAVHOSuPqFRLuaSVoX3yeSLHSaBVo6ecZXhTITY0W9YXD5jKQTNOrkOC26ewpp/Xz XoM1fMh4vcSH4d+eExsUtxUwrW/WDGBGpSHRq21bGLlnNE1PSrG/eZC5ye2JLKpMS8TgEd /n523EMUNzm8EuIsN48W1JvmaNbNz9E= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=UoKlHSOz; spf=pass (imf03.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739867279; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jAn/HNcN37jbOxycChzF/f77JjKiI97PDWxT1WP+ZdQ=; b=ig1kIWgPdYG6sLHzY8IlWF5aH0jVjtIxtAZHWKWplGsT2DvukYOCuoLxsi0ga4gBbwbZP9 +KCMPTRaxVrUvEnRQkl/q5t8mW41IlE1thFLBfzWsw+WtJ7vH/1CGjLyxaQeGIJZxE3vyn BueMq+hx/yVIh5nJvL1FBtBqiWXM+m4= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 33B3940E01A1; Tue, 18 Feb 2025 08:27:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 1jdlKZXk4JKo; Tue, 18 Feb 2025 08:27:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1739867270; bh=jAn/HNcN37jbOxycChzF/f77JjKiI97PDWxT1WP+ZdQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UoKlHSOzJAu0JSvQFqfJYA9VfpBnBpdcy+1rmxWYA5pGqGdTKar0S7NRvWfUYgf/P 0mjWPnZOClBlKipV5IspJBaBhQCiFkgLcAY64SB6Cj+JTs3cUeQ3EcDoAasH6jwalU Mn3IXfZNCeAH553uN2iZ0RGWFqHYl5oIO0TTyt+Oxtly+ARdyMV4Uz0/0ZWiVGFn9S SvbvuFlVnawHGcn4p6qSG0g3gZjkRgLrRt5FnfI0TgIKqQWFAC8r3zfZ/O475kYvGZ lRJKn1gtrHf5j4nrrC8zOFoTAtZ7CnID06cVx3k4a2R//Yu3jIYqYYDpEAtZvWqQaN 5wLQ3bb2BiuamJ6xpV2Ki69A1oZk3yEiTLv+k/9pzD18A/b0nUyza17Fa5wIZyjLsI LKfOSsWXZ/hqJtPFo8EdBhGZKAWCMdbwu+TFsWFFF+GK8K64XO3XjiyysD0XoDeoaS dQefxl0K3X22C1JDh+lhx8TJa8Op8GG/uvxyfhE1iuuEYkoB5auo+57Hi7mLS87cmu YCsbhTWtA8ovVjif1o/Uk0k+3yRqvapxFmJjEG9SgUYwZII5KxqInIw7QZgTZNBhYe UcV0Ip+LOSpb5b8oCelDUcgZH8EaWxkWiYm+PY9m+VYXPGtVExwVAIWplbO+yj9x7Y ySs9TH3AjydRhA609hjHzfUY= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id C000F40E021F; Tue, 18 Feb 2025 08:27:32 +0000 (UTC) Date: Tue, 18 Feb 2025 09:27:27 +0100 From: Borislav Petkov To: Shuai Xue Cc: tony.luck@intel.com, nao.horiguchi@gmail.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, linmiaohe@huawei.com, akpm@linux-foundation.org, peterz@infradead.org, jpoimboe@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, tianruidong@linux.alibaba.com Subject: Re: [PATCH v2 0/5] mm/hwpoison: Fix regressions in memory failure handling Message-ID: <20250218082727.GCZ7REb7OG6NTAY-V-@fat_crate.local> References: <20250217063335.22257-1-xueshuai@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250217063335.22257-1-xueshuai@linux.alibaba.com> X-Rspamd-Queue-Id: 672B220004 X-Stat-Signature: ty3qhrhjxz3b5tyreuw94shjcp8nq73q X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1739867279-511976 X-HE-Meta: U2FsdGVkX194paz1W5xcU5XTLjB2vms6o6puB1sU99WtQd/gPCye6rek2HWIU38R/8VY9afR0JFOOwBP1naV1wXW4IQGsrt+tqHuf4pSYmOIM7nqM6bUsFmxLgy90IKKbaZ97CnNrzLVtBIeTMTwVcSa5+3WtgisXgJItmdr+qslJ0a5TaCiOlWJ91VcA0E9ABUJJ1MRfJnq2kIDOW5yVPJ1gpr/Wvle3GA7KtZgTL6CMMPbrxHCBwlBWXteBymjU6SWR3xZqB2BgDW6bwdIyL3UvtHU5/6ue18C694wrwhk/glCj8S9fLWqBHXQ72ycO626hyqzK0Tphbc67wYqzOLB5iZ9mwvl7bkqcQONS+Ubqll+DIijqdkf7Bh+rKYyDfM1uh5NQ6yh3AQRHn2RGmLCKebmeFYxlLpJqQIdPXSu/MmgKQmqWYLhl5xbBQyI4xk7J+YxXR3o/CVO/y1+F5cmyAdglLW0ekfGb8+oM6KgdXn80eU7HJ8IFpBbdD7sBbDXctr2h16qsy8/fJGPp9S5K3vHxYspwawwr58ZkaN0mw0MAm7eD9eN+dRYD3YYLtW3D1F7sdwDi4AFkeYbExM61weX0UpFszRQ1kzu7KKaVYEP5i4q0pIhYHsfc51HtaT8I5TSp8FuXIr3SfDjEqrbkNLTjeSQi6Rz8CsWa6apHSrvBEpC8VhsClaJ18hiYIyWtAdTG1CZ9doBHlvF2jkbgpBvyLjxLL4C1yn4CDeOj0VV7pJ5yW/Bg+MLaVIkO7QDqvBvMNsW5mlf3s9C8fIXwDb6jD21x3AaAzkOC4HiwbEkKok4d+jKYO0pBnK+zj0HTXUNok1BKtEePeVxi2U41Vjt1i5IeqiucQSdqlqlQRySmxCGgYyvp5XS3c6qEllYeIct3WoddE26jYu/5SHYzDhVcU+BnbgyCp7NozFfFeR0PDS++NmL7NSptRmr4tfLbgzM9vxgEJ5T2G0 xs+OL3wr lHc4rmqkcoXF0u6eb3WINru1+EdykKfKCF/q5/Zte+Uxt5t2jo2xMLptVI/ckOCSA7yEu+tyNPV1DAXyGTWdr3iVDEUsNl/25cduwapAL0iRabDBtLcqgHd5NrAdiWq63amq5Vu2tXB7PxNk+2Ic2YXKKd8AgU/4IU3vfi2eq+fRBEUTtejIoaSxxgqfNoHCZT0uhBIe0r8MAKkd0rdpUrqZokaMPEMWajxBWRib2WsJc3RFTWGrZH8/5Syi6di4HmpIbT34E1NbA2ceuvt6zJADo80ilWimMuN1CqNrzZzeva7bg/fietaiSFM/2NItdR7RIkpv4l0hpBHkBm57YkrNsg4hI+2tlyJ4prCTg7ISSiKLRyTkmeDYZpahcP7WOSURJr//TlcqARFhzEWpMy31S9cfAgLQWC9r10UMjVkEZ988S6QxQ1uzNzehkmN53J1FwtB+X8XWcAZbA6VcQfEqd2rutN2VYwVzXXrA4EDuvcExLpQlXeDuGd6VLT2e7tigd9ZEej7topzOeFlreZLl1aiu/SyjoJg09fALs/0hKY3+E0v7zBgiKTzmL4bjOC1vT6MBUnLGy5+LN4b7wS2FzDiyzoiMfnVBmeuXCGRL1ZZ5A+4CbpbqSadSPEsfsyAGNcd4K1NVhUj68+pu7+zu+iKVDPTatBgH8za+WdNPfRLaZxx9SZVrJq4WAaAw+ZQEzFAgmcJw3jWZiqmuwgtM6QYXvYKeF3cmA7br3oHKhH74= X-Bogosity: Ham, tests=bogofilter, spamicity=0.021576, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 02:33:30PM +0800, Shuai Xue wrote: > changes singce v1: > - Patch 1: Fix cur_sev and sev type to `int` per Tony > - Patch 4: Fix return value to 0 for clean pages per Miaohe > - Patch 5: pick return value comments of memory-failure() > > This patch addresses three regressions identified in memory failure > handling, as discovered using ras-tools[1]: > > - `./einj_mem_uc copyin -f` > - `./einj_mem_uc futex -f` > - `./einj_mem_uc instr` This is not how you write a problem statement and explain why your patches exist. You need to state: 1. What are you trying to do 2. What is the expected outcome and why 3. What actually happens and why 4. The fix, in your opinion, should be X or Y Not quote some ras tools commands. Show me that you actually know what you're doing and explain the problem in human understandable way. And then we can talk fixes. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette