From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FEF3C02198 for ; Tue, 18 Feb 2025 07:59:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 024962800E4; Tue, 18 Feb 2025 02:59:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EEE8F2800D6; Tue, 18 Feb 2025 02:59:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D42062800E4; Tue, 18 Feb 2025 02:59:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B2D732800D6 for ; Tue, 18 Feb 2025 02:59:32 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 51C4BAFF89 for ; Tue, 18 Feb 2025 07:59:32 +0000 (UTC) X-FDA: 83132315784.20.F5EBAED Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf21.hostedemail.com (Postfix) with ESMTP id EA9C81C000E for ; Tue, 18 Feb 2025 07:59:29 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=gucWHkHv; spf=pass (imf21.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739865570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fKnAU/KEF7MFmyqTMzT8Xecp54gHhgt1Av8J7B4+x8M=; b=GWobjPM2TYBaDH/hs3ZNN0FFVQyB8jXRU+Fj4jT+1cezj7GqnBLCSSM4bHwiTmLUApdwFl lZNCYFGxNyn7/nFgkczHORIGufXIBaWpBQW9vniif2T6ZAirq64dYQxU6fzqjqVvQ/S1I6 nRXEJRB2TcV7G3873uLYw4bohzQQOOo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=gucWHkHv; spf=pass (imf21.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739865570; a=rsa-sha256; cv=none; b=U1V3unoLiu1VwLYIT9kNDFRPxzMV8Eq744WroXIM5HJeSMpQYKPg26JJoA4hlXo5IPdD5p J0DBK2+Jx1xi1ymqlAX4Isl7wshpg9vBIG/4yvkWy27dh7PHoHLmQgV4jM5piG0gd99L6e XApIh7k1Qu7FH3nYGDLJSgPChPlDjvk= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 81CF940E0212; Tue, 18 Feb 2025 07:59:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id gQrTBomRItDm; Tue, 18 Feb 2025 07:59:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1739865562; bh=fKnAU/KEF7MFmyqTMzT8Xecp54gHhgt1Av8J7B4+x8M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gucWHkHvSldV2Ggctopr4jGimaqrR3MK9VEo6eOnFu0C8Z5MxqhiJn1PS5T6CRF0t r1pZLliZLk7JWUwB31b+HBNL4oWQpvOktGYEm2lFQ/dx3d+8FXVBbSE0UDGenVKJ8G HU15damPO97VjzSf4gjxGs4FwjwP+FZXXzGdc8VKc7//Z/UR1aEKvzqrtv4MHjSwau PywKfc3Jc0W/Dld+/7rFBl2cGlY/vFmSC+nDbtS9507L8P+T+HqZzB2LFhFqsw4hLv tgcK6lAuQ2UgBuPiRcRFZXu1cEx1/Ob2eQXg9iuNvkBCFChwBFOnklCdDVtpbSuAa+ tmnPFSQXwLPPZgbDqB+UEMhNhxsyxNJtjSvKrcPRyy38koyCFgXDDUu+ujxkdffomG tsIXYbiDzvQXc0sjcnXqQTi0ImfmpvETZLaAESZ6DbMDP1zdwGe17fdrlYaNHCBRyZ Z39al1oD7Vqsn44UCQTwuoRCw59eFnIiub0+fFg6/jqvbFsqGw98OFaEo4p5AzV2ls C9KtNZu2NMa7F5D8x4tXZZwBF6jQ0pH0fQznD4QwGhvAOubp4VnHjrACfdzGu9WbLx m9825snpbUITnCKZZ/tRqgzoxB5ujbLm04ZaElgiqF3SaKGAi5X+nDxzsN9xi8kwYX LKogMSFQphEd4EIlPLrEN2MA= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2AF4A40E020E; Tue, 18 Feb 2025 07:59:05 +0000 (UTC) Date: Tue, 18 Feb 2025 08:58:58 +0100 From: Borislav Petkov To: Shuai Xue Cc: tony.luck@intel.com, nao.horiguchi@gmail.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, linmiaohe@huawei.com, akpm@linux-foundation.org, peterz@infradead.org, jpoimboe@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, tianruidong@linux.alibaba.com Subject: Re: [PATCH v2 1/5] x86/mce: Collect error message for severities below MCE_PANIC_SEVERITY Message-ID: <20250218075858.GAZ7Q9wp_WQUsjq2AW@fat_crate.local> References: <20250217063335.22257-1-xueshuai@linux.alibaba.com> <20250217063335.22257-2-xueshuai@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250217063335.22257-2-xueshuai@linux.alibaba.com> X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: EA9C81C000E X-Stat-Signature: 8fjn4ddc64z3fpd6ruig1broaupe3b9x X-HE-Tag: 1739865569-269914 X-HE-Meta: U2FsdGVkX1/yDJchIOfp/guMMQ+6CJ2YgOPij0d/eI8Am8mQuSklZxyjtuIsHdvE/X8OBz6y9SYBmKeiyPob/hvDDQznttxDXVLC+1keKwwMFl4JJk77nAd29pQWjzp1PUbwldJVsx4IqgKcNvsOZRG7lm/SC40aZfLi3o7mPEmYMudXSX+AtxVi0pOzjIDRR5KjWBwB/x1l/YlWANCEO/xkgT18gw1liV5DPUZ/deylpbmipk9t9rj9O/Ls3c3CW4D6NICq+2IixeygaWZb9ulxNTq4TE9nXk99x46HhhG9EB9ByFDOh//1+HNiNu1Wc1DSxGg6aYU8pFW3D1ETdN7WP69RbQUCIzuOhM69GZ+rJYWCC644bimfJCIhiHu52hHTE/piFNxP7X6IapOdAwbV15ZDV75OEUceT3/O5Ntd9mNF1WlOFZnau19ZDxwmBZhnsH3lXnEfGNqaNfC8A5Be5xSPx5auXSl7NvRpqhv8ipIibjAq9IZUluuWjhNKycntRo/61xczT8iQsUdMoO4AfMmvYj30QbskSkupgZ8Pu20lBotAxBJUyoWaziICuKwMTvivRRNMeYNi086pelRF0j2bM7IDdRc3oWOzccyWeVcgPukSBxi6OIol36LXIHbR3INe73vhGnZzOZbBHu0tEN8d4SMIWjPGB3OM/EJCdA0IQK3iOngQdGM6HeTZv50//l37wsaQqq9ior4JPu2wf2RP55yreJig827xAaKB/ZdIswv5bqvBZXoO1hp6clOAKtOh/5i4pSA+QVwsyBM2eUegvUS52qBFE6TtMBRWv1R4nqCfY0J2Zmkpr11rB3QCj8VsTx2//EetFUdZQImlR+gBBwkkAieLsUlhAZeGPosvNXgVsmvHfvFINNvf1DzoxOBXLLk1dJtXShlINXWhiwaWH2D9AjpGuxmFfgrNZup8ppqe7fckP3B6QYxh9NWpr16C+8FwTx1sV+9 mKomRK74 XI3TadcAwrMyAqQrwwIPcg2uNzhprSwtlkVMlizJNFUAMV0+oK64en1FM1YlsgLWVU967udUJBZjXemdsgH469jMfC1Mecyhp5A/D/0bOq98RN8ypfGdP/WKiq6ov5yztLVzvSnan3awNH5Cv7C+rn/Dfp0UY0rRQ2N0T3XzeHfiH7AQeF1aPN/L1K5gLxZQZoJrnEMRwP/I6dIB8SOfVFXRjMR92vZ1Do1EAx/x093vv9gthmos3jmV7Kl+JHKkQdjQBHtTTq6zlUNBag/QA2wvilLoAEt4XirXg0bYQPGugMMClpFf3T+JVAIhNDYMo6o/sx1r12T97QQQE0+hKZmBhEDBnxafAYRGkJ4c4iB8oKTZ+9NA4CJcD+bQ9AtZ5NWx02ZL4o6PCJrY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.301977, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 02:33:31PM +0800, Shuai Xue wrote: > Currently, mce_no_way_out() only collects error messages when the error > severity is equal to `MCE_PANIC_SEVERITY`. To improve diagnostics, > modify the behavior to also collect error messages when the severity is > less than `MCE_PANIC_SEVERITY`. That function is literally called "no way out" as in, is the error severe enough so that there is no way out. Now you went and stomped all over that to "improve diagnostics". What diagnostsics? Your commit messages need to explain in detail why exactly a patch exists. So nope. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette