From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3164C02198 for ; Tue, 18 Feb 2025 04:21:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 355202800DC; Mon, 17 Feb 2025 23:21:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 304802800DD; Mon, 17 Feb 2025 23:21:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CCF62800DC; Mon, 17 Feb 2025 23:21:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E783E2800DD for ; Mon, 17 Feb 2025 23:21:31 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5F5E71C6368 for ; Tue, 18 Feb 2025 04:21:31 +0000 (UTC) X-FDA: 83131766382.13.0BDF070 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf14.hostedemail.com (Postfix) with ESMTP id 9AA35100009 for ; Tue, 18 Feb 2025 04:21:29 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=T1GPH2K9; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739852489; a=rsa-sha256; cv=none; b=szlxcJgbGHWVDDDHMhTa1WJN3ZjNkjQldHZp4Gd0YSyd4y7fxmw9zf9dtqXQMeQI5E2wnu ea+KIyJRcQoP0FLb+eViT/Dtc4kCL4tNlW0gM5b7NZpRk9hA4CQ8YxV5uVqXMOnaptMi+6 /Au2qKza+sg/UFtUI5gbbXj4zyKqRAo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=T1GPH2K9; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739852489; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qCTsFCYZwmnkybsStaQv8I7vhNRjBkaoIoFGBVKcIRg=; b=cZOlCudDynn1PqBI5z6lPCCrkz6AO93KtmqXI8rQPwBLBRkytE+4Cb/WTgwKfPIGk/M460 jjNLa61dD4XCk4ztEcyQibY0aWBcTg4eP1Id5fRK9ac0gwWh00KD/M/ASswNCg0IoJua25 GBSEzscmzUEGn+Hxt0DrOuiO38uk3ug= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id E347FA41D24; Tue, 18 Feb 2025 04:19:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4619DC4CEE2; Tue, 18 Feb 2025 04:21:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1739852488; bh=Y1WjWrYTI9mRHUBKbBcEKfoQLokHCNSELxid2QG5Cfc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=T1GPH2K9XHsElMReQc3f1esMMdNpUNC1G/+/KFFdRGdxzbdGY2Xrg72Sr2h0Z+UwC 6dLWVcuON2eB98DbKqWD5RiAdmf2HfZfcEaSgGuF3VP51kOPG4UhmBFlmlLmlmi+hl v8Ix512h63FgzcNXc36TiQJP66GdEJFdjTUkMaGA= Date: Mon, 17 Feb 2025 20:21:27 -0800 From: Andrew Morton To: kernel test robot Cc: Shakeel Butt , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Linux Memory Management List , Roman Gushchin , "T.J. Mercier" , linux-riscv@lists.infradead.org Subject: Re: mm/workingset.c:621 workingset_update_node() warn: unsigned '_x' is never less than zero. Message-Id: <20250217202127.cf92afe2c0a89d5865e1811b@linux-foundation.org> In-Reply-To: <202502160323.ZLUfooA0-lkp@intel.com> References: <202502160323.ZLUfooA0-lkp@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9AA35100009 X-Stat-Signature: ehc3bzfwb8mzg71hp4gwf64dcg6ost9d X-Rspam-User: X-HE-Tag: 1739852489-849819 X-HE-Meta: U2FsdGVkX18TxB2VG6xJS2FJwsvqBHo/AXBg87SIYtsCw0OFdM3kYH0EcxPp2KxTaIqKvpUgUsUDUzedRbVBgcmHBBJWrQ3Az/9RlzYN0kRVRqNMt8+wA4B4tE+b3c3H8Fmajqy6UjowzB32ynQIPbO3uMp4yxp5SMkCCl/QLSJbuTmrivopuVWGHwFHG3Np/DFcik/JrxMJdqmp2pfrE2jmTJN89xw22UPEQ0dxGN5OGUZynLK37EoI1g4/v7nz9cNj2q+rJc32jeXOYou8kGLJPyki7jDvrKhWzXvXrL4g2D9rTWEnAWFVKe2uMW20X5TOxae7xNU+wS+igZlh5WtSNPT4OtkoiltOJ4NGJDN/UdKyk8llV/6F5qxDWjKunD+njgowBWXM8ISfvsLVi8cO9MiwuOZI5Q+5OU0SK9Hy/TgLdP8suqbs8Ptlr5JvwwO/C7B2Xa1gUoCJVQDm6aXWQqV1u+VRM/QVFMKGVO7g00m5T+fOvWbqDoSjE8+c1GArEuDB3I12En5JOD7b5SGbsHr/r9zB8PX2izXUcN9NalSErrZEnWc4q05Hcg048rnE27xO5dF6iTS6113RRHY5Wp/pV6uw2ipbd6ioQOWDoLh6MYfGB4RyNDGLv4uQ+1FN6Q+dgCwJzKzLqSu28vR868JYTyNRqCusqBy3Fat8c6GF01sb9eVWpGT2u6J1Mzu4fjLD4ZICDKe3aA5w26DPW6xxyXle6tT5L0F8WE/6UpGvAXXoDjESjYokJyOchc8oy/HKBNTBDgSqpSLVVX6bCS2+KnELsAAZo9bxnZ4xMMSUukXSM/D+28DbUvYFE8/CVreKmYY8TC82nMn/n22N1VTyR5mreUfEFxiRS0zXQxx+j1VLDPbNd6MRJfU6lhz9PrklJHFLk9Ops94ddwNu0MmXxQZYzLqcHra6yp1kZl0UAf/EddJyljFvgYa3vTR3UWlFAxa5KCCv015 Re5Nlnpb +VMddLMBT8J9+5dwmMr9+PmvEV/6AwHnGYTO5tECOIJNjOgMdHM4gcRVFC3B14ajY+RB6qx+tefI0+SRerkBB/rG7KZZmJE4kpdhG/d8Y0umPwGh8abs5jzRq7tg+G3sIUyL7b8KfX3VhXXGRw3W1wIhFkG4tvq2O7/0uj6jyLucpEozqdRmoBi/JVU8CSiQNhS1rQtdom1kTbx7XNzVVU8Ik+HFvFd23m8Iv0Z72E9LgQrT4X214zppCWB/L/euKn7sxNfvkWeftUhcwGSJwOlSymTJyO93QGHTahUCYW31cIEXiC7/lHFxlXrm+X6+8J/b0aytSFAi4PUYeKoP7eBRpsIBfGyfarysKdJJYrCtUnkqtXpF4bLJ6dDUD9RVqWj+THU/Ve0Vu2DDJ554c+7JCoA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 16 Feb 2025 03:56:06 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: 7ff71e6d923969d933e1ba7e0db857782d36cd19 > commit: 4715c6a753dccd15fd3a8928168f57e349205bd4 mm: cleanup WORKINGSET_NODES in workingset > date: 9 months ago > config: riscv-randconfig-r073-20250213 (https://download.01.org/0day-ci/archive/20250216/202502160323.ZLUfooA0-lkp@intel.com/config) > compiler: riscv32-linux-gcc (GCC) 14.2.0 > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202502160323.ZLUfooA0-lkp@intel.com/ > > New smatch warnings: > mm/workingset.c:621 workingset_update_node() warn: unsigned '_x' is never less than zero. > mm/workingset.c:746 shadow_lru_isolate() warn: unsigned '_x' is never less than zero. > > Old smatch warnings: > include/linux/mm.h:1306 virt_to_head_page() warn: unsigned '_x' is never less than zero. > > vim +/_x +621 mm/workingset.c > > 617 > 618 void workingset_update_node(struct xa_node *node) > 619 { > 620 struct address_space *mapping; > > 621 struct page *page = virt_to_page(node); We're seeing several reports like this. It looks like the RISC-V virt_to_page() (actualy __pa) implementation needs some attention.