linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: kernel test robot <lkp@intel.com>
Cc: Shakeel Butt <shakeel.butt@linux.dev>,
	oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	"T.J. Mercier" <tjmercier@google.com>,
	linux-riscv@lists.infradead.org
Subject: Re: mm/workingset.c:621 workingset_update_node() warn: unsigned '_x' is never less than zero.
Date: Mon, 17 Feb 2025 20:21:27 -0800	[thread overview]
Message-ID: <20250217202127.cf92afe2c0a89d5865e1811b@linux-foundation.org> (raw)
In-Reply-To: <202502160323.ZLUfooA0-lkp@intel.com>

On Sun, 16 Feb 2025 03:56:06 +0800 kernel test robot <lkp@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   7ff71e6d923969d933e1ba7e0db857782d36cd19
> commit: 4715c6a753dccd15fd3a8928168f57e349205bd4 mm: cleanup WORKINGSET_NODES in workingset
> date:   9 months ago
> config: riscv-randconfig-r073-20250213 (https://download.01.org/0day-ci/archive/20250216/202502160323.ZLUfooA0-lkp@intel.com/config)
> compiler: riscv32-linux-gcc (GCC) 14.2.0
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202502160323.ZLUfooA0-lkp@intel.com/
> 
> New smatch warnings:
> mm/workingset.c:621 workingset_update_node() warn: unsigned '_x' is never less than zero.
> mm/workingset.c:746 shadow_lru_isolate() warn: unsigned '_x' is never less than zero.
> 
> Old smatch warnings:
> include/linux/mm.h:1306 virt_to_head_page() warn: unsigned '_x' is never less than zero.
> 
> vim +/_x +621 mm/workingset.c
> 
>    617	
>    618	void workingset_update_node(struct xa_node *node)
>    619	{
>    620		struct address_space *mapping;
>  > 621		struct page *page = virt_to_page(node);

We're seeing several reports like this.  It looks like the RISC-V
virt_to_page() (actualy __pa) implementation needs some attention.



  reply	other threads:[~2025-02-18  4:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-15 19:56 kernel test robot
2025-02-18  4:21 ` Andrew Morton [this message]
2025-02-18  4:55   ` Alexandre Ghiti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250217202127.cf92afe2c0a89d5865e1811b@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeel.butt@linux.dev \
    --cc=tjmercier@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox