From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F03BC02198 for ; Tue, 18 Feb 2025 04:12:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E49D52800DE; Mon, 17 Feb 2025 23:12:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DFA122800DD; Mon, 17 Feb 2025 23:12:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC1502800DE; Mon, 17 Feb 2025 23:12:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AE0862800DD for ; Mon, 17 Feb 2025 23:12:46 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 45DBC12017D for ; Tue, 18 Feb 2025 04:12:46 +0000 (UTC) X-FDA: 83131744332.26.74ED0EB Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf13.hostedemail.com (Postfix) with ESMTP id 9EA8F20002 for ; Tue, 18 Feb 2025 04:12:44 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=IKYM2iG5; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739851964; a=rsa-sha256; cv=none; b=IKNmJSbJoTKCukALa9HxU62tdo+qdEQCrPkh1ucK75KUMsEaKJjy5QcTtJuhMVEzwHBDkt UQgs0DfauHZ/OuwN5xdA5KSk8SKh1TlJrvZ6adcCcnP15VmSaUqs9TBrn/oFqJqyOUBbp+ a0JdH/uAJ5v9V1vSKH53W6iasTWJ54g= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=IKYM2iG5; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739851964; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IJcCPz5n4oXUi4AOeXFoE8yVwMyu3AEwxnZzg7qlGiQ=; b=OgVlEMYQ9SL42/VKBBrMkYY5Q17GMTc6V9GAACerzkMEyXjkq9mMeTmC2ToMrJAxc5wHWT QgYqKdRDbemx+1z5AiYNlOnNBBtzvQJTVPXGk7LCVmKzatUkmgX7j/L6Qnhm/ZR8yDA+J8 EDDFBzwOtA3DkSzTVJ9386tNBGRgQQg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id A3A0DA41CF5; Tue, 18 Feb 2025 04:10:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2A2AC4CEED; Tue, 18 Feb 2025 04:12:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1739851963; bh=38jLuNaSVk5HK1+pU/7A9uz3NtGUBWLI+P5FDcwIGjs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IKYM2iG53ABjPYcjmuZLGGnEdggr4qTg4SHRnRDgi5WqVRCe9Ml8ufMn9icQVZ9oV pRrA/2wdw2WoD6FyFGDIjA9yhuUhkcByNayHQSgFkEU1wxW+ueedoEdoCB6NSvFFvr A9UzG3JQcqpg1UWwZfQ26qLzRkhfcP0fLV1E7GP0= Date: Mon, 17 Feb 2025 20:12:42 -0800 From: Andrew Morton To: Zi Yan Cc: linux-mm@kvack.org, "Kirill A . Shutemov" , David Hildenbrand , "Matthew Wilcox (Oracle)" , Ryan Roberts , Hugh Dickins , Yang Shi , Miaohe Lin , Kefeng Wang , Yu Zhao , John Hubbard , Baolin Wang , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 4/8] mm/huge_memory: add buddy allocator like (non-uniform) folio_split() Message-Id: <20250217201242.798583040111ddc019f68438@linux-foundation.org> In-Reply-To: References: <20250211155034.268962-1-ziy@nvidia.com> <20250211155034.268962-5-ziy@nvidia.com> <4483B46A-FEAF-46D9-AFF4-F0DF34864633@nvidia.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: u4p76admckx6qgabmproa6wpq6458uno X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9EA8F20002 X-Rspam-User: X-HE-Tag: 1739851964-809276 X-HE-Meta: U2FsdGVkX19Of59aLbOJw0keflgaQ6kslCvNaU8GO+uykQl5zYNJFRbWGewUuxyXSiuIprGl9mHd39QlVZfvWm5jkiXbPfnAuSDLWbjnQVSnojFPjPT7i8aiynmarr7RoMHuf6QPiZ32m1L3I6ulXgC/AKS4/3aK8Tpf6N0OpIaBOpTUShMQRrgVcSPMIupHmgqm+8mn8SOlMnPi3OBI/ZxVQM8IfClluUsZs1KWfpTHnEpvKQzC7no0gbcIx0T6dKL1a1Kwc2Yv4yhkwGz2A5i6zQ9+s2fGstmMDqr7+bknrJseEXCunYMit9F32SxbkneNX8NhgSp9LnS4ErJjbnvOuqEBUJ85qmJP4zzIb+ZoQe/Nk8s95DULaij4l3Mjrs5zoNgeo/NrfkUhyQsloJwZcv+kAqSS5eE0++1NW/ZLVEsRW8G8O92pyUvDT1iLBwlASGw8ahtYFjUudes33UE2crd1jb75NuG/DNJcRQKjrjkW2o3Za4KLRyOjGkRc50jWnV4zmcxsKqkNTq71xw/TVytbbFcfjxELhDi5cfTRM0046hGahOL81R4hzl17+aBY1RwtkjKgIhxDezIqqwm7X8V/RiHIFyCkNFa0VEkobCN0tf2FFJ+tJPbI7Hv90JNkE9KgHwJqIq3o3AqwCH7+Pxa1N+Pui2MJKkmSF7rQ6m3HoWZT3NEW/xeYZS9zqUPSIl4vUXgmCWzEpBAtsuDsu516wEAFuMbB2FLSqwbuh5HWyNAn5/f1XW8YUWfOzCrduk5GypxOnhwdx+Ogf/B2d5+uj1ayRWjsEdJy8BKuZ/bMgYZqAO0wPuqwNeSrazZWLMQdXyEES9KLHzaMQCLztiRrWVwZOVPXCCBlLOIAe/ZVVgakMcHUoN+s5MOyQTyXxEWwK3faDrGWmpP0IAHjVOMYvEtr3M85B/84NLBtyOIs0iD6gnUD5HDWJewESL73PbJ6pVNecetTq5d YbbSu3Hg EFKztTmj3FdDVoehs7XNSdueQ583T/bgw9Y5xdmhirPLIkWkPdkSibaCqixvGw0YHXaOy5D3B7CzOzbpNUaOcQ11qn74ko9WH8BiuBHRz5JpGrRdC8hEfHqyGyFIeyZWuUDzPhyC2agzAyPEj6ouJFja1qK+JzarfRWDnXFnIIhVStRNM75zyIPa8iW3/bjixxvsJpy13yZO4Yw65X5ikvKds4nwexVWrq48KthqGBEZUqD8n2dbqWO1VB2NJBYZVxZMygeqvoghxS55jmN/LUoUeyKuDuv1FU+ntdjELmLEgmd95TP/Edw0m+pBZ0iGeEbhU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 17 Feb 2025 10:22:44 -0500 Zi Yan wrote: > > > > Thanks. The patch below should fix it. > > > > I am going to send V8, since > > 1. there have been 4 fixes so far for V7, a new series would help people > > review; > > > > 2. based on the discussion with you in THP cabal meeting, to > > convert split_huge_page*() to use __folio_split(), the current > > __folio_split() interface becomes awkward. Two changes are needed: > > a) use in folio offset instead of struct page, since even in > > truncate_inode_partial_folio() I needed to convert in folio offset > > struct page to use my current interface; > > b) split_huge_page*()'s caller might hold the page lock at a non-head > > page, so an additional keep_lock_at_in_folio_offset is needed > > to indicate which after-split folio should be kept locked after > > split is done. > > > > Hi Andrew, > > I am planing to send V8 to collect all fixup patches I have so far plus > the one below and change folio_split() interface and some of the code. > What is your preferred method? > > 1. you can pick up the fixup below and I send a new set of patches to > change folio_split(); > > 2. I collect a new V8 with all fixup patches and folio_split() change. > > For 1, the commit history might be messy due to my new folio_split() > change. For 2, Minimize xa_node allocation during xarry split [1] > patchset depends on patch 1 of this series, which adds some extra work > for you to collect V8 (alternatively, I can send V8 without patch 1). We're only at -rc3, so I'll remove both series from mm.git. Please fully resend both series against mm-unstable?