From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CE4AC021A9 for ; Mon, 17 Feb 2025 15:07:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA81728006A; Mon, 17 Feb 2025 10:07:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D2FD328004D; Mon, 17 Feb 2025 10:07:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD05328006A; Mon, 17 Feb 2025 10:07:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9A5EE28004D for ; Mon, 17 Feb 2025 10:07:44 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0CBF7A0A7A for ; Mon, 17 Feb 2025 15:07:44 +0000 (UTC) X-FDA: 83129766048.12.E144419 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf19.hostedemail.com (Postfix) with ESMTP id 463601A000F for ; Mon, 17 Feb 2025 15:07:42 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=bTqp06vg; dkim=pass header.d=linutronix.de header.s=2020e header.b=VBeGTy0X; spf=pass (imf19.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739804862; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Knv1vu5PAfwQiS1RIXnJO+yB8gCyXMieOHUw7GMHhYI=; b=HdH523a2SZqdsRBdeb+lP+wAoR2frTo6OxId8Gr2er83sNWc1kztRSWP3QKXm6NkpfmNI+ 6ySVGCrviNU32gggb2oq6qT3rGdWC4bUcmVOXziW7FE7UAMFV2ZYq9eb3zJ141nIFPa/1W 6bkPZxsVUKGcOWU6GVetklvWZXtQZH0= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=bTqp06vg; dkim=pass header.d=linutronix.de header.s=2020e header.b=VBeGTy0X; spf=pass (imf19.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739804862; a=rsa-sha256; cv=none; b=A5VSR9Sn4+60KV9FrpHrEac4Sh4itZqLSVK81o719590g1j7qnSIZg1mWZcUN1Lv79EOKE Nr3eyw90yLNYpNCRjmZDJDd241863YJNaf1JLgdIm3yNyO7HJOdbEfW2oUXRRkdoa4nJn8 iO3iMhm5fQdVQsNk2NfxQHPA9PND+sk= Date: Mon, 17 Feb 2025 16:07:39 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1739804860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Knv1vu5PAfwQiS1RIXnJO+yB8gCyXMieOHUw7GMHhYI=; b=bTqp06vgOJhrCoOy/QMoKKBr0pfrH3J6lmAYhCoHggTSBY4k7jRQPoE4rhiuohKl3syYDk Y8ZrDo0fkNO03XBZmguRU0xeq2N2O3aP1CguVcPRz88ixLvV45wCoAUcAysqVxQSQYe9fQ uxqvOOlreVYP99lw60NSVksIooHY6A2hHAGj2miXDoLmsiZVERyKsyQPVavcn24lGvFTul fmIVhd1FpXlGNYsKSRQGrpef4e8nk8ru5ezKvymz3/AxgP5nGr/m4mQ7+GPM1qUc87C4c2 OVCpL26f0gg/fktZE/kifX4j9NTWN4xM8GdFDDSTaKJaFdKBphQoExRxoicZ7A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1739804860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Knv1vu5PAfwQiS1RIXnJO+yB8gCyXMieOHUw7GMHhYI=; b=VBeGTy0XeqG45/4i3+DGubyOCuOPvbHpxGcVSn9zmbCKNCwgsHnz/pulSpR2ySjmZojqs9 X3urzTzC73tygEDQ== From: Sebastian Andrzej Siewior To: Vlastimil Babka Cc: Suren Baghdasaryan , "Liam R. Howlett" , Christoph Lameter , David Rientjes , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Uladzislau Rezki , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, maple-tree@lists.infradead.org, Alexei Starovoitov Subject: Re: [PATCH RFC v2 03/10] locking/local_lock: Introduce localtry_lock_t Message-ID: <20250217150739.JyUlaKxI@linutronix.de> References: <20250214-slub-percpu-caches-v2-0-88592ee0966a@suse.cz> <20250214-slub-percpu-caches-v2-3-88592ee0966a@suse.cz> <20250217141956._01BcsrG@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: 9padutnxee1otpbtzg89mi9akkprkatm X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 463601A000F X-HE-Tag: 1739804862-151369 X-HE-Meta: U2FsdGVkX18aVenTHkpG2HpE+B2EzV3v4ZJBMMPTfWnwZMTNXsGFSDP1nORroID5YR6msv7y7ptE73bR3J7ZzWbVWASjWygEdYbrkfipnaSqy8tOoVxsw3WhtKb6StPGxgPIBkt1spmdtsQQqjQ5+zCjsZHBPLQ/NImMTkU1G0AGkU1l6frp7o+ipkYHXEstDQpmuKKcKTbiRfcKAKzzc/H9dgnmTnuN/9ReaplhzTInx2dRKU3UXgjjgpBIZ7y64wDMBhdYf88+mCQsepmA/EgMJz5xPao0Q3wYFIsek71grq06P1q8N9sqlV1BllJ1DD07DVOm1grypdDrnfCPvZIKuuhvSZB+/a8eUBIHE0nfSoow8nugj/OQV3CUaaeDW52qEOYhhOal8IezN8Td9j7h9iHer7W2F7VErcZVvdpLs9mG/wYS1rySzTkGf4rSRoih5ohDdUX7XOzc0T3baSirF7cP+CkSeuKe9XpDDKbXN/vpCuzUtk/Rvnukzt33VGX4Z2eCy/HjNX2wv5rOJmNwFPJxk3pX4dHGEuCIGSyMwclGnPJBrIbQ1PythHeWCtDUiZCpJzhxHjSEm3vrj8pfJfQsmvODYtds8PtNLsPDxFN63XY2ND/2TrzVYZTgziFTh1B6xluhHiHHT5mtMi7s1D0bTCDyzqyt+KCJY324D0GInoM4n47PCmCp1dlwNgeh7Celi8CxWUYUzAoPFzgZzeJpObeYKJMzdPwgEZW0ncF9hyOCO3c/oxgsLMgSWXUuccHmPqrgOfKy7Pk0bMRNk+A7d50tIy44BWxYdldnVzL2eYUuya+24Xf4yIiQeEDAsT37XxwM+vMfSc7aYc05HnwX0lSJf/KUgaGL7qp3GRtaAeUMZRoGN46ACHUg3/ryvh02Z9neWuC+gH1FP90OiT4Fx665yS+K4ONvxMPpl87D7vAF4UbP664LZeUOm8IfpbmBhuoioUBoFxB j9TbjibX UYI343H62pBw7j//FbjyKxlEG3IOEJaVi8jkcAYiQ0Vo04x/mp7/xpAX5kTinXqXbcT56t9NyeFssDKFS3DotOgjXY+tvWunUenlpJMCesoCqOcMooD4sYwuRGNPngb9Dc1SZWAzEBPTWYzyws9ykai0bD4Fx5GEYQ32SPo+VOU3wMS9N8cSQKMw9EKdsVu6knyMF/JAU2gpufUqLFi1deacGuxpf3x/CM8uK+zHCfMzZgj+8Xf7/qT6ALJv/k21VhbV0U0JTJrlWl8mQkocoXBVPQwog+DJFVxcq/w2w7Mkr+E0D4jMmUDjJr1M9BMGDE96I5Idfa4Yj7D4DzxsgFvMsFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025-02-17 15:35:11 [+0100], Vlastimil Babka wrote: > > spin_trylock() is not safe due to explicit locking in the underneath > > rt_spin_trylock() implementation. Removing this explicit locking and > > attempting only "trylock" is undesired due to PI implications. > > Just to be sure, you're suggesting how to reword that sentence in the > changelog to make it more precise right? Yes, just a reword. Everything else is fine by me. It just feels odd ack my own patch. > Alexei will you incorporate that in your version? > > >> Note there is no need to use local_inc for acquired variable, > >> since it's a percpu variable with strict nesting scopes. > >> > >> Signed-off-by: Sebastian Andrzej Siewior > >> Signed-off-by: Alexei Starovoitov > >> Signed-off-by: Vlastimil Babka > > > > Other than that, thank you two ;) > > Thank you too :) > > Do you agree with my fixups and addition here? > https://lore.kernel.org/all/efc30cf9-8351-4889-8245-cc4a6893ebf4@suse.cz/ Yes, looks good. Sebastian