From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28476C021A9 for ; Mon, 17 Feb 2025 21:56:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9ECCB2800AB; Mon, 17 Feb 2025 16:56:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 975C32800A6; Mon, 17 Feb 2025 16:56:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EF672800AB; Mon, 17 Feb 2025 16:56:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 60C4F2800A6 for ; Mon, 17 Feb 2025 16:56:16 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D0313140EB2 for ; Mon, 17 Feb 2025 21:56:15 +0000 (UTC) X-FDA: 83130795510.18.5C2548C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 7EC69180009 for ; Mon, 17 Feb 2025 21:56:13 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AlFCj2nd; spf=pass (imf06.hostedemail.com: domain of alex.williamson@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=alex.williamson@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739829373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ma+WDCstUob+rO5FJpLhVsCO991W7dWOQMuhns1ORLM=; b=fcgYZOx7dMprGCpRXFCzDn1Xn5Rz56zUwov+mzDvBx3ob/IFrEffPUu27/sFz17Z7L0Wea hwDp3mKXCH7sE0la73jrl9FTZ56Bv59+gjMWVCVoe8ZtHe4XIbAKmfeSbRBivfGc+v4u0Y IyWGzEzfFrdL54PPq8dvQu7YSuy1pBU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AlFCj2nd; spf=pass (imf06.hostedemail.com: domain of alex.williamson@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=alex.williamson@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739829373; a=rsa-sha256; cv=none; b=0HtZKzIHeOXGOupbBEYcVNqr46kRXqRQG5m6A8wG7bByd7gBP2aNLPytPns2O8h4qnZ0lC BfOuPkiek1RU+Gp867CxkTTq7ofdFnacmlkSyUZr6ftNdk22pomEc3F2xPkYqXpvwNnl72 kLdAKJVDmqOnI0w6lgPKjBVIccbgaQo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739829372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ma+WDCstUob+rO5FJpLhVsCO991W7dWOQMuhns1ORLM=; b=AlFCj2ndIb0pTfQJ5EPb+Y+wRGTgI+e/BtMqDna06SQ0CEAy6onzYGLwNWOtAUiqmd9+Cc 6HRRGiaNRzB0k5/lRJzq8J8W+Yh1sQ53YlqAFhukFm87MOKyTNRHrfN+CAx7AxjnZ8MJHN kkCRWz54LxYmfYgQZLUSyt2/CSL1Lp4= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-gZW2kHcZOhGTfr9yfOlyLQ-1; Mon, 17 Feb 2025 16:56:11 -0500 X-MC-Unique: gZW2kHcZOhGTfr9yfOlyLQ-1 X-Mimecast-MFC-AGG-ID: gZW2kHcZOhGTfr9yfOlyLQ_1739829371 Received: by mail-il1-f198.google.com with SMTP id e9e14a558f8ab-3d18f59b9d0so3750735ab.2 for ; Mon, 17 Feb 2025 13:56:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739829370; x=1740434170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ma+WDCstUob+rO5FJpLhVsCO991W7dWOQMuhns1ORLM=; b=YPRpCIJc0Zpb4Makz57F1Cw/HByuGGJGNcrhtQwn38WfjqvBxdkd8vWe82L1titJoh ulJQwUFJvNE6oFgfbv+OW0OdSp/9P7uxtKSSkd84L5VtQRfd4CRRO/mpO4GTCQ1naYzq zggn2LMeVKv1HVvl/K1h8UUYfEygckcL/KqE5uzgi7erx16vmtU6rfYmw9yr0DMcKyzz 00BtGJ/mY7Z7H/bRhFIdgpZvp9lmJ7bmtussc5e+H19pV5ThzoyKmhgILMgCH0suk2HU nKkZUEeoJye3n7r9sINomQk4q96Ij04fsS4tsglmfSUezBrcV94RSXJQ94n+gItLaWzL hhkw== X-Forwarded-Encrypted: i=1; AJvYcCW2wIgZFbmSoo2SiP4ykyIw/xbozwBcHufHmid9Y9BoHedg+1ZkcP94L8MylxUz+KCiwlkOTQ+DKw==@kvack.org X-Gm-Message-State: AOJu0YwgdN73Y7n4Q1LrdrXaDXU8UzCHv05ieuncIKOHM9AAjGr6IoW8 +W5wgiuC8GSv0JPao3k+v5HeuyF1lFv6VpLv9KKfJFvwZFmZC2n4JQ5uVUSVK0QtDnp5SKIKqYo LuNxkhq2NBQHDeYk7X5qgcbkKwKtLGWjzFlKsSOYJ7flGszpbrcsENIER X-Gm-Gg: ASbGncsk5S6XM5SYwDdyt5TlgGgXwTCrtPkTkH4HeYcjf6AYYSUeW4CyJl0kKD24RMA qXgwJBPZa53lAt7bCrACVljSRHkjKdnsxAdxuiT1HNQYCN85/4p50fWgl/uw+n6DNebJYxDHMlm cTmMRt3kzvNd8e3kC+Cf1bUc37CqqadRrOHP3giRqcgLyR8+gYAaT5D0Y79Te2Ja1+Velz3wZC8 DrGBhasKlFMsSWzHYNMyc8KiuS9fO1j8oChjDOvit+wmrbtsLOZZfj6I06yOo+rn5P1hOhYZurY I+MbUA/8 X-Received: by 2002:a05:6602:13d4:b0:855:683d:d468 with SMTP id ca18e2360f4ac-85579fe5006mr245136839f.0.1739829369722; Mon, 17 Feb 2025 13:56:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IGnC63RTWm/9A8auCeEObZ+CHD/OXQEjDxR7vyZ9cE6BFwEm2a2tfvMMhgn6LJkud3CRBJDvw== X-Received: by 2002:a05:6602:13d4:b0:855:683d:d468 with SMTP id ca18e2360f4ac-85579fe5006mr245135939f.0.1739829369431; Mon, 17 Feb 2025 13:56:09 -0800 (PST) Received: from redhat.com ([38.15.36.11]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ee82c8d5b0sm1436012173.120.2025.02.17.13.56.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 13:56:08 -0800 (PST) Date: Mon, 17 Feb 2025 14:56:06 -0700 From: Alex Williamson To: David Hildenbrand Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, peterx@redhat.com, mitchell.augustin@canonical.com, clg@redhat.com, akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH 4/5] mm: Provide page mask in struct follow_pfnmap_args Message-ID: <20250217145606.22b95d9b.alex.williamson@redhat.com> In-Reply-To: References: <20250205231728.2527186-1-alex.williamson@redhat.com> <20250205231728.2527186-5-alex.williamson@redhat.com> <20250214101735.4b180123.alex.williamson@redhat.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: g4neMsKq-mjrRqgWMQhodMMtJV4IUUNNX3d3x5vqWmI_1739829371 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: kuxfh56x4rjrc73gusanutjnac7r8d1m X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7EC69180009 X-HE-Tag: 1739829373-450859 X-HE-Meta: U2FsdGVkX1+9tSJme5UxkAjGK9kOVwM/YeY5Ib7LFeXvO4NQOXQFER9atTbfGFEojNnVSmhQJPUre2lCrB1jafY/WkEZ9lzK4m3TLL9e3BSwIurkApqB2mJ5gzl0PRhZBeTnDvzZtMAVZ3Scf/jjbEQ8aw/lpg2PiWiauPjLTcXAF8XNHhz8XRGHSfMJ4rchkPF5bYbkpCaVZ1QjpITGCfbPAC7cwml7wgpnARg9LmGJxyxyMdAn1aEI2Whjn+72JgTFsan8ad6AWJoVSmg+KAa8EOSsXM09B6mGjno90XcpRADn2cWtuApYMV06UYHbqF6+ftuFZ52CckxSZksA01rNgy+MixVm+t1TgEnKxt4Oz8ghO+UGegfe3lgIniiwNTy8ykJsdFlJdGwVZyv1TPjKwd2d7bU0J6aLC1ipvDIR3qGP5H41ofsZ6sQlv82jT9nhSafQieei7XU7+l5zqL0sw34GTKEVmtLJp3H5K2e2wC2LMXaJIvE19CCn7gXOfLuFV+9TW8ijEqXUzocRpdtvO9THvbOUyucpz86wij6Z/pR1pJg6+Asrg5rQb2E3IdfPGyhtqSxlAPk34qG3iB6fQf4BUIP/L0AejwmjtYbR3hd4yv09k6DcSpj2GF8eF74Yl9kmv/X5JtLq9IE7vwFHSR5iyoIxTldDa//yts9aUMUmdF6TXBDbffyBuiJr4E8jvSgGtXQ/v/j/g9SGS7nu3w4RgnioF0uCUPK31izGvFNldGSMzvRhs4gWlJLBxJMYUm7py+gTzOIfkAGKLOCyW561RCOigGAHaGUbAg5UCKMagnIgZlF6CnNntmpTKI8xVk2VzvD+CubkmRUW3bVzGNoulSPYFYcRVXdsXYLcy0G0izv1arV8EAjTLqiL7MWGZA16L+J4S1+WwfZQJsK7xhGYhNMebep5mQQBWNZ1CBMDymssd7sd1AGYzemrozA60doe8NwtUx80Kj8 g2S9Ifuo a8j0vXirObbqYb33qFKCta3Y8ztCD7QxBuR4SqoC8VQedotGTXbFNXVDiDCw2DcPwWlXpB3Y5ZY9vexlnuaHdTkoFpKOXOkhKeUAQ2q4z/IKgvMLQJMxx+fUJsdJ7WSzpXiEe4AYmPHZ0Sucp6VOLqPVtGWcbLMvGA6i17YbMaeRmYYgEU/W8Fx1ImjWbN8R3GEC8f0p2Za1X8iSliDYj/zJvqqFKhHjjqlI76cBNTclho+HsToaSWVtp6UBqMKFe2fXG8qFmiOm9iDIJAup32tWind6f25PO8VnkjwbwzGXaJrBpU5rddpSGqWb9PpdnUmka/rHd+h9sagzDi0dGKfAxjF41kHcO8v0Qs5q7BDzOjA6WpHWljsxt9S3TyhcJks7sPrMOGrHfGfAuIRPPjY4Wv76/7+tikXDa X-Bogosity: Ham, tests=bogofilter, spamicity=0.091194, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 14 Feb 2025 22:39:30 +0100 David Hildenbrand wrote: > On 14.02.25 18:17, Alex Williamson wrote: > > > > Nudge. Peter Xu provided an R-b for the series. Would any other mm > > folks like to chime in here to provide objection or approval for this > > change and merging it through the vfio tree? Series[1]. Thanks! > > > > Only skimmed over it, nothing jumped at me except ... > > Nitpicking: > > I was wondering if "page mask" really the right term here. I know that > we use it in some context (gup, hugetlb, zeropage) to express "mask this > off and you get the start of the aligned huge page". > > For something that walks PFNMAPs (page frames without any real "huge > page" logical metadata etc. grouping) it was uintuitive for me at first. > > addr_mask or pfn_mask (shifted addr_mask) would have been clearer for me. > > No strong opinion, just what came to mind while reading this ... It's called addr_mask in pfnmap_args_setup() so I'm happy to keep that naming if pgmask is less intuitive. Thanks, Alex