From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09355C02198 for ; Fri, 14 Feb 2025 19:40:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B39B280002; Fri, 14 Feb 2025 14:40:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 763CD280001; Fri, 14 Feb 2025 14:40:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 651C3280002; Fri, 14 Feb 2025 14:40:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4877A280001 for ; Fri, 14 Feb 2025 14:40:31 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B47E14A4D3 for ; Fri, 14 Feb 2025 19:40:30 +0000 (UTC) X-FDA: 83119567020.15.05BEBF8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id 0337840009 for ; Fri, 14 Feb 2025 19:40:26 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DqzfktW1; spf=none (imf01.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739562029; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eqiE9L7mCaip0lLhGTwvwdcmTFtEKa29N3mX3PLMV+c=; b=2FGK3wR1ijd+rLW+YUVm7EitYWrrUNtXwY4jdeUtQZFfbcSFJGxjVaZImvqp6QcmtbqpgG G4xWnTRzd644lWiFrC3q1uafG8y7obo58QhdrC8gYPZvtMHQlTlf925laKnJM0eI9LbwVo 8VcY45cEpmzkqr00DSccWKs0FJzAG4I= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DqzfktW1; spf=none (imf01.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739562029; a=rsa-sha256; cv=none; b=pbSU6EQR3TqnSxXtC94nb+V6BBrs7if0WyPyYoYRhOke+1j4u6fXzcJ/JGOEk0UufDurM1 yUSOF+rPbCTFeGdxyCFGdjr/XeWZBijR569G/ym0crezBvx4DK8muv3+bRIN21PWwQU7z3 ip3RC/0BkeSkUc5Bd9NFRaK4HWb1JiI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=eqiE9L7mCaip0lLhGTwvwdcmTFtEKa29N3mX3PLMV+c=; b=DqzfktW1MqBRQ28nEtrzP5lMHk P4TJIxLOiuSNWGSmyFsJr7oJIMHCtUHHtm49no8wgpKxIbXTtqYpLjcXJQMhu7vKnqXyeRZv3VA4/ o/QLMAjWxrhLLs7RTtOWbVhBxY7V8oR9QGQqLkNizBO9t0l44ZW5L9FgObrp83aIg3e+m6LQ6HVi/ 1bRPEFr49h9uZ/uFu4hJ3dJrdoZh4lBU+ftGY5/89QjHPndV/saRAimh5BVo84KOwVDiE1SWqcGRR Nqt1Fa0xi7k8uA/Um+yJiWZEG6waOK6WrulmU4/7EmBT6bq4ZuSx7nG2I1aZORtO8WLKte7lc1/0j Zypcd8Xw==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tj1Xq-0000000Bxl1-3LJf; Fri, 14 Feb 2025 19:40:14 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id D70763002F0; Fri, 14 Feb 2025 20:40:13 +0100 (CET) Date: Fri, 14 Feb 2025 20:40:13 +0100 From: Peter Zijlstra To: Dave Hansen Cc: Rik van Riel , x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla Subject: Re: [PATCH v11 06/12] x86/mm: use INVLPGB for kernel TLB flushes Message-ID: <20250214194013.GA2198@noisy.programming.kicks-ass.net> References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-7-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0337840009 X-Stat-Signature: fg1ranxwpcfjprqj717tjkdsgrbpenhw X-Rspam-User: X-HE-Tag: 1739562026-490858 X-HE-Meta: U2FsdGVkX180GZtyRQfDXBPxF+97Acm9wPBRpH/SRQ9aajvZ++lJkRFafITfyixvQEtukZH3UxVp5SlUSEi/nqdOuvA/lB4vZtH3s2UaMzUs09RIscbgTqu0Qrolppi6m3Ij6lkd+8cUeqQED6qLPExcUTYWFEe51403/iF/uOJWbD/inWz+iv3muu4EmSzJ2tZDcu/bIwriJCj3I3N/Q7CWxdLwKqRAUdEDDa0Q1rDGpcP8P2pM1Qf2OvWL/Pkd65pKEGgEY1XStNe7dD6BUY/qW3/qfGUy/zFf3I4nv7dopicIHuSrA56iBKVjaRGOugRdExkdvCkNkMJHL0nExtSediBs0wtMtAz7oeL2tQxMDFLvO6fesFHgEepxZyl1zcZBvg9y4hOXeByW+D0GBFOyQyp2RM2tgo3UTiWP3JtxMMMnH1Vc15N8Ar4w12vRgsjSLxbAQ46WXuCZcb9MMRnrw4SijNUUYhY9GzWgjK6neeg7tw/ofkxk53lJWUbn2P+vUgj/ElwjMxGgmvM7ARjCvT/+KkvO9lFvoIKJSxyxAaeicDaGijex4i4JYD+4rQWClLAA/idHJMGR4umEqXIqGDZ9fIqsfZ6GfhrguXKrEb2ILGeL6I1mT7Fj25IToMqppyNvFU9m+GBKKieOxvV3F5s0LOZGb8TmBWGNfeVpc7UYjp9LGTBqENAKuEBNDwpH8M9ZVEB8aqvbiJBDMwwlse8O0nQEZqg0694Um3cqLw44dOdS3WtXaMPf2u5b+CYp/tATpGxOhfMstg4dISg8a6yrBb8cI60iZTkkD4BPjb5O285ydhHabALVsqvjEy/dpPMKMeJhYa+M0owA7KGcEmSF2THCM5OBDDvUgTFKo99U5jl3jlBY2L1grsZi4zPDLQEjzi/H4xOWToQHtaQLyJGG7FBvR/MYBhYvC1VHvCwBGNZm/J7kNOEBr6MMBqG5kebVlNCuKEsFcoR tqwP4Hwn 9bwRJkIW+wBEybc5demVm6kBbwzoVnBVSxX9AUrHtCWypmjf5HGJ95OxvN483TVR0+kp+gHs+EU8edrxLwdyeMj62F8Q/PmnNLrQCMqwmPxDBMMFuMK2fu9A+abZWedpNk0T5Y9+2pRL7N5+9X8xZDIknIN003Qqn2Ycg67Ep8TbCi/TecN8bROG6uPNJisTGAspF/md5UD0ny8H2zlkcCVcjjs/6yoKDdZD6QTuPE5HKhSKKF98hldp0iOvCs/MbWDoUaLjlf76VBdw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 14, 2025 at 10:35:40AM -0800, Dave Hansen wrote: > On 2/13/25 08:13, Rik van Riel wrote: > > - if (info->end == TLB_FLUSH_ALL) > > + if (broadcast_kernel_range_flush(info)) > > + ; /* Fall through. */ > > + else if (info->end == TLB_FLUSH_ALL) > > on_each_cpu(do_flush_tlb_all, NULL, 1); > > else > > on_each_cpu(do_kernel_range_flush, info, 1); > > We've got to find a better name for broadcast_kernel_range_flush(). > Because IPIs are broadcast too. The naming makes it confusing. Why would > be broadcast, and then start trying IPIs that are also broadcast? IIRC the more general name is indeed broadcast tlbi; as in other architectures use this naming to mean this very thing too. But yes, I see the confusion, but I don't think changing the naming really helps a lot here :-/