From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5670FC021A4 for ; Fri, 14 Feb 2025 22:57:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2F0E6B0092; Fri, 14 Feb 2025 17:57:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DDE9F6B0093; Fri, 14 Feb 2025 17:57:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCDA96B0095; Fri, 14 Feb 2025 17:57:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B01526B0092 for ; Fri, 14 Feb 2025 17:57:29 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6A8FFB15AB for ; Fri, 14 Feb 2025 22:57:29 +0000 (UTC) X-FDA: 83120063418.05.B373DD4 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf26.hostedemail.com (Postfix) with ESMTP id 98A60140007 for ; Fri, 14 Feb 2025 22:57:27 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wNHWK90R; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739573847; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LYjBi4GNj1m0W3H5KpmOrvFvHj9mqXSxrCMKRBbm9Ag=; b=SAYYqAFSBHuSkKeqJ8s5P+4gDzamZd+tHWUxIuemxlwtzvEtgAiek3kJ84rnh/wsuDbk54 S+r9THxgnpA/PI6fwKPCJCrtrscYuNLzlE3AXW7YzktZbxqjx2Yuw6UsfNq+IME0tr3KH8 fqWv25ss+5xZhlW758Y+5J+E73Ow8hI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wNHWK90R; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739573847; a=rsa-sha256; cv=none; b=QmLgsYNg/xXi9HI3ySYFjOW8ymPBSefZj8bGqIScpUsr6CvDHRxg+2PbFHIs6NXpytg4qm 8DUrgdhmmMi8YHfuCxgip2p1Z/kS17GkWxrgSVasgelKLaZJjgyEJxgSgT8QMIHQMYuC0v b52QSkxXqrlZUKIyebn0M+ULoRmv6Ug= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id A4ADAA401C2; Fri, 14 Feb 2025 22:55:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E28BC4CED1; Fri, 14 Feb 2025 22:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1739573846; bh=0ILSp5JT+D3osiI60Lg0GB/KV/EA1edHu3s5ntXgN/c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=wNHWK90RZpaxhGt8dP93XV8XngPtWsFj6FWC265k5HT1xgomPYgwr8CICUUYMM5Bc tGYtP4dBw19SdCryiRPKSTgOBiPPXOlE7Phu/LzqFFA7mLjcwbdy3hwJHh6ukOgnWv JYio4GsXMulZUREsYxBxk6conNt+jT18wTPKXcyE= Date: Fri, 14 Feb 2025 14:57:25 -0800 From: Andrew Morton To: Gavin Shan Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@redhat.com, osalvador@suse.de, gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org Subject: Re: [PATCH 1/2] drivers/base/memory: Simplify add_boot_memory_block() Message-Id: <20250214145725.708746506f5937acc96783be@linux-foundation.org> In-Reply-To: <20250214063504.617906-2-gshan@redhat.com> References: <20250214063504.617906-1-gshan@redhat.com> <20250214063504.617906-2-gshan@redhat.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 98A60140007 X-Stat-Signature: 1mmipr9nr3z1pa88qeurs9b578f51thf X-HE-Tag: 1739573847-514332 X-HE-Meta: U2FsdGVkX18jbtPj+Yg+BO4cE0VfBdUD20ul/iyqRck1sMA8V7qbuCQFsOg/WJifOnABH/jKNzjsORlfsKKOW3Q/9VOH0hv79wgctk9esdvF3wVJ2M3GMufCN0n+JFtcz1w+Gki3+O2DKj88z+g5PdYVPScWWB+1bXyHkzeABFotaUIyc4txd/YSpFh7wlv2+SX4dOgSkbXuGpl8QjOLv8C+pp+OnZZwfJeLmqgqkTThhKRoRgtOStNb92Ugjx3Vst4TPWsAjhHmJVJ8vavj/0eXAt4OGn+RVNVCMKwmZC0fLigT6alxJh0C+dAMD7T9+sS4SsYNwcoMrNhuvBlkxJzvkyLNM/ksrqjugYTwHFKdoOHrovpcuvCANiRjwmze+AGbStUykqThkYRyxoZ6BQ14PzlIHFclfAIzB4LONnHGMhs1jekUbVrwjQZXWMqzKOnoBEtSbcnzawINHh2LivXbC1ZbxaaFO0HQZSH//VqHk43ZT9Aj7kHsc0+LX8mVdbgv1M3q8lTRz4q49mIrzXIMrtUMzBmEC5Woewzry3GNoO7z4OqZPc7KKw3DMAeBqTAK/KnQuyzGeaeBREp9Qx/dbsrZ2OMPiXged8BRbOsgRzYyJnwnM/AtlpHaqsLlrmSCKwCrrGr/WYO/j5otmUv8NZU4Ml93mlf045/s8Lz59Etg1HGv3tljhKvHURW2wdeBtmTEwbL+wrtbgOKYzeyTe2/ymj42z+nHXnBMARJlZDOLx24EiZ6xJxOfxJcIRpCQRZL183WLpm89uffhY04n4XAR0nBw+aj1JEiB6S9muUpXFTE2HounPrIM+O7p8koih5QY/bY4kQ+MfPaZThFyrB1zLDIRWqeV/oGkTKehFlhvqmMWkD2+2dr9ziPLZjCxUoOCjPx9ctIxOZO+wh6PfyyIHaffaxrp3poqt5ULOShlYEmEAjA1tFfEYySNKobym/AjeUc1nXjRk2E 5nX2tDsb 26WYWFeyaPfH/cLrRzinVKijQob0owN4B6MX1X3XrAerD2SrCZ1I5pIhMinbGl1StrPbtgvswsJzffMh6pbgBM2+aQFa5NNAGwWz01KwT0e14V5WcTtjlzqY5Dl03jk2lYd9pggWIOpr64pfQsCTQzzUlekOR41ahsigO1lAgHY+VxcgPs57/zFoFzqq51ykqiUC95eQ6IPXloXkbGW5myNwYzFIMx+zKPKfwdwhR/MgIru9zx8PatYGYFBSXihVBewDtk34y87nbdy3uyRQhp/LWkMglDGyz7apNSVbz0zaoMKhpFbU8c+SzdJYpiC7UaO6nxIJs5iA3u4BaVPbue9T3crZD5rrnmFu2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 14 Feb 2025 16:35:03 +1000 Gavin Shan wrote: > It's unnecessary to keep the variable @section_count in the function > because the device for the specific memory block will be added if > any of its memory section is present. The variable @section_count > records the number of present memory sections in the specific memory > block, which isn't needed. > > Simplify the function by dropping the variable @section_count. No > functional change intended. > > ... > > static int __init add_boot_memory_block(unsigned long base_section_nr) > { > - int section_count = 0; > unsigned long nr; > > for (nr = base_section_nr; nr < base_section_nr + sections_per_block; mm/sparse.c has a for_each_present_section_nr() - is that usable here? > - nr++) > - if (present_section_nr(nr)) > - section_count++; > + nr++) { > + if (present_section_nr(nr)) { > + return add_memory_block(memory_block_id(base_section_nr), > + MEM_ONLINE, NULL, NULL); > + } > + } > > ... >