From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DB80C02198 for ; Wed, 12 Feb 2025 23:34:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 406176B0082; Wed, 12 Feb 2025 18:34:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 38F6C6B0083; Wed, 12 Feb 2025 18:34:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2093C6B0085; Wed, 12 Feb 2025 18:34:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 01E3C6B0082 for ; Wed, 12 Feb 2025 18:34:44 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6B0411411B4 for ; Wed, 12 Feb 2025 23:34:44 +0000 (UTC) X-FDA: 83112899688.15.15F70A7 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf20.hostedemail.com (Postfix) with ESMTP id 653E91C000F for ; Wed, 12 Feb 2025 23:34:42 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fwqSy5Np; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739403282; a=rsa-sha256; cv=none; b=yscsx+fiO2G9znPcLtwd62a9uv2A5STbN1LhyrJ8xhW0Wj/sYd13f/qpEAtpe7T//1VvRr DjVdbeo/SYghyLhRwkJ4nl19vQ+SN0c/AWgZj67YK5gvmbcC+aGnW+9LzVlFWln0tcTOj1 OhhN+yrCnDfoPgthgcOwRuuu9hXvYCs= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fwqSy5Np; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739403282; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e7Efbn25JpvpyX99zg1ZAWMy94PoTPkP0/fI/dBi8tg=; b=qITYk/fYDtPIeqsQZLYt4fRSts5aJuKhpQAkkuUxHYhEvVhh26m72qsGJpI0INqzH3zKu4 y5Cglttt261TcmnG/7OIjaZ9nYvSoNIM/CZuCruoG/wmeuYw0Y7r22Yccg93CPyb+WhZ5z Vz02fz9XMxJeYLGgol6gmJnZq2S/Jlc= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-aaec61d0f65so74969766b.1 for ; Wed, 12 Feb 2025 15:34:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739403281; x=1740008081; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=e7Efbn25JpvpyX99zg1ZAWMy94PoTPkP0/fI/dBi8tg=; b=fwqSy5Np/9Nk7rpsNMp6Q0rxzt/Hpi79KHEAiprDnUUprwrJqtpHo2YZ4L6VuhxQ0G ms21dWv4iY8dBY+odzzx26+G9f9knxGIGhSgcUYpVqzQ9Gbrfji4zgssoFYTfwSuYuPn KM43pC7iSe5YijBjxRzOn6P0yyz9J/8zP6ufxlsiFD2Mmp7LTI3x9tpYYvvp6iYTT0Vk ZnPOMUxZfyXKy/ZBzqFgWYNZCzk7jprjACPs5vxSDQ1PFC151xVLmCe4mLdwe0AgfGxY 2tSbYUiWIy675hFkJ7CaJfqBvi9GghX2Fp9V0ALvqqCvDFjOMqmJaEavEdXquda9thgI Hn3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739403281; x=1740008081; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=e7Efbn25JpvpyX99zg1ZAWMy94PoTPkP0/fI/dBi8tg=; b=OeeP86sEK+X+alIgXNMFZ1PuL8GRSb8cs18ndzVWS4mjWk4tNHws5u09igX5b4Hcfz L1Ko//IVhgkCkahULl3gjxSf2ugTVXCXrXW5mgrDvq3Z1e7rz7P3+OC+PlHBDmrxAg/j jmRFTVlesULxpz9oFnpizkRo6XZCxVj8hEBzBHMA954RLd8CSRAn9TpyMjoZ+pdlNgXk ejY73iioj+TAkpkjfPBXerguav0W+eYltPwKkY4OSYY6FseJuk967LPPa2C6GKDz7Mm1 mvz0H5ooJuErgZZIonNnfnca4LGkt+TzxeO9h9fH3I79wSpciMx7frdAn2dHpUEwnmcw jQ9Q== X-Forwarded-Encrypted: i=1; AJvYcCXscap7rkf0BiK4K3noPM9E/lJqUbW7hWJyPpPRcS/nDaH1NNTWr2sAYZ6YE5j14XpaniiYoE9n/A==@kvack.org X-Gm-Message-State: AOJu0YyxUhbrT74FRX7MMngLDnlelfAVF/1UappLodf8uxcY+1nGUhPz 4x1xS7iT13M3vdZlba2hiXm6heLLF8Kp8RCBZilAmq5QedE3d6wK X-Gm-Gg: ASbGnctAX6E6VjpjgN9d5idxoSU/UXFWYpolOL1IO/+Jpc9APpcwVOsOP50UDKcesvS neT0VNM78LTyCaxIb7HXnzupRNNbqLmqFj8s7sh52l3PtjNvQRhxefNKKsoBvVFJzhSVLIYoW2v gTTYAuDBTJAAD+3/SZARrsMRoNKtjvoAyr79Kgdf1+MreuA+wryXO1dxsmzwfUwPGOJFgQ+4Ae5 g/odvcGt90GFffoKjtWyIb9zhvLrPwwX/2DLieX9AddickMwomGV3mxhlet4P9Gr544C+ZyA+Gq bz77KhnFO1c2Wpo= X-Google-Smtp-Source: AGHT+IFEVk9QIBEtqK7jsJunnk+mvmZu3WWYIIQv9DXIIkE6fZ8DEZMSd/5veIscnS5u8ExTss/NEQ== X-Received: by 2002:a17:906:6a10:b0:ab7:e71:adb5 with SMTP id a640c23a62f3a-aba5017ed2emr99355166b.35.1739403280560; Wed, 12 Feb 2025 15:34:40 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aba5337698asm12904866b.120.2025.02.12.15.34.38 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Feb 2025 15:34:39 -0800 (PST) Date: Wed, 12 Feb 2025 23:34:38 +0000 From: Wei Yang To: Dev Jain Cc: Wei Yang , rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/mm_init.c: only align start of ZONE_MOVALBE on nodes with memory Message-ID: <20250212233438.lmnsel5m4dwy35xa@master> Reply-To: Wei Yang References: <20250211082900.10877-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 653E91C000F X-Stat-Signature: kr5h1bxn6wmn5pamy6otyjb614mt5a7c X-Rspam-User: X-HE-Tag: 1739403282-304253 X-HE-Meta: U2FsdGVkX1+FoIF1iy7OnTIqh8TyhcxxiHQTH6o25ljJ3C1nZ7dfs7g4LvMN49misg0B9MBTKTxcviVl6H2ouglk6noGigpHUTmV8E+bD39eCtH3gOZ1IWQGDh2aGon3l/bcjraSlTmEaU4zilF64Eryoe/ARF4WG4crB7i+WmcLVwMIFQBv1SOksiTl9qdjwXRLPYBRzKvv5el4tIVNK98M0+Hl6gvQGbnKZIY0c2mLaOxjQsVW4N9XYRNpxyWvP+xIFwUZ551RRKwSYJpejifGllwQ2W56arcXCRE50pELgB9SI89K8Pe8FZZy8Dd7v7gZ6mawcqS0ZTz7Kr4mCJAcd7wd5mS5yp8f/Y3CNo/PVEc1k8L9QVs7W+FyIS71xWYU9/Q5B7yYuLbj8vKhCZsCCeLdtZO+dYdZo8Iz5jlIZI9J1QCrq9Jm3Mpd/FiatSlv3fHxLx6nLi7J1m86ba9o2PwWopyCEVXPyGzbeE1bb3JIVwgkx+tmw4L9TuIfATxodCeE7aleEqabUF/HFswt86lG4Grxe8iP3XfjR29P4BEK4aKcj+1X0Z9N4StVAQ8Kwnd2tLBDFt0dEGKmf86xNWlu7x4Dh2kNzvBuCTcFJEDuq4PrGqYcNKlcLqbLCaC1JBTJRKs+60bc7oxU0npeGHw4EMKOONOMDE7+Ns34LTsUb13LDkDzL2BytFLoKn1BMy+a139t2f6Eip8LEjqjvqTXPkC+gitQO4SysD1tN+XFu/FTP4RdrtA4zH1DC3QjnlPheDEipLy8ZNr72MgU2j4zVtb/IHBuxXNCWx4Uq+r4BhEd2yAH8jLlHnYMPH0rBlgL2xZevpWlea2zTjc6cQinvJAUT+mG5DsqnSTTzN5+7nsBMkDtGnkRZnVkll9ZLJ+Tqdpjv9CfJ8gWPrdQOX6FIfx8jAOvLQ+vpl0zeLXBLCnZHqiKE7+CU1+DwjkBNIJ93sXnGB69m55 LIciFqsx T5bo7a/pPlxzTW1IG/32K+KYM5ks/xbaxYNtohEhGD3vvt6cWItbRTIvWv9dQcV4ggkfigoLOG1D3sIA3rx4cP4MdMk+ImzaapdPloMKKeQw3qfuchH2ZoBi6vAwafBkIzQGGqI9/u230M5JlCUBTJtcztaSUHDJALSaM732lOmy+ADAnhNbcvlVDqeMc7jG0ms+/0e8vSSbuMv3W6VUTpMuthE4KrHdA7v2Dxkkipn0oRbCkG11rmW7I9upt/oYnU7MEpYrMBzJwJVCd4x7QUm2+M4OTNPGN5s0Fns5N4Ax+6jlWLN+s6XWNDAhm+puM78dmKitV+91MNrSBoBb9vQJ24HUW31kMc5w6DV3p9uKvAMW5fIJ/+dtYNu5EFeZJvQOe2YJ8DDs4vjOI/Pv4Zmdn5BoXQwWb8JXLwtH8foyvwt0u0TBcs195CNkXXTsrO+CwoGi36cKhFnfD+mp3QnE4oKg8Wve0Cjcx/gdayXPuj7GOoNtg53DCXd21X85HYRHmCzN3+FbVgI2b2a4f7WhMg8vBUt0O3YbpYj7rx24r8lX3f5MYC71Qs7AYABhE5T5hd5ZCpuSC/PsMhBRmxRAl2fJJ2b2+Hq6ASrVc+mXzyoUjft8JqTvVvh0py7uEj5atWO4XFADEWyj0KSh+P+n5qecjJ6UxWtxnrFv9oxak3sgEgjUASI9Rtvu/1s4aViCO+x+gcLTPcr4qwTBm1/POytyizx0nzt8RkfKsHhG1uSX/oW/MX8at2e/CTASA07rrPbLRYUT1xU2XZKHcnyMD4vURPKAmqYf2fUkL84Ftzf0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 12, 2025 at 09:27:08PM +0530, Dev Jain wrote: > > >On 11/02/25 1:59 pm, Wei Yang wrote: >> At the beginning of find_zone_movable_pfns_for_nodes(), it has properly >> set node_states[N_MEMORY] in early_calculate_totalpages(). >> >> Instead of iterate on all possible nodes, we can just do the alignment >> on nodes with memory. >> >> Signed-off-by: Wei Yang >> --- >> mm/mm_init.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/mm_init.c b/mm/mm_init.c >> index 35754a8ae6c0..3ec50b5fda12 100644 >> --- a/mm/mm_init.c >> +++ b/mm/mm_init.c >> @@ -547,7 +547,7 @@ static void __init find_zone_movable_pfns_for_nodes(void) >> out2: >> /* Align start of ZONE_MOVABLE on all nids to MAX_ORDER_NR_PAGES */ >> - for (nid = 0; nid < MAX_NUMNODES; nid++) { >> + for_each_node_state(nid, N_MEMORY) { >> unsigned long start_pfn, end_pfn; >> zone_movable_pfn[nid] = > >I have boot tested this, and also read the code and it makes sense: The only >flag which gives the possibility of ZONE_MOVABLE is N_MEMORY, and it gets set >in early_calculate_totalpages(), and before the label out2, no function plays >with node_states[]. So please consider: > >Reviewed-by: Dev Jain Thanks :-) -- Wei Yang Help you, Help me