From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1258C02198 for ; Wed, 12 Feb 2025 17:02:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A8AB6B0085; Wed, 12 Feb 2025 12:02:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 231CC6B0088; Wed, 12 Feb 2025 12:02:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 084616B0089; Wed, 12 Feb 2025 12:02:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DD2046B0085 for ; Wed, 12 Feb 2025 12:02:22 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 84BB6C2543 for ; Wed, 12 Feb 2025 17:02:22 +0000 (UTC) X-FDA: 83111910924.28.FE8AF00 Received: from poodle.tulip.relay.mailchannels.net (poodle.tulip.relay.mailchannels.net [23.83.218.249]) by imf15.hostedemail.com (Postfix) with ESMTP id 9B271A0038 for ; Wed, 12 Feb 2025 17:02:19 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=NQrVQr0S; arc=pass ("mailchannels.net:s=arc-2022:i=1"); spf=pass (imf15.hostedemail.com: domain of dave@stgolabs.net designates 23.83.218.249 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739379740; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EBzRTmDn9RGkKaDCxFY4rdfvgu3ROy2TO3tpi8O0p14=; b=ZfYOjbpOkNoxQ4MslLfkRPy7ON4XYy66k9/D50eVYs5MlsWu8xMKKq/pcfonhO4K7kUzdN CVRjh9Pcx8ynMhXctwDLkiD1aKc5X0CpgaVQ9VRVlSPg7uFan5r/Hpr/vphC9Q8gKSseEp J3q3L07NXaOBFmug6EMmK9g1rdryyUw= ARC-Authentication-Results: i=2; imf15.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=NQrVQr0S; arc=pass ("mailchannels.net:s=arc-2022:i=1"); spf=pass (imf15.hostedemail.com: domain of dave@stgolabs.net designates 23.83.218.249 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1739379740; a=rsa-sha256; cv=pass; b=6Urx02fVUz2Yg6woiw7M3Zl2HS3uymF4I9FtTgmz4Cci63A5Z7ccgFtusYxxgzOqBUIl8u JYwtyVNPIXELNTwygdf+b7oF5S8PAwMwR+jhdzfxtWmfdW5GXtKUGtYts3AfwG+IiNcKnb ft8ECrlECJYf3jSGXpgJs/atHHUcptw= X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 0068E84391; Wed, 12 Feb 2025 17:02:18 +0000 (UTC) Received: from pdx1-sub0-mail-a201.dreamhost.com (100-122-220-145.trex-nlb.outbound.svc.cluster.local [100.122.220.145]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 3A06D8340D; Wed, 12 Feb 2025 17:02:17 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1739379737; a=rsa-sha256; cv=none; b=EUw7XLTp+RuAd3nunzoixF+g/nD65Reu/x9aIc8zjRhyeYqBk40OIdTRvcMnsSbV29Gwcj FshDjzTBXUdq1frs0Y8UGmKwVo7l0GmT8G6Tr7Oh59JnyrADwiSYdrqA1Apzr41cevNc68 JbwVHXb1R2bK5XgWs3ScwDfBzgpiW9sUghrpP9iUqRB7ZhFsQLPa5ivb7jfxlLkchY8Sd0 hy6evbiypIjReYO2G9wOG1ujHY1yU2x66bHrUkW0L9MMLaFrY1JkCik7ns7tpoMfz1M4IL 3884N7IB3auSUVbPq+WWuuqkgMh2ZI8e+592lxtIa4E56W6iDfxclZXEqDP61g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1739379737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EBzRTmDn9RGkKaDCxFY4rdfvgu3ROy2TO3tpi8O0p14=; b=oR8QP+XzSLMzzN0foqSowV66dZKzjDGNv2ixRZ1PSqIrpTlkoKtU4jvEvzV/hiH++M1i3G edrOFHp6rzg8m5hq/3n3uSCv90+B2AUO0SmFjNyCLfU3xZFB06xpbhhiJpagrSsnSrAUvB UvPX62pqc76vZeyEd8DFxw5C5W0mw2z13H6NimEJXGMyFbAMmdkzU23CBuqzxCTUzYkv5B Qb89Kh9a/KdOg6xo2xla9WO/wGwmXxVXI4iDgCH4Nq4t841yDbp71VmZ2r0CuYKcFtMcWi iI/HbWsofDKkPdHxcECsnROIV6xN7a1XxWz99z7wHn1fYxr8HgqI0dVh8RZ3cQ== ARC-Authentication-Results: i=1; rspamd-85897f8565-7nq87; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Madly-Language: 4f2c550c4a5244c8_1739379737734_2344064167 X-MC-Loop-Signature: 1739379737734:1008128835 X-MC-Ingress-Time: 1739379737734 Received: from pdx1-sub0-mail-a201.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.122.220.145 (trex/7.0.2); Wed, 12 Feb 2025 17:02:17 +0000 Received: from offworld (ip72-199-50-187.sd.sd.cox.net [72.199.50.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a201.dreamhost.com (Postfix) with ESMTPSA id 4YtPkH4JB5zGy; Wed, 12 Feb 2025 09:02:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1739379737; bh=EBzRTmDn9RGkKaDCxFY4rdfvgu3ROy2TO3tpi8O0p14=; h=Date:From:To:Cc:Subject:Content-Type; b=NQrVQr0S/AmkFzSOVrM1Zy9gYPnUGcgzM+26l9JvxJ+jRFHVMxsIVU8zQD8qKlx7G vcYIq+bsREQb1yBnJ/CIL7zKl8lr65H5FMdXCre9vDEc7q/LFuc4J01ybodITETinz MPmaLFtez1V8+/FF51bFxQM74IWj7ihI/deXmAtHr2l+b+NtNNkLTlVtAh0Kn8yTLa A5VQ4U3s8uPO8gaNsjr57Hay17mJNMaH1zJMei5WD2Fd+oybyaACBBrgR5o+j6QKDO C+No67zLJ/8Ik3Tc25PPUYwfDkAeyxLtbw1Xh5v4XVPC2OkRGGzpRET5uipms1KvXe zsPUMDZXIXv0g== Date: Wed, 12 Feb 2025 09:02:12 -0800 From: Davidlohr Bueso To: Raghavendra K T Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, gourry@gourry.net, nehagholkar@meta.com, abhishekd@meta.com, david@redhat.com, ying.huang@intel.com, nphamcs@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, feng.tang@intel.com, kbusch@meta.com, bharata@amd.com, Hasan.Maruf@amd.com, sj@kernel.org, willy@infradead.org, kirill.shutemov@linux.intel.com, mgorman@techsingularity.net, vbabka@suse.cz, hughd@google.com, rientjes@google.com, shy828301@gmail.com, Liam.Howlett@Oracle.com, peterz@infradead.org, mingo@redhat.com Subject: Re: [RFC PATCH V0 0/10] mm: slowtier page promotion based on PTE A bit Message-ID: <20250212170212.f5coa462p75fuqj6@offworld> Mail-Followup-To: Raghavendra K T , linux-mm@kvack.org, linux-kernel@vger.kernel.org, gourry@gourry.net, nehagholkar@meta.com, abhishekd@meta.com, david@redhat.com, ying.huang@intel.com, nphamcs@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, feng.tang@intel.com, kbusch@meta.com, bharata@amd.com, Hasan.Maruf@amd.com, sj@kernel.org, willy@infradead.org, kirill.shutemov@linux.intel.com, mgorman@techsingularity.net, vbabka@suse.cz, hughd@google.com, rientjes@google.com, shy828301@gmail.com, Liam.Howlett@Oracle.com, peterz@infradead.org, mingo@redhat.com References: <20241201153818.2633616-1-raghavendra.kt@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20241201153818.2633616-1-raghavendra.kt@amd.com> User-Agent: NeoMutt/20220429 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9B271A0038 X-Stat-Signature: k17fi1g34bkra3iqnfo11n86noazb5fc X-Rspam-User: X-HE-Tag: 1739379739-906069 X-HE-Meta: U2FsdGVkX18/kEuLnwCdyy7oBI/k72/VlpV3YfiOw4Xx3lOMFn0BzSSef/kYqgMHzBUXMYnkehcBW30jULTqirGzqAewvgFLDu8JHnaADA8byNaSnjmrioA0W9YQ5dL+/cvnOvJofZuUl0YlhrTSchkQrYi1cRCsRWFbXAM+aM0sVL6y3Ipz/Vpwe+Mk7PSVxLC2T8vI+AIDcdM10RSS6sNs5+TMGMqhCza6fzBtR3ix6Bk/vDsaXpzz+5H6I1Ixk8z2jYXh91sEibAh0eoGtvV/h4q32Zx8VftFEBWxiB1EQekjiD9Wk2IfOl9BnMXc0N4+kLBwFCuRsQigfqLZxZ5WOjBdKWyy+4T6eP8dQRZm6yoZiUlqEt8axzRpufVoNt3F4sVNAZDKiT7PNDJI3YmRGbozZ2DWgSmFptGE+W89J0iuimLWPn3dLZo0aDhbBmxJOhVh6hoI36CzW64xmQ7SD+NjhrrrXolx8x4C2EdVMxIhWwqCChRL28UjfQhTGGqyEAIfQfz227CZZpSV7I13D0AIk/RXNYuLfTuP+YTtgRKd1ca6kC05S68j80NfboPt920ICq28FniMatYQrxQtpYaXtBhgKfCcx5Nm9jEWYr9t5HoydeRlfjuhGyzcx2rOVqM3ZwlAPwHKxIdcvsCbLfLBt4ZlBiLgaPOQaPHMvDIxxI7H6PmSxLMoiEBfC+Q7nKdbaB0HMiFJI2FPP1vwUiZXeIOIy/XS1CJpXYlS7rnOUsdNhBtvSWtocW9xvmbh26Xm0IYhSykJ9CYQdlBeoauTOcJI0yF1xOdfQRgOOrlvQEyhR7SxUP4SzEbiM3oUgKc5CMpy4xmHTMoNXFYwxsSU4cAq2XFm3SU23U5xKM/NriCvZJ9zmMPgG9wdh4M9Qj5UfucBYbQ9mzNS9F08KWGvMJg/bwBmllumMtUM6neRREH5/JAwEHD2/L5CaOfsFYlpzzZJqOzStpp jYkW+eD7 zOCLHlrZd850DDU0Uc7ILJqS7Yv59pObAAEnS122+wcfGaGZiCeXh3PITIjVgWTO9pqlmVH4DwQct5G1wSU9f0BPaD5+l1bT76ShylK58fPmtHYxbFkSjo0VKPNtNkwhjc8eONwtvjc4IGD3VCOm91hPYIEEalpZq4jv1WHKVvFLxcfzwcCXN6fBW2O2rJX1ubllfAnpYlC5bEeL+paOCwatgnryS5I382l5Nm1I+OqYPR8/1Q26UEIPvVxg38CmHDK5MgxN1d7uvq8LyCPNFr5cQoMR2TqY/6pIV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 01 Dec 2024, Raghavendra K T wrote: >6. Holding PTE lock before migration. fyi I tried testing this series with 'perf-bench numa mem' and got a soft lockup, unable to take the PTL (and lost the machine to debug further atm), ie: [ 3852.217675] CPU: 127 UID: 0 PID: 12537 Comm: watch-numa-sche Tainted: G D L 6.14.0-rc2-kmmscand-v1+ #3 [ 3852.217677] Tainted: [D]=DIE, [L]=SOFTLOCKUP [ 3852.217678] RIP: 0010:native_queued_spin_lock_slowpath+0x64/0x290 [ 3852.217683] Code: 77 7b f0 0f ba 2b 08 0f 92 c2 8b 03 0f b6 d2 c1 e2 08 30 e4 09 d0 3d ff 00 00 00 77 57 85 c0 74 10 0f b6 03 84 c0 74 09 f3 90 <0f> b6 03 84 c0 75 f7 b8 01 00 00 00 66 89 03 5b 5d 41 5c 41 5d c3 [ 3852.217684] RSP: 0018:ff274259b3c9f988 EFLAGS: 00000202 [ 3852.217685] RAX: 0000000000000001 RBX: ffbd2efd8c08c9a8 RCX: 000ffffffffff000 [ 3852.217686] RDX: 0000000000000000 RSI: 0000000000000001 RDI: ffbd2efd8c08c9a8 [ 3852.217687] RBP: ff161328422c1328 R08: ff274259b3c9fb90 R09: ff161328422c1000 [ 3852.217688] R10: 00000000ffffffff R11: 0000000000000004 R12: 00007f52cca00000 [ 3852.217688] R13: ff274259b3c9fa00 R14: ff16132842326000 R15: ff161328422c1328 [ 3852.217689] FS: 00007f32b6f92b80(0000) GS:ff161423bfd80000(0000) knlGS:0000000000000000 [ 3852.217691] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 3852.217692] CR2: 0000564ddbf68008 CR3: 00000080a81cc005 CR4: 0000000000773ef0 [ 3852.217693] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 3852.217694] DR3: 0000000000000000 DR6: 00000000fffe07f0 DR7: 0000000000000400 [ 3852.217694] PKRU: 55555554 [ 3852.217695] Call Trace: [ 3852.217696] [ 3852.217697] ? watchdog_timer_fn+0x21b/0x2a0 [ 3852.217699] ? __pfx_watchdog_timer_fn+0x10/0x10 [ 3852.217702] ? __hrtimer_run_queues+0x10f/0x2a0 [ 3852.217704] ? hrtimer_interrupt+0xfb/0x240 [ 3852.217706] ? __sysvec_apic_timer_interrupt+0x4e/0x110 [ 3852.217709] ? sysvec_apic_timer_interrupt+0x68/0x90 [ 3852.217712] [ 3852.217712] [ 3852.217713] ? asm_sysvec_apic_timer_interrupt+0x16/0x20 [ 3852.217717] ? native_queued_spin_lock_slowpath+0x64/0x290 [ 3852.217720] _raw_spin_lock+0x25/0x30 [ 3852.217723] __pte_offset_map_lock+0x9a/0x110 [ 3852.217726] gather_pte_stats+0x1e3/0x2c0 [ 3852.217730] walk_pgd_range+0x528/0xbb0 [ 3852.217733] __walk_page_range+0x71/0x1d0 [ 3852.217736] walk_page_vma+0x98/0xf0 [ 3852.217738] show_numa_map+0x11a/0x3a0 [ 3852.217741] seq_read_iter+0x2a6/0x470 [ 3852.217745] seq_read+0x12b/0x170 [ 3852.217748] vfs_read+0xe0/0x370 [ 3852.217751] ? syscall_exit_to_user_mode+0x49/0x210 [ 3852.217755] ? do_syscall_64+0x8a/0x190 [ 3852.217758] ksys_read+0x6a/0xe0 [ 3852.217762] do_syscall_64+0x7e/0x190 [ 3852.217765] ? __memcg_slab_free_hook+0xd4/0x120 [ 3852.217768] ? __x64_sys_close+0x38/0x80 [ 3852.217771] ? kmem_cache_free+0x3bf/0x3e0 [ 3852.217774] ? syscall_exit_to_user_mode+0x49/0x210 [ 3852.217777] ? do_syscall_64+0x8a/0x190 [ 3852.217780] ? do_syscall_64+0x8a/0x190 [ 3852.217783] ? __irq_exit_rcu+0x3e/0xe0 [ 3852.217785] entry_SYSCALL_64_after_hwframe+0x76/0x7e