From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90D8CC02198 for ; Wed, 12 Feb 2025 15:26:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BCAD6B0085; Wed, 12 Feb 2025 10:26:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 06D1C6B0088; Wed, 12 Feb 2025 10:26:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E768C6B0089; Wed, 12 Feb 2025 10:26:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CA79C6B0085 for ; Wed, 12 Feb 2025 10:26:15 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 505DC4BC0D for ; Wed, 12 Feb 2025 15:26:15 +0000 (UTC) X-FDA: 83111668710.30.E95F717 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf05.hostedemail.com (Postfix) with ESMTP id 4ADFF100008 for ; Wed, 12 Feb 2025 15:26:13 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PuLhOhMc; spf=pass (imf05.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739373973; a=rsa-sha256; cv=none; b=J+ZJ5ZxNglq6Kl2aIxXIzjLmG7KJ38O8EgDeo4SMG2AqTEOXPyCd94xWwmfCH2kxS3JZRZ tNljU2Cd1+EhQM+nB8Y08DHKRSm6sEyLFKCY7apZLqm7ixfByHHltrBD7wk4JVHwbVH25H PO5boUQs889XXH2BnvfUxLFhuNeT860= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PuLhOhMc; spf=pass (imf05.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739373973; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wvjG9hNk6O6AhaG9ttlmUq7XexAhA5zfoCCpnbbsQD0=; b=ILEOBXU6Yt2SiiF5X2PufIApftGgWEEzfVCo7rmOXbs4Gvmgvt+32rnnRU/jQ/mEhx0YcQ DhBXWuvbJGUDnEVPow+r6hM4MIJb/wff0heZEIB19NF+hoEtKRv0yP9yBKp8bNchnFA0l4 Jmaq9prSe81KIqdmcdTxxylNDVLLCbw= Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-e46ebe19368so5437014276.0 for ; Wed, 12 Feb 2025 07:26:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739373972; x=1739978772; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wvjG9hNk6O6AhaG9ttlmUq7XexAhA5zfoCCpnbbsQD0=; b=PuLhOhMcHwotljXzkBOWb8/73SfSNwnNACc5u5yjiWCKcPkre4XS2vTfDhNzg2hzgo gIa5p4pGMrUgYkZnu2PbnQ3OiupUk210hfPkCbJ2jRAuH3bMSZEe72k5JmGvxfEBXGM/ fvoWkbkIA0B/b++mVzqp1+uTFCHqFWIjZ1Caw543Ydm7wh1lNLBntmT0JQ2dITYtK8BD 1FsULgAJOGuLS2lS1g6qoJg8aPvV4DXwPN1dYI4KIvnzyNq4+vAusvN3nIncCYx2sWNP 9YmS6vPSR7pD30uJqSMMcHkM3FigqPH6ehEkeKnMwEge8aKfYXTTcKzYlWHpio460cBg 2aqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739373972; x=1739978772; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wvjG9hNk6O6AhaG9ttlmUq7XexAhA5zfoCCpnbbsQD0=; b=d70lSWdn3/4drPVO0kKlpC7AgImgBwl0qhOaUr590Mp0smliZea2TlI6ut07H8lBkJ q1yTOpxcqpQngN6GN9x1bS0EkTECio5pvR/6bOudaaeZL6Kn8qMy66lL66jVWvp9cG8V 3dC3nWdzJrwtyrunH3p1seK324u1yNLnWMp3YoDHwh4/dDYGZel2HN73KKko5JIFIJrU JLtmbQIw6U0xy0WuLH9HTKI1WNmnRgzR+jdrJ4HhwloJumvELGq/lJsvo7obR3cwQvil umClTzTxLkJsQdAklH5fC1/pAtElWaocttc3JBkfJKYQMj8wwCsBZ006L2XyCAkR24TP gdlA== X-Forwarded-Encrypted: i=1; AJvYcCUdP3+U9srs/kDyAHAosAWxOKmuiEER08fcOBd7OWxVBdPNkgXjNv/YyiOcqkNHGcMqOjpGakv51A==@kvack.org X-Gm-Message-State: AOJu0Yw65YwmG6/K5GGDv2nv04knyetZxKM32WeC0LmZybdtXykh1cBK a+DY4V833f8+yzlo5k6ODy369FpBfYgcNX/aVwZlNFIr1ARt0lNv X-Gm-Gg: ASbGncs/fkcpkkNLWSD55KuN6bBDsPeooVI7nW7+wlapRtiDFpMcXJ1XQm4L2CVXOXo ICsI1vAgsCuKSuGl87w7nh4cZcDMVZl16togjosuapSmYQb9kelihHdBIZK0AYzAjc6EB/lQHHo tBLCA2wmobTSOiINBuAVpPzM+FX/XQfS5M3Frt/xiiAGxLS70/rMbjLsg/4qAgamK/T46aHGEoW +QnEshhq0+LqHI26V6zWgnCaHgSTcapJ75pU+Z3MXWhYK4mWhs2Gb3HgU4EdanRUfirnIKrnrBW D8ggi0jO3okWOg== X-Google-Smtp-Source: AGHT+IHcrBpEb0spczFBp80Mc2HWlGMAuQNCOiCGtDzNfF22bnhupf1B3PDC9GMyDn7GT8NwB6XU5Q== X-Received: by 2002:a05:6902:1442:b0:e5b:171c:35ee with SMTP id 3f1490d57ef6-e5d9f1862abmr3742646276.48.1739373972134; Wed, 12 Feb 2025 07:26:12 -0800 (PST) Received: from localhost ([2a03:2880:25ff:d::]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e5b3a207eecsm4097722276.24.2025.02.12.07.26.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 07:26:11 -0800 (PST) From: Joshua Hahn To: Andrew Morton Cc: gourry@gourry.net, hyeonggon.yoo@sk.com, ying.huang@linux.alibaba.com, honggyu.kim@sk.com, rafael@kernel.org, lenb@kernel.org, gregkh@linuxfoundation.org, rakie.kim@sk.com, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, dave.jiang@intel.com, horen.chuang@linux.dev, hannes@cmpxchg.org, linux-kernel@vger.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com Subject: Re: [PATCH v5] mm/mempolicy: Weighted Interleave Auto-tuning Date: Wed, 12 Feb 2025 07:26:08 -0800 Message-ID: <20250212152610.570427-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20250211161752.64dd397e66a2754097ab8c2a@linux-foundation.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4ADFF100008 X-Stat-Signature: g8wh4hnp3iiha64wnj3exe6yq74ty7ge X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1739373973-443642 X-HE-Meta: U2FsdGVkX1+f3W1um/uwkoMBh3Ll+IA7LyO4XagTso66fGUSrqm95VyAy7HefltWYv1S6Z/c5LuaeJY4yD273yy+6I5dGxYk8XKnh2IXUI7EaJ/fyIbD2trsRqdnUZjY1zSeC5WQ1BvO+eP0l5ckrjsgHyPmndk+yTPGcWOeDBY5hqHYYL2py1NPEU4Xw+MJTGnoPhd913k99zLzu7FXbV8xGYcCLL2VMRhOlU6LRWqtKyb1lQmiTs3WK6lH/KCyFez2hlFwViWdU/dEV0xura1iHxD98BtMPbPLx/Vm9l4tfzY/Mo3jYcUtaOHIhqVlIIgQbw2IkOT2pXEEaLQOIgubkCOnUiHRr/DStjntmE/heXpQnxr1lwc49sWC8naoI+Eps9IRT0RFRRYPYKhE/NGULs3DcJGHtcC7uUr29njGnI7IFfbpHSnuamFo7D8IKWTGMkGgEY375ZYyY0oDHtoWQv4FPiprntd7v0KZrtkyj9fmV8Lyg8hodB3Es047mqVK6A7TSPjir3CSFSf+J4RFUljkh5fJwHZNo8Bt2+sGyyXNRPL1bo80WVby83DMB3z9LrGOsVUNN6ITqO85n2vNzPtXrh4ww2Ix7p/SpPvuF2WQXtsrDHrjU8xZh4A76zAHtGpPPBoHDAy57ECIU276nVzGQKq8NJfMMXuLM9H1ZNsG7shocyCAFigo8dKB5NmOy3O4DbOAFrvx1F8GqMVVfv5fEC/+r3w8noCQAZSisMp3SWes0UkOy42PZeE+N5zq1UjU4iKdg1ozw15VK2NlCMuWyHI00m1uWmuky7lC4M9pP9hxaK5JlNOaM7J3V6UpSez2TQZ9+3NxhZbU9hQ/D2aFlH8l8Vyd5kpD2ZiILqwMwYncaBhPwKeWVqWasQWdymkVLefUHZgPuqAurpOnqxcvSeu/pxE1yJcMHsRil5OeFjIusRh6dCY7K+dK7sVk+wOabRR2WRCq9ef dvqoXi7O v78VGeOEeV3/n2JSlwZ2KkmAtyLPB5kh2qesgrwOP/4PdImvKsuA7peXndP6+oizyederIUgh/F+7ks8RmuMqxr6ecyBg274b5OG8xwcl2PiNxg4Tqc2A3w4swZf3yTVE2D9SodrsX/9NOkKZwpo7x+wq7frnwfz+zzg84haHGTHI0dhmh7xymqUw0Y2GxusWanxHguC6nGU2G9POJWkJjoCjKH1WTodYQjBIfRYOUtdRyCmhtFvIgXNnk66PB5K+1Tq3ya1JYjTNVRHayKWUd6Ng9BtBW9O5lqTixpLbh1MCdpYMlJ5u91OWnxNUY+RHmpg8p2XTkPnwn1vfpUl2LJB9+/4KPs256ZgWSksuiaeh1odjFPvxu1vVgsrnBNryj+NdomY4IleLfAsCKcKyJXkmXY239E34/YJ3iDpC2IHYgnVbwC46CCWr+cH824OxL2Go5caDlb2zrIlj9tB72Whva4LiAgiAfiV9eWLICPT8gpc61Eyhd75IxryATsEYqLexR37+dFPn8Oc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000707, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 11 Feb 2025 16:17:52 -0800 Andrew Morton wrote: > On Fri, 7 Feb 2025 21:06:04 -0800 Joshua Hahn wrote: > > > On Fri, 7 Feb 2025 18:20:09 -0800 Andrew Morton wrote: > > > > > On Fri, 7 Feb 2025 12:13:35 -0800 Joshua Hahn wrote: > > > > > > > This patch introduces an auto-configuration mode for the interleave > > > > weights that aims to balance the two goals of setting node weights to be > > > > proportional to their bandwidths and keeping the weight values low. > > > > In order to perform the weight re-scaling, we use an internal > > > > "weightiness" value (fixed to 32) that defines interleave aggression. > > > > > > Question please. How does one determine whether a particular > > > configuration is working well? To determine whether > > > manual-configuration-A is better than manual-configuration-B is better > > > than auto-configuration? > > > > > > Leading to... how do we know that this patch makes the kernel better? > > > > Hello Andrew, > > > > Thank you for your interest in this patch! > > > > To answer your 1st question: I think that users can do some > > > > ... > > > > Interesting, thanks. > > Have we adequately documented all these considerations for our users or > can we add some additional words in an appropriate place? Hello Andrew, I have documented these thoughs on a private document, but I think that it will be beneficial for weighted interleave users to have this knowledge to reference in the future as well. I can think of two places where this information will benefit users the most: I can elaborate further the motivations & decisions Gregory and I made for this patch within the patch commit message, and also in the ABI documentation. As Oscar suggested, appropriate details in the code should hopefully make the decisions clearer for future maintainers and developers as well. Thank you again for your insight! I will have a v6 drafted up, and I think it makes sense to pull this patch out of mm-unstable for now. Have a great day! Joshua