From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 331A5C021A1 for ; Wed, 12 Feb 2025 13:08:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 753146B0083; Wed, 12 Feb 2025 08:08:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7030C6B0088; Wed, 12 Feb 2025 08:08:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CAB8280001; Wed, 12 Feb 2025 08:08:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3DF956B0083 for ; Wed, 12 Feb 2025 08:08:28 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C897B1A1B3D for ; Wed, 12 Feb 2025 13:08:21 +0000 (UTC) X-FDA: 83111321202.27.7FCD8C4 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf03.hostedemail.com (Postfix) with ESMTP id 67E9F2000E for ; Wed, 12 Feb 2025 13:08:19 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=WhatjOO4; spf=pass (imf03.hostedemail.com: domain of imbrenda@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=imbrenda@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739365699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d/AAh2N7Z584VoCriTs6eobgAtZ4TQ8A1tc+k91/YiY=; b=zmcr6+1m+VFB90+XYjMBXUyDY39ImIOXMA2zCnsnRwfzfS2HLVzDwrMXwDXXaZqRQELoA7 fQzivz+8feZ5aL1DRHiNKDIEndse4o0pZrb7sfFMICmT48XX+KmW6Qe9VaqQVJFrgZEG4B jBXjqJIdHXCxFeizg6WbG1Io7lbRAmY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=WhatjOO4; spf=pass (imf03.hostedemail.com: domain of imbrenda@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=imbrenda@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739365699; a=rsa-sha256; cv=none; b=15eGLIaic7LViqYW8g1ABf2XADdQF6V+kZEOx3HfdwQ2F4auQIqZ2V87dYKbWu7TJ8MNrU 1lvyO308RDi0/5qDd0wMv9qS3CpJsbqJNFyvZIGoL1Oy+Co75/vyoxqhV/3eOawnOFdI17 OClP4DxrQjrp2AU9vohq4kQ4oqAYkHs= Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51C8gmFB013492; Wed, 12 Feb 2025 13:08:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=d/AAh2 N7Z584VoCriTs6eobgAtZ4TQ8A1tc+k91/YiY=; b=WhatjOO4eNKe+AVt3XaFUE HY+WRRLI4QbriRxPa34Sd9igZU/SaSCYkbgIobSKmVnDhwIswkZW6p5wO5N6jPAj BxxXUgMcvDcv91d0tIwFknwpiT+/0Ao9YaBHr8x2Xoq7c8T+zaLInXE0MYJ7uTN6 /CDMMScbBa1JcwL8Ly9p82hT6XuGRTBYyTDhYe6aFxXZBloi7KKZxWyC1viMIV8+ xfeEGK2Rkx9f64QscJCKKw7+LP2vRE7hdXXKP5ORjgL984+0bkPPb+ro6xL8qmdb R73t3IlzE0bGzAFlvu9p5kgFSrc+LMeQTjRfJ1Ziycdzr98aK0nm1pseJUQV9wqA == Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44rfpa3fhx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Feb 2025 13:08:13 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 51CCPkHV021875; Wed, 12 Feb 2025 13:08:13 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 44phksruj5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Feb 2025 13:08:13 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 51CD89lf45154802 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Feb 2025 13:08:09 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7016820040; Wed, 12 Feb 2025 13:08:09 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0549B20043; Wed, 12 Feb 2025 13:08:09 +0000 (GMT) Received: from p-imbrenda (unknown [9.171.55.171]) by smtpav01.fra02v.mail.ibm.com (Postfix) with SMTP; Wed, 12 Feb 2025 13:08:08 +0000 (GMT) Date: Wed, 12 Feb 2025 14:08:06 +0100 From: Claudio Imbrenda To: Alexander Gordeev Cc: Matthew Wilcox , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-mm@kvack.org Subject: Re: [PATCH] s390: Remove PageDirty check inside mk_pte() Message-ID: <20250212140806.676d7bf3@p-imbrenda> In-Reply-To: References: <20250116212338.653160-1-willy@infradead.org> Organization: IBM X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: EcyXP5VK-2R-JN3saIGtsEDhyffblIoU X-Proofpoint-ORIG-GUID: EcyXP5VK-2R-JN3saIGtsEDhyffblIoU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-12_04,2025-02-11_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 mlxscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 priorityscore=1501 mlxlogscore=731 clxscore=1015 phishscore=0 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502120101 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 67E9F2000E X-Stat-Signature: 4gaqbsjkqcan4yrwwc8ku3nj19qqus5q X-HE-Tag: 1739365699-335130 X-HE-Meta: U2FsdGVkX1/wG+refvj/Vro2PMW0ep8hXh3tN3mJxlMwAKGlaD/gPuPn5j1oglbjXvRuHaH6NdJaRGIk3TfgLgl+zLPOgpMajM4b0AYODmTGo8Eh53lQhKQZL2d8tMlVsq7/3q7cfBEw8vgQxgp0MZh6y5oK6XuU46KgH8zBm+ZLLBack1+svGp4706aUgrJ8MXRjdDIx0/Q+90CEtwk36AiOD879kj5fUqjR9B0DR0lnxODgk3LFCuwyZIGacLuvv0oN5mzFoLKCznWgsyIikyCYiPrS4JIgrUGY+UhC756n+9ROPzVzybiA3ULsfzc7U9p3t+MLRsRFD+Z31RHiLf7iiqboJs7Yi4lio/vvH8DR+KXITCqMpF502/tP0KvaA5JU1M6Kwq61urd6A/p1JyIJbbumsuhR3xXl8mT0gFgF/wytmVjDHmhbbAo+Xj+ImVqqcLzrQOiyLT2+Kk0QerfpW/f5QfD1bjCH5auF4VyUmZk3rf50Y51eqNPNC+lww6PN5kONoOi0nKiIQRP+0m2zr30lWYBgJwNhLB0zxiU4gfFSkxOr5nYhlfxIwCo6Eo2NTjvat4IDYG4Vl+rD5JxEl0JN5wWVG1cscMPr1BsZduE58JjQ04bJUJzaV7nk7Nzw7f00NKrup23uCzc7IpnbydcK4dmZRyFJuSeKDf13bnlEWx16TUgHrDLm+b6e9L0jrvbkqSqm1ZFDyfDNrkj1ABvwzAmbmccDYV9ymswN0H1lfLQf/CItpvBt3ROWdQWjZ2mMKveSbMiEzZkhHAzJa64ksqdiC0jeN7tTky3Aits28MaTtKpeRrRbFi4phLjnWFRxYJed3T7+/CgDmsGLrOTaHjnIbVToDasK1CyC07k398cv9iiAIU7n1Z+gU6cbKQNV70oNoEAl3AnbGaF5ii4Rm3P6x7wGUiruRApHtg02vu5ORfhQs1hTPhmC8l5H5P0lTZN936ajqp Dc/iET4p MW2N4ZoGXONUUboKGRTjLSHCw0WMUr+L9E2dZHncvBQxBsMS7G0tQryZJE0bacmUvNS3RdURhl9ezG3rV7pX96YOOBz9AJNxmCL6UfrhvUfVgmBe46rb2iYU49RLC6g7lEVUPhjj747OpJV/htdkdlKys2+9VlDPwUUJvyP77aVMp+5Xsn32e+Bndt9DIVSA9oU49LLa0uWo3uyVB/5DMsKD5GmGWrv+N2z9jS03xHBjdphG39mUWUhywjaY7B67lN/T2GIKuRSrWW8jsFxl5N7+2ILupRnCjKlsWrrpGlZP8qkYcWxkG2jQFUVsfc2B+3tlLDQ9o3UQUM0o34+rhTuSdVN6+eYcgZlCWO+puDC6fzcPxymgbwWFTowki1DDGpTaIlmCvAvDm9MnNrJ97nCnOAy8ANxODrkIcKKPDDf0Y4FREBRebB/9ok8wSx3NYeQnFVoHJR88iaCWIKFsQsWFb7FekDrw05ta7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.054001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 12 Feb 2025 13:44:58 +0100 Alexander Gordeev wrote: [...] > The above is however not exactly the same, since set_pte_range() -> set_ptes() > dirtyfies all PTEs in a folio - unlike the current s390 implementation, which > dirtyfies a single PTE based on its struct page flag. I have not looked enough into this specific matter to actually have an opinion, but I just want to quickly point out that in the next couple of years struct page as we know it will go away, and flags will only be per-folio anyway. For more details, see this presentation by Matthew Wilcox: https://fosdem.org/2025/schedule/event/fosdem-2025-4860-shrinking-memmap/ so starting to do things per-folio instead of per-page is a lot more future-proof. [...]