linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Matthew Wilcox <willy@infradead.org>,
	Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	linux-mm@kvack.org
Subject: Re: [PATCH] s390: Remove PageDirty check inside mk_pte()
Date: Wed, 12 Feb 2025 14:08:06 +0100	[thread overview]
Message-ID: <20250212140806.676d7bf3@p-imbrenda> (raw)
In-Reply-To: <Z6yXyuvh2QckWnuk@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com>

On Wed, 12 Feb 2025 13:44:58 +0100
Alexander Gordeev <agordeev@linux.ibm.com> wrote:

[...]

> The above is however not exactly the same, since set_pte_range() -> set_ptes()
> dirtyfies all PTEs in a folio - unlike the current s390 implementation, which
> dirtyfies a single PTE based on its struct page flag.

I have not looked enough into this specific matter to actually have an
opinion, but I just want to quickly point out that in the next couple
of years struct page as we know it will go away, and flags will only be
per-folio anyway.
For more details, see this presentation by Matthew Wilcox: 
https://fosdem.org/2025/schedule/event/fosdem-2025-4860-shrinking-memmap/

so starting to do things per-folio instead of per-page is a lot more
future-proof.

[...]


  reply	other threads:[~2025-02-12 13:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-16 21:23 Matthew Wilcox (Oracle)
2025-01-20 16:39 ` Alexander Gordeev
2025-01-20 19:01   ` David Hildenbrand
2025-01-30 22:12   ` Matthew Wilcox
2025-02-03 13:03     ` Alexander Gordeev
2025-02-12 12:44       ` Alexander Gordeev
2025-02-12 13:08         ` Claudio Imbrenda [this message]
2025-02-12 16:43           ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250212140806.676d7bf3@p-imbrenda \
    --to=imbrenda@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gerald.schaefer@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-mm@kvack.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox