From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06C8FC02198 for ; Wed, 12 Feb 2025 13:04:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33114280002; Wed, 12 Feb 2025 08:04:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B9F1280001; Wed, 12 Feb 2025 08:04:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10CBF280002; Wed, 12 Feb 2025 08:04:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E24CD280001 for ; Wed, 12 Feb 2025 08:04:03 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8F779B3C41 for ; Wed, 12 Feb 2025 13:04:03 +0000 (UTC) X-FDA: 83111310366.26.40CC865 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf06.hostedemail.com (Postfix) with ESMTP id B82AE180014 for ; Wed, 12 Feb 2025 13:04:01 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=yyFkh7uK; dkim=pass header.d=linutronix.de header.s=2020e header.b=OqFRzqLI; spf=pass (imf06.hostedemail.com: domain of t-8ch@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=t-8ch@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739365442; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=soGwUcM7FS1/q41UUnp8a+P68mixKiDDmCjv27Yua7g=; b=77SzDbZrSL1o7Q4nrGkp7t49g5HJjMNaYhEbchTHElsUK1Ix2fDJgpDxR/bZWbPOQ5XueB +f4C1N2lUGzB4J+bKnBoXJeg4ahZRrbMdWiuyPeSt/N8c19eIGmgzlcW4dwvpNVHIUyWzn 8QORehvs7m+50Obif6g4cXTcq+99AKE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=yyFkh7uK; dkim=pass header.d=linutronix.de header.s=2020e header.b=OqFRzqLI; spf=pass (imf06.hostedemail.com: domain of t-8ch@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=t-8ch@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739365442; a=rsa-sha256; cv=none; b=aAX11BI8/IqXHdV1OiM1LbasZ8AtchztyPR69sIfp7nMsBEtVINQNXcAVKfkGh/TswZuw8 D8loyfN66koX6zK1/IRP9Jt6NukjYyDzJUXh7glyM73FxTMr7HHqSvLndGlhICIpWZnFdI tVoYGAeV5fQHQpblvpXgTItisr/P8Fs= Date: Wed, 12 Feb 2025 14:03:59 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1739365440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=soGwUcM7FS1/q41UUnp8a+P68mixKiDDmCjv27Yua7g=; b=yyFkh7uKgxkpEzxHO9IJM/Su5JamH2HM8z78zJzBJYgf0Lxpy6M6hWQ1rXpixOlD8fL2rZ hiysYZUa5k84oeZDgPBdlpZlO+Oj68XYfCARPvdqf5dE5wV417yuPq3udxS4nxZgyzOlsk +QD4vLafFb3qOWe6fGvm2qbXpquB9TJUiNsAW1ohhUxRsPts8AlEaIUb7ohKiV++04U4Zw /zSZ32L15VL92eJe2Vh/MWaW55AUPwUcvNLkKiXRXOA7gxreGAd3D4W1k1/bG4jeiPMymy tL3tsOCpnUk8JLEkY8P9tKafkORcFX1Xk0YrCP/PhtAKAtJ7Vl2RY9OeFQj9mg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1739365440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=soGwUcM7FS1/q41UUnp8a+P68mixKiDDmCjv27Yua7g=; b=OqFRzqLIlg24n/tDmtYsX94R48vsZwYDpth0U9pqbAGNaSCr8vHQileOHaoaaTu6hn1vpX yjX+qcIgpSa3+KAA== From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: jeffxu@chromium.org Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, torvalds@linux-foundation.org, vbabka@suse.cz, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, adhemerval.zanella@linaro.org, oleg@redhat.com, avagin@gmail.com, benjamin@sipsolutions.net, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, sroettger@google.com, hch@lst.de, ojeda@kernel.org, adobriyan@gmail.com, johannes@sipsolutions.net, pedro.falcato@gmail.com, hca@linux.ibm.com, willy@infradead.org, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, peterx@redhat.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, aleksandr.mikhalitsyn@canonical.com, mike.rapoport@gmail.com Subject: Re: [RFC PATCH v5 2/7] selftests: x86: test_mremap_vdso: skip if vdso is msealed Message-ID: <20250212135000-861e6353-6e0a-43c3-9b28-649ae4dfc607@linutronix.de> References: <20250212032155.1276806-1-jeffxu@google.com> <20250212032155.1276806-3-jeffxu@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250212032155.1276806-3-jeffxu@google.com> X-Rspam-User: X-Stat-Signature: 4dh6c45ybe66wre55akth6e79hykf39b X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B82AE180014 X-HE-Tag: 1739365441-476988 X-HE-Meta: U2FsdGVkX186fACJE8l8Bf7pODj9x9KvXt6uMBl0oc8ComcGODBytPvqHF7bXRGP3CE+GHFeUk11NCBuULT0wKC3I09DmTqv9jsSfDIkYJudgBVdmuQDW6Vy5m7EeJmf/4X1UkAFFoVMgDDCBO+4Ua3Rsv3DcGUtc+C6Casj4YMJUS/tq8xJ7F/pnDkf2/uKBPtRAn55iCmrjw+mV/b6YxCD0Z90Hzh8FLWd4rxW7TazwofkFxJaVveM96X9Up5704gxrPj2ZVXnIt+dM5oy3H+GMkiTXfQE3aKgOUz2Ow+tPPkWPKUvzLevav73e5TaWN4PeK0A3iI+Q0dwoS7AFEQD3ds79JL8HGAQYGMH8g68A8Tg9ugT12ISbYG88sG6cwI3ydg9LFlxU94nQTVkLIrxn/fh+6x5Nplizovcf81aUw/K0PZyNJoZLb4wdAMD31gMs6h0VnGvaGfib5OfXlnrJbOPTwBNMjhh0D/Z4aLOQwJ/wqBJsTBP/vTR01RI5oEJu6E9JxA+y68roPaRTNaOggJw4Ggu5B6XzUoF15eJTOeIx8SIsdBTc2m5HOWgD0kmnpxHjUadZNJQoXeOKMPQ6t1HhjVvJiku27fOkJ7BqHqCaHrItSTn6W9lGRgi9NfJjsG2T3kwc/Yqu+BJCNnaAKDh6d17Jz07pL6+oih8Qr7LfS/T9QXXz1XnNRjt/Tj3ukTC1ZVmr1dGk9vDQZHVee5VQN7u7w99q1QiLQnIsBTHYUdZ4yNn1QDeU7Wu48lE/EATllyuGagG2ShzuOHueaFu+a6PTjmTJSeM4dn0HrPT2FfoqVKzlpT4s/eg/VknJelFknwmI78NYxHN+hyg/FSWDBRl0jSElkuvTErfiE6O8m4PralVJ+bUwhunCk+ciXKhVXDhpzuwJTaoHEBlFRPF8tiG1KJ4UCI3P5fyjLyqL7p54tqL5Jz/098pQLs8VNyzJjVWSn+Ficy FGpjVJcz czhmwomflTtBaa9LEgdo1KopJafQ22iKykn+A+UUXW4rlchqrSAeVg4ABquaZmBSQuQH8Sn6TZ4ghRCmsw4eVHJwuKchAqE8gfVOOjc8GlS6+i00N6HRk5dP8ve1wB2fl7puIEsgdgzZ/UHhjoDv1cI/GR67h9q/STDOVsaHo+1fAo1MncOd109hezdm7vEaxbTSEyFkB3n1oSt2zu0hl5caO2nVdMaJ4vqk5UAZlybkJ5ZICR5ucqRw8SZzSz3BdHpGpNEDoeUuX/NC+dvD0h9hnv4Ufwb9umgM75tLj1WdlnsW3cNfeVJvVyGPJXRn3wCHQU7VuAPyDnhLuAlJhwxwWfoPG/m92SVjHSoLBTEOnSEEwLkpoJq8iNH0yIZ3B7I8GriYYDLzTSTellAdxA1iBt1pehUbA2aeHU/mWgIcrzYzV+DHnX4IJU/PoPVEeDgKX0IJ9gu7v4BmbBbYJ2yzCQ4oW9aPI5MFpWLHqoamCdwvRA/CQrC3QgrBj63Tr13cD6fzoYfvRHDeHS0+DjT4yC9T8dwtPIubgyt4OQfOK0c/QFXyMy2i6vVKzkwNBSsxkinXlab9djucViTo7tQ0Erw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 12, 2025 at 03:21:50AM +0000, jeffxu@chromium.org wrote: > From: Jeff Xu > > Add code to detect if the vdso is memory sealed, skip the test > if it is. > > Signed-off-by: Jeff Xu > --- > .../testing/selftests/x86/test_mremap_vdso.c | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/tools/testing/selftests/x86/test_mremap_vdso.c b/tools/testing/selftests/x86/test_mremap_vdso.c > index d53959e03593..c68077c56b22 100644 > --- a/tools/testing/selftests/x86/test_mremap_vdso.c > +++ b/tools/testing/selftests/x86/test_mremap_vdso.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -55,13 +56,50 @@ static int try_to_remap(void *vdso_addr, unsigned long size) > > } > > +#define VDSO_NAME "[vdso]" > +#define VMFLAGS "VmFlags:" > +#define MSEAL_FLAGS "sl" > +#define MAX_LINE_LEN 512 > + > +bool vdso_sealed(FILE *maps) > +{ > + char line[MAX_LINE_LEN]; > + bool has_vdso = false; > + > + while (fgets(line, sizeof(line), maps)) { > + if (strstr(line, VDSO_NAME)) > + has_vdso = true; > + > + if (has_vdso && !strncmp(line, VMFLAGS, strlen(VMFLAGS))) { > + if (strstr(line, MSEAL_FLAGS)) > + return true; > + > + return false; This only tests that any mapping after the vdso is sealed. There is a real parser for /proc/self/smaps in tools/testing/selftests/mm/vm_util.[ch], see check_vmflag_io(). > + } > + } > + > + return false; > +}