From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37B01C02198 for ; Wed, 12 Feb 2025 08:05:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B01786B00A3; Wed, 12 Feb 2025 03:05:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB0246B00A4; Wed, 12 Feb 2025 03:05:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92B4D6B00A5; Wed, 12 Feb 2025 03:05:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 74CF96B00A3 for ; Wed, 12 Feb 2025 03:05:35 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0295EC109E for ; Wed, 12 Feb 2025 08:05:34 +0000 (UTC) X-FDA: 83110558230.23.E77FB0B Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf12.hostedemail.com (Postfix) with ESMTP id B302F4000B for ; Wed, 12 Feb 2025 08:05:32 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf12.hostedemail.com: domain of gongruiqi1@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=gongruiqi1@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739347533; a=rsa-sha256; cv=none; b=x5Yh+NwU4ioR0Ay3JU7jrkjiYNJ4xXSG9ia8tmc20DTY2y6zB8/SDbbdCU/xQcybJdvVYg Zmoc6BkCtru726Ne2xDMx5DJldwGesrQFMxLGPTmFEC92U0i0sGgJr8FKsvMzWtYI1Ic+x 4P8IWBd5n0NDG+kXnICNoOeU3tdFCBA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf12.hostedemail.com: domain of gongruiqi1@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=gongruiqi1@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739347533; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=sYSxMNkQHpOrjZlJfuIwGtTPigiBwBGZk2YvMENskGc=; b=qBsN4GaysBB+I9VLz3SMP3Tw+SMwIpaNU9W/jcUUjWbIRO5N5jTOveyxojnf0oLN0zVlbG 5eKkV91ln6WAIbLwg3px0Nb6GQrADfmiXH16i8pxGLnNX7mpeQEOhxt3m/0hKIMEcO776L hGtdrsm9qGmQx2/WYJMY7Z+Cu/OJET0= Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Yt9k20gx9z1ltb7; Wed, 12 Feb 2025 16:01:14 +0800 (CST) Received: from kwepemg100016.china.huawei.com (unknown [7.202.181.57]) by mail.maildlp.com (Postfix) with ESMTPS id 9D753140383; Wed, 12 Feb 2025 16:04:59 +0800 (CST) Received: from huawei.com (10.67.174.33) by kwepemg100016.china.huawei.com (7.202.181.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 12 Feb 2025 16:04:58 +0800 From: GONG Ruiqi To: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Kees Cook CC: Tamas Koczka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Xiu Jianfeng , , , , Subject: [PATCH v3 0/2] Refine kmalloc caches randomization in kvmalloc Date: Wed, 12 Feb 2025 16:15:03 +0800 Message-ID: <20250212081505.2025320-1-gongruiqi1@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.174.33] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemg100016.china.huawei.com (7.202.181.57) X-Rspamd-Queue-Id: B302F4000B X-Stat-Signature: ktjhwmgfrij5tknnydczgrx4r5qgcqyq X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1739347532-543558 X-HE-Meta: U2FsdGVkX1/B4gT8py+SOL/H5vqPR3LWsPIR6zq5KH/veNKGR+087v4dUIUru7MP8rQ7uwTH2SYTmOVB2oHldR1cjzyfyWRaUNdBSb3dQotZhEQJx5BAQhXvWXWJanDTxeZJLIr7movwFV2tYcHfH2ihgQoZVnytc8Pkn7BpWZmq0b9JHaDy6+pNpo7MyeSO50AY9Nr0K6zqH40Mv+Duz9wth7uiEoURp4ngiQk3EMq72/Or90NVzPRnXnWQB2Xzr6XhUdrAIaD8VkBiFIYNl+KzuB0CArxSxbAVUjVmq33sRxz1pYI59TTw7GK3FZFgY8nma9TGUha1gukrzx7HrIR18ohFFaqRaZ+oD0c/UBSy6I5o9pozwWNo0grnaKjN+2GMloDwJ8or95dBfh5Gi5Pgmhiu1D5Oq5MEbUx8w0zES+77tHymePrAgm5EXikzwkIHxislQP42FcQmKWMgG5Gk1pInFoV9oePMqwUmr9GtkqtKs0B+8tpytVD8+r/rEl0LaQLyVdGZ0rfJ0KJue1Z3UahYbaBXQlKmQS1h4/rj8uL0Bx+AwyWTg9Aw+yacT2lnos4xxoXcs9jeDtaCzOMtFEE01WJPlBZsEQkIozdaFDmyQPsuhSfkrbQWC2asrk490oXol5mQDu8Lb5bMGISE8vE3bogUdmbMaaMNz7Ruxf+1kLW05XUXSRQ4IPTi0m7KBw17TkATjTAHHcOYbRAKfFmLBV2wQV+NCb6s3ejql0x9iaSUwbWIraQwxnLCBQCr8ZtP2N0tDfDXLW4BH4FXQWqH9Yc7MJ87Gh/l6sevQ2F/CYdNz3xnnurdU472pdBfc5W+UoVP2cEU5ej9IZntzpjz07BoHce8Ac6c9Uwl6iJ1TJecHISxjDklTB/7XzK2b+c+R2K1fVrjyEcVUpJ7xuSM3ukyd17U52SXxjyWf0pnNrpfWHKiWG12ypIcHTwBFxLUju7GoDtWeCA igSMaCYg YWTlPbJBEf6ZH60DWFMoJtpnmiTlYYtFbhKFP0hgZlq7RvHamk0wTN4oyUTqsn4ogNxd4PgJUqNy9YWowVovI1xKFJem8I4DgNU9NdGyHGZ+4HTyz/vXp3PE++HFCpY7XDvev2aq/iPndru6AqRZFQndShssDWNarelN6kL/L8uZd6AcgyHOOFpCS4YyKoXXVlLssbM9TYUHWd2AQJEeG78QquemHqLgRbSuSWyvAY/XUAiGuOfzvV8PWMMmTUiBHQ3oacOgXexuRtowSEplHGyi9XEoMOY6Uo8cdY61D+TNYoPw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, v3: - move all the way from kmalloc_gfp_adjust to kvrealloc_noprof into mm/slub.c - some rewording for commit logs v2: https://lore.kernel.org/all/20250208014723.1514049-1-gongruiqi1@huawei.com/ - change the implementation as Vlastimil suggested v1: https://lore.kernel.org/all/20250122074817.991060-1-gongruiqi1@huawei.com/ Tamás reported [1] that kmalloc cache randomization doesn't actually work for those kmalloc invoked via kvmalloc. For more details, see the commit log of patch 2. The current solution requires a direct call from __kvmalloc_node_noprof to __do_kmalloc_node, a static function in a different .c file. As suggested by Vlastimil [2], it's achieved by simply moving __kvmalloc_node_noprof from mm/util.c to mm/slub.c, together with some other functions of the same family. Link: https://github.com/google/security-research/blob/908d59b573960dc0b90adda6f16f7017aca08609/pocs/linux/kernelctf/CVE-2024-27397_mitigation/docs/exploit.md?plain=1#L259 [1] Link: https://lore.kernel.org/all/62044279-0c56-4185-97f7-7afac65ff449@suse.cz/ [2] GONG Ruiqi (2): slab: Adjust placement of __kvmalloc_node_noprof slab: Achieve better kmalloc caches randomization in kvmalloc mm/slub.c | 162 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ mm/util.c | 162 ------------------------------------------------------ 2 files changed, 162 insertions(+), 162 deletions(-) -- 2.25.1