From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09586C021A0 for ; Wed, 12 Feb 2025 00:55:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F2016B0082; Tue, 11 Feb 2025 19:55:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A2866B0083; Tue, 11 Feb 2025 19:55:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E85016B0085; Tue, 11 Feb 2025 19:55:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CA9B66B0082 for ; Tue, 11 Feb 2025 19:55:43 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7BE701A1151 for ; Wed, 12 Feb 2025 00:55:43 +0000 (UTC) X-FDA: 83109474966.02.5B3F1C4 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf30.hostedemail.com (Postfix) with ESMTP id 8D7028000D for ; Wed, 12 Feb 2025 00:55:41 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jo3lsxwY; spf=pass (imf30.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739321741; a=rsa-sha256; cv=none; b=UvBMmfm97e6BN5SiQ0dAetkyL+m7YGsY4NI7u2fMeRv4p3/bT8Zj6/pk0+K6njy+JtlWFw 8xEf24X2BxvjJRQs7xidrnuQKF8wrFEermVHcEkKKW/YVSwzF7tBcD33ZR4r/DZMVZxhBu yGFnbJ3tyCkw3vmf9WN91biewYzf5u8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jo3lsxwY; spf=pass (imf30.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739321741; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LNxJFO5KmTSBNEFtjF5BWdcZVarr+vtjfHVHmon3ow8=; b=e4ze4WIvcelw2BlbZXDHckgut68grjxndu10qQUW05+sZE1ONtVC1pk5dg3XRuIXfxoawn G136X3FaohpW0V72Vpc346+cU3pJzx1PW8e8Rhp9V863Ug7+8KsD/DHKYEkqbfzl7bkSmq 5lI9i0dKBcspxdSa0Buv1GtYhK/nC2c= Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5dea50ee572so1828025a12.1 for ; Tue, 11 Feb 2025 16:55:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739321740; x=1739926540; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=LNxJFO5KmTSBNEFtjF5BWdcZVarr+vtjfHVHmon3ow8=; b=jo3lsxwYHC44+YLHZjXL+w4Lz9HtiCQMCItW3j9Edp6gtPiDVvDTwuA41skuRhRkF1 N0QB/OsvdSWsRtn4ba3ijJFJKP/lDEaeViw2RJfpYIJLyFywXTZS0r4TkCuy8gA2N8gb 8JT0GbQOMb4fC5sJEu/P3RPXSauRnfB4ruDVleKx8xZWkE3WgbXGq0fKX5I6CddFCR4w uXBsciUfypJtI0/ADOkFACEaugEpKyMkL4T33+PpOPrwT+xVWMXZqMjk3UKCW1TTHJDa UlR4VnL3rFOSYtpZPceSpL3598J5XrOQLVHgkwVewhanxn1nzOtOBBUrN3qpvxb2YQxn gewg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739321740; x=1739926540; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=LNxJFO5KmTSBNEFtjF5BWdcZVarr+vtjfHVHmon3ow8=; b=gPsXERJ3RyE3pyvdZZK993keUGjTHji4y+GhvAd6jjF45EpzQbDJ4EFU2ot35ntIzI qy01j3wL/nFiFMORCXA4ZV183wAccdtNmwVRLPJEhCeCWxz6uaTsuU9oiPijgoMIQtuL NzWFyOg9hQsn/RhKGzR5RYRnr6PvcG2lhPRZCOyohy4yzcSbP3X0YJsuMtsi5qPTcDpG MUfiXQ87s7wg0dEeld50b53aJC8DdR8L7PN5V1aMuZU56WvyI/RYbH39NXTYpY0gFteq CgxVHO4YjEcfudQzfzzAAAMLPkzTBejVD8yHZwI3T7SwIWpeTqkRwnHb8Yd0CkHNez8v kiIA== X-Forwarded-Encrypted: i=1; AJvYcCXxSH00ecIVAG/72MJ2/Qew8Hf7nW8v11AqMRvA0qXcVb0WCOdfsWnXX47TdBMxaU6HTuvGVoGSZA==@kvack.org X-Gm-Message-State: AOJu0YxTRdzmWeFLGD+lF0ovIEqWWQrxWKkPgmb8rnPS9YATZi9jCs10 3paPn83mfp215HVfWePZDuemeW1yLUT0s1KsNadOHYmpIlD37cNf X-Gm-Gg: ASbGncueb8Wsku/e2Idkivsb6FYpIMb2R6RheanUaLE2KerxHUjOUMoywN3R9zjDHH3 ygJwPVwy5iZ6Ysw7OSoHHJd64k0Yc38zwYp/iLWkDnHHBhR0+BBXWmNJvazkRTT+/u882TgGOqw b1eiRqapgaMeFGmrt4EmIZfwkwtryW3goGpP6NRmBoOcxBIgN1vDQboaoiMEl74RAEnuAzc55HD ORU85H07WO0FC2T3RbqgItoh6qm8otaPkBhhSZPetkWtsQ5Gf9pUKshR1+THsx99nv5vo3Xs96c 8bd7kqYwVpU+Pto= X-Google-Smtp-Source: AGHT+IHpbNjQE2Hhgo6EulZt1YZaVwEz2sJ3Odd6+qErBzAVl1aiLn8NW0zLDUZwAPv6QDQBOSnUtA== X-Received: by 2002:a05:6402:34cf:b0:5dc:d34f:a315 with SMTP id 4fb4d7f45d1cf-5deadda8b44mr1062207a12.15.1739321739977; Tue, 11 Feb 2025 16:55:39 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5de58404347sm8021609a12.9.2025.02.11.16.55.37 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Feb 2025 16:55:38 -0800 (PST) Date: Wed, 12 Feb 2025 00:55:36 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 0/3] may miss to set node dead on destroy Message-ID: <20250212005536.6j4shtwswsyaapwm@master> Reply-To: Wei Yang References: <20250208011852.31434-1-richard.weiyang@gmail.com> <20250211081129.xskl56wm2dir2x2f@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: 7ouskh9ocq4n6ieue6ytawo6619gs9ed X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8D7028000D X-Rspam-User: X-HE-Tag: 1739321741-136173 X-HE-Meta: U2FsdGVkX1+TmPyTr55PTC2JlItj4nK4QnC18MHmyb8m/HGMIMp563tiRS5A5ZxAInpez44+sLUvPOLbvICJeTr8Smk4F4R8IW3mMgvmK4HGqzepvTfGhNFnCUofV0stitn3UJNO62+AFUvVQZeo8r6EJ06DC3RkIE9veAE97vjqS+/dKBhO7pJ7y2XYtGvd8LE48CmiYAxK4XLDZr+9YLEweUoOpGKh585ppnUzjzuQFdZvpjyJSQMWJlFrFvZQAFnEYuLPYHS2fh/WE6y+xwR9ZeMmGRPwS9mP2Dn08jHkhOk8R7RTBuxhGoSBGea90LcA67eoaab6fV+ZwaF/OAAqC8L//FH9CF0+vLrC1/KB2EVQfHXw6l0VcFBZifYLSSnbfIoj555L+AOZly2BMAlK43csxMiWkFGYDYeAUi9jQ9Ps0fU+aBokVVuMdbY0gbk1DZL+Wdxsk+csPgC2OWZ++otMqV3Nuk9uQyOKjE7KhhjVIlD9hKnHEjNfUVtXQBszq38WTEYmceoVrcQM/ddYJC29mBNtT9AcXRR3FBQaJeVoTeUDgtICnn4nSfAZi8mpd+uJngxp1oEFZi9KqeWATsZQl1F9LE3zj2YZ65iFbDmBGboF+yxyj77qJzaacyZkN5/QRMxhnxZ7HyGtRS4WJrOTmKzsgTja3X3wuzdpOTZ6azbPSqu/nXhb5zjw206kC6jNA6T/w0u7eES9b32MNrt5SPLXHlYNTdIvDWI3Xz1H5+6QGQYz6dzizZFphk0nHFOn8IIjZZgbwg5gk+e/wmFAJP65+CvG7qDSHx9qxw0CfR24rZAaC+479mpGsCtXkOOtKnxeHlYc3CHhNEHjkuFRFG+BEApRig7jE5uIke4bwyo1t8PPyeT9phftyZf+6uK4n/62ofivYKtEVzt3jb6YCYN88IF96bIYMsWf1bE4j5Pjx0uExYrmEM7mTUI4N08wNBh39/s/IMO FxVD4/uC KSa/kA5DX79NSUC+3S4vkHaMe8piw6OaoYrnaNuiPdx+clj3pxLIJELw3aUc4S3LQGfxDO99xKpSVhus0RRp9gqipyby48qyEGizW+VKUhn5Jh41wXT5u+eaeC3V2HJUALsOinXaHYiKKF5M2RbsJuxgtWrlC4cgI/XfJOweMgsOYk0kd5CVFQuHWoElz3qA3/sAmCVbmgYeAN8Jm/fsywpV4B7Yi72hN3D7Vu30E++bAU6KCFhsxdLpg0bdnr5UbHmsU6icqILmPM0YZbD1SOtbJ1eWFjtJ9ORW6OpfLWA7dJC2ebceegbde03SMMbc9H9JdAJL3oxgTqWUkY46dfIR7tU+3uDnc7hMQs8LqfTOjNKvqBAOLs160Zh3Phg5VbGjPu80C3fK5E+byis04hKZEQ4LbQk5t5bfbi+/uSKu+nE1ve2xNaBBn3gE/64ZdggQ/2M3E9aoRR7ov/jIUt9S+kmvVqhI8P2X1yXXbCAAJSkdlTqwED9JY56wBmXuu8iP7vqP2Ci/sXsRp3o3VEIVbGuyeMSOQLLV6FNiA1cPEnS2CfwPPbGMqKz91VsMd6swFTrYJkUQR5mCiUCytIfwIPUgrFj/KxJXXlS4Rs9wPhD8wrng8ArOsP9VeZRexuSE46GAl228KJeOFzC4g1DbsgMw+eAYwFnhdaZTMcRKN+L8qEgxiXXE3nRUka4PopV1U X-Bogosity: Ham, tests=bogofilter, spamicity=0.001227, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 11, 2025 at 10:28:53AM -0500, Liam R. Howlett wrote: >* Wei Yang [250211 03:11]: >> On Mon, Feb 10, 2025 at 09:31:28AM -0500, Liam R. Howlett wrote: >> >* Wei Yang [250207 20:26]: >> > >> >The subject of this patch set makes the issue sound much more sever than >> >it is. It currently sounds like a memory leak or a UAF, which isn't the >> >case. >> > >> >> Not intend to exaggerate the impact. >> >> Is this one would be better? >> >> maple_tree: make sure each node is dead on destroy > >Not really, you are fixing two nodes, one isn't even to do with the >destry/dead node. You are also not making sure each node is dead, but >fixing an issue with the leaf node. > >maple_tree: Fix the replacement of a root leaf node ? > One more question, would it be better to use this as the subject of patch 1? -- Wei Yang Help you, Help me