From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DC8AC0219B for ; Wed, 12 Feb 2025 00:49:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C39876B0082; Tue, 11 Feb 2025 19:49:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BC1BF6B0083; Tue, 11 Feb 2025 19:49:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3BBC6B0085; Tue, 11 Feb 2025 19:49:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7F5336B0082 for ; Tue, 11 Feb 2025 19:49:39 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4735DB1E94 for ; Wed, 12 Feb 2025 00:49:39 +0000 (UTC) X-FDA: 83109459678.03.0AC91CF Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf05.hostedemail.com (Postfix) with ESMTP id 5B040100008 for ; Wed, 12 Feb 2025 00:49:37 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Nt1zmoHx; spf=pass (imf05.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739321377; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VD7p4w7czhyd3FOPiHdPtAS8U4RweVU3zLDyvDCZVHA=; b=Sqi5kPTobc0tR1bNGCgYtcfC0B6Ot+vaXMaDu8GZlgO9dvRbpMnx+iOEElX4iwGDssyLmb 5qrpHY1Bl4wGYDP6Du3EgXlq3pjn2JpJQrbTwS6tbNAdnR8ge1Ugy4UbqtaoF1epGYAzll jznnUHQYjGoSSY3BR1owC7peTNOWldA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Nt1zmoHx; spf=pass (imf05.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739321377; a=rsa-sha256; cv=none; b=hbhUcfUxZoeozaBjGgepQ7DgAxPlz1hLXWe5JoN6xPRUSCFpNGTvD4MORsHLWLtMZvQVmv 74c1RcZwxUuYP6Djm3eUlnc/lbjisG/AXjBB3AFJDxpIyINqFGqYZhc/kjQH3jtAeygilq NvclbgtlkncOcoLQG47kKtjioLqOq8c= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5de38c3d2acso9261135a12.1 for ; Tue, 11 Feb 2025 16:49:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739321376; x=1739926176; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=VD7p4w7czhyd3FOPiHdPtAS8U4RweVU3zLDyvDCZVHA=; b=Nt1zmoHxNMW6x5wk3FaepvcDLR1w8Wr032MlvxMtSQxlVBU2PI/saSB+qNQMqWKkyi kfL1vrOqY8ZdqXeFembUIZs6ZUbjqlCWoiDIF7iPsC8XUGm4pvbZwqlDhJAflfDYY1jF caKhei6wVHuLT9tFz74QV9ZMRJmOLbrQ7tQV7wgKG490hamEBrtt3XCl16V4AKb43MuI kqUX7Ju18SXKDfChlW0uP1U5xaYBsN0cUsVayh5hH4F1nlUibcbRcjxebwFlKAbMqy21 kqfHaFbfg6+z/lwabA18Y7N0Vqk3SvwMp4CaSqH7iyfMvyZNaxXKPAseTsYtDCI22QAx p+WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739321376; x=1739926176; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=VD7p4w7czhyd3FOPiHdPtAS8U4RweVU3zLDyvDCZVHA=; b=MEnTHM4LA867PrXgZyIOcfYIdN6jEC+Cmh45NTn7QWkLR8uFQi3mMR4Es3Uh/64cdG N/Q2WSAFNolUvh/mkKuvX/50DzIMMdvxv5zMKZZ8aUQqaXzalLYV2sYiJayeVL3TgNEe Tp5vKfTLVteAS8qypFFoE9uHG28tbYNAvoJwuK3AzKemhpYRvFbgKjmYciqao9MYAXde 45UIhilvrhsE6Cu+wfS9kT8FDZx/CtkoiGfIazn3rE9cAq7Epgdu+epsRcYdr/AOfUqV G76FHBjkXWt84WdSjWG7mXhiH14zbnCo4MutrRgvYdW0TW5zDZmEFoBQ1MrCQ3lyEbE+ ecGg== X-Forwarded-Encrypted: i=1; AJvYcCUhX5prH9g11hnXWBDTMs6vim77MUEA943loeek9GJRVTrXWcCSA52AsvVLl/8jeJf6he+5GaA5Qg==@kvack.org X-Gm-Message-State: AOJu0YwqgqjYNOCrY8/rtrHTeemy1xCQx+fClwZeHad26IqXcBXH4Pi/ PE6Eqo4s9VdQJHDIeYysDM99JhyfmachHCpzEyDUh7cUaZ/I7d/q X-Gm-Gg: ASbGnct/BdxFPE2+q3MCgfRldORH0vjxJO9zI/BeCGStvwSA368Sz6aC0fe5THodxC6 HC2jEb85CjGdVjfaDYE6b38rUvVlRWfFy4WfwFxbHsc/5TASJOLArOEk3989WXXZA5X3nu8MXkL DWpLg4FiJF39ALSGnC2BYPvAWPL1xHhbPEUAmF0yDXP2usOZw4r8irM/KOM7tXnOcPGguqMtc7U SR0Jp8v72ebrNpEVEvY46C/IOKKgWI8TsPdp7CGA4wh+6fc3PdgafVu4DSrHL4Ls4pugjWNN0We 8qmBDnA1/FYbJUU= X-Google-Smtp-Source: AGHT+IFvEa1yzSrZNH9t8bqrNLUU4Ioh5/xeOfGsrRuIlbNXZUS5FYp0PixFowNSxlYp4xjFAPrpgA== X-Received: by 2002:a17:907:3f8d:b0:ab7:dc1d:7d7d with SMTP id a640c23a62f3a-ab7f33c578dmr77984766b.25.1739321375754; Tue, 11 Feb 2025 16:49:35 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab78e561ba0sm982946866b.137.2025.02.11.16.49.32 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Feb 2025 16:49:34 -0800 (PST) Date: Wed, 12 Feb 2025 00:49:32 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 0/3] may miss to set node dead on destroy Message-ID: <20250212004932.oepp3twen6wvaqtm@master> Reply-To: Wei Yang References: <20250208011852.31434-1-richard.weiyang@gmail.com> <20250211081129.xskl56wm2dir2x2f@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: 5B040100008 X-Stat-Signature: o4sdfu566dbmar1cjdjc8p8onbqfsnxu X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1739321377-488992 X-HE-Meta: U2FsdGVkX1/Z3jOOMa1kjTmLoAm3XQENsuydqfg4cxxz12xjCvKPAaOoTxweGCAMsu3izNNHk2nZ2I/kF9yMlNK1zrcgRC5o2VDntvahtplYUDBlT9Be9mlUCscte1DB/D/vTwdLAgVCvqAjO5TgtK7cPou71e5d/3/hfz0AHjaW3EJi+HuSZdiTUMhfVB6JYJzzVZTABzbCGCFcUbV2WTmpOYzDWDNLO6ivAFaGYBK1kNATY8Im5iEkCSHTJRR+uVqHJS3eCd8M4Y3WbLbXa2XkzbjFgJN2mEDkKmM5ZG18BCg8o758mi491hAuiujCBErdUeQHqx0E7dTgdnz87p5fyekKgp81PSfIHbWpjmggJZCcgFK19LQQcQkXyIOZoz71cfYcK9TmsGcbzsmqKPWYVEeTcouEX4SkdX1vOU3jLwhq8VWGCKr2riAH688ql/1u11BBGgv7p1GMe39RxcSQB/Yfmij7xj5AFRDHLIZgeIfG2yHatuqyCjWu7TcqdLesih1zHH1v5Eb1vCWk90bzRTncvji33PB9KiredawgmoWSsgs/bE1EE+B9RBBWAaWwoK/NHM6c/Tnm6ycwsc1THewigyb5LcFVhXYTgfYW5iwu8hybIA3rNspWAGlPen2WkTbUR7yMMgvK1iXtm+0Atw4ItoATmPYm3pUV4/A8htC9mYLeyJDL64s9lwzI0GfM/pK4KhPBR6JEHmiP9l/nLGHlQVQy4M4cPGmkDE5LsBk0u88d0XlwFBq4MLYtDlINnfpGQMHtOc6dqQbD46XLBLQnMMziBgdx5v1xDP+YPBe3UUjlfyb3uPiwFKP6rTJ/qS/0A3FoXDYVHtN5psyjT7u1VREyG1GsmgfgqJgPY2x2/OZfupDAacCkWkdu0+zNoG9zJvHe97KMBheUvt5Yb2cy4q0LOB42qPqGkdVJ+ShG2C5Pm+k98parO1G1fFVBZzMx+GmL7dnQzjn f51Q7VIE TgZNwCYagjO3sOPp0oSbAeL2dgj6G7Ak46xT5Rp9ASy2PbZtpQF8QB7J1+oqPOf4W3bsA+M+LKGrHQ3A8ISc6hnIR2ji6HZZsPQ22vvWCordwJWW/NU5ELXAkw6MiGwxHNwMmZWzqeHaLA9GomhXsDnmi8tRXz/IP6XUL1yg9h6nfMnUFunn0DYnfzzgBWAB0TwKbDhonSxeK6n1gUa/RrXW+EYRuMIRC/bOBZ6K89jC2nzkUbudNYJLIC4Q+cbhyfpt0T9yN40b7BnLSJdujmS0RUCWVzDb5NSjtFm2c9FCrbPIaWA4RoyH2ptt+IAsdhEZlRrClCUIokSkPlkZbrDmHk3t1pDBjLtfCujjA56rP2iCRIM/dBcZ5vizxfZms3ILAQd4j06GaqiPkFrHVAGZNgwIMS/b2YJbIoGEGhsAETB6ICVYbNB8E8HIPyJoypAmWFJnq/t7kJKRSJ/Ha6YjWcscYcyoHsFXIvvjVY/MruKBlfU8KDWeOU7bu/td+D5yiWAHPrI1rnES2ZBQPTme2M/TvcORKVsZjNOjWSRo1oz9dNWgLmGiEWVZZ5r/VfS+Iyb8ZchcNx7Y28B4ivCExQwtkgGfSPHsz1V9L8xEfWntsjUdl58iYL4zOhx5IwAlk3HMurBnZCsW8+sf5VuLWVBNZSpua2gLR X-Bogosity: Ham, tests=bogofilter, spamicity=0.204227, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 11, 2025 at 10:28:53AM -0500, Liam R. Howlett wrote: >* Wei Yang [250211 03:11]: >> On Mon, Feb 10, 2025 at 09:31:28AM -0500, Liam R. Howlett wrote: >> >* Wei Yang [250207 20:26]: >> > >> >The subject of this patch set makes the issue sound much more sever than >> >it is. It currently sounds like a memory leak or a UAF, which isn't the >> >case. >> > >> >> Not intend to exaggerate the impact. >> >> Is this one would be better? >> >> maple_tree: make sure each node is dead on destroy > >Not really, you are fixing two nodes, one isn't even to do with the >destry/dead node. You are also not making sure each node is dead, but >fixing an issue with the leaf node. > >maple_tree: Fix the replacement of a root leaf node ? > Thanks, it looks more precise. BTW, after addressing your current comments, could I send a v2? -- Wei Yang Help you, Help me