From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE22CC0219B for ; Wed, 12 Feb 2025 00:46:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DFCC6B0082; Tue, 11 Feb 2025 19:46:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 68F786B0083; Tue, 11 Feb 2025 19:46:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57ECC6B0085; Tue, 11 Feb 2025 19:46:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 39F7F6B0082 for ; Tue, 11 Feb 2025 19:46:23 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D2685C116E for ; Wed, 12 Feb 2025 00:46:22 +0000 (UTC) X-FDA: 83109451404.26.3B0201D Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf23.hostedemail.com (Postfix) with ESMTP id CECB114000F for ; Wed, 12 Feb 2025 00:46:20 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DopXYlbH; spf=pass (imf23.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739321180; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ix5D4G8t7iYFTn0RFqNEgffYvh1QHoUh9SMXDLkQaio=; b=eq8qqXOuZ9ypiv9A+xmDs/RUcmzATgd2EKNxo/+5uVCY76zllNA0dTI3c3rGLoHUbUyiWS 7WsLRvZ8AXgtJEUgwwbdTQiJmiAQ21uGBuRr2sMYdILrWJ73O1ax/pJDNX6ApIuP+tfgb5 zdkvFH0gbs1XiUlC8hxhZosbj600lVo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DopXYlbH; spf=pass (imf23.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739321180; a=rsa-sha256; cv=none; b=G8fQM57ugNjNQ2goQVt2VuZLAKU6T+zm+7pgZuaZVdhrnOaE8ju+NmF7kKv8aT23WZTgFB cqmsEJaVY2Pwft7EpJxuIOzPTwrff/yJHN4bt9py9ZMolkU8vHJ/IXa1hpteO6+jACU0E8 0E1/wPtdIdQQBjU97MEvkkzOmnb8jDE= Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5de56ff9851so7968729a12.2 for ; Tue, 11 Feb 2025 16:46:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739321179; x=1739925979; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Ix5D4G8t7iYFTn0RFqNEgffYvh1QHoUh9SMXDLkQaio=; b=DopXYlbHLF+PQzMJyqz9oYt2qXVe7CJ02LAe/dBkEhzeMvsO1bgYwVj3VruqOcR+wx h55xYJmflsl6KEAd975OiOeVRZuFfDHoNikMf0n3N1y1WVvKH+4RKhGKUMcWopAjJUTw UflSaw1MIbrU6pog3FR3GfyX05UCVmtZ14sI9yycY6S7vG2oWg5GswfQg0Lka1iu7jYE LZF9DKxnk/UHuSicoi75wILXnsX2U0GEaSFr780b55kkL2Lo6qrT0+bXlaxEgDdbZRlH sxEpICbT9z1RGQUBFZAClXxr/MYuCxtIoAz6Klj9HQOFphFrL6TcHir0sQMjqYUkiPQg ZTjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739321179; x=1739925979; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ix5D4G8t7iYFTn0RFqNEgffYvh1QHoUh9SMXDLkQaio=; b=t0vTfv6gTGOq7pABG/nVNxRHMaJPp02IzkrA7uWnFGbqOMJLNGTx0uSs901f8tDvI2 Ft4Db5Gh5kEmu68rIbl30dwrQ4kcRhMotthl4HyBdARurwCW/8WiqcOXJWZqrUn7cTLl Mx0Zs00PXrOKa8qR4FRtdZZdJUigoID4s8/BLGYNS3cbkmdCiacFCpArDBEQ34s21jjc jDKLTrKWpR1DBDK7x0W8yTx/GocnE1ZNWhrsBS61IAJFoPgPHWjM+mteg6eF6mavpXHY rK13r0/1lc4lYgNVjwZAfvMB7dOBkbw3LdEkFJME4GGUlb2WwEWhTeM/NTgVhplWJm5r TcOA== X-Forwarded-Encrypted: i=1; AJvYcCWShMDrUrY6V6+jI+NIwtcKFbSP2YM7IMiXaYtYVfYhN8tabOyOeKk+f3I9QYTPhkjYvW2/lMwmzw==@kvack.org X-Gm-Message-State: AOJu0Yz3LCVHbKrCCw1pCLuXIkMAQ3Zr0XOdSjwDgzTiUTNUHcKiAYFJ Mj5cijVpcjzPxZCZBjTL+VCcW9E8uP+nm9oSNjy2WJLEMt0FJfbq X-Gm-Gg: ASbGncszGSwMqE0CS8y5QbUWixajMce7sTUilfbrhR5yfKOZBkbyibhOH/Yy+dugXvk fevuAVDM19aAel4CZ1s6gslCZvhjQKNnG5lgGg+lo17e7Cwer49ZxfuSi0KrtWgsGfTen/7GbPJ 3yQCMWejXycTm2pdwAmCMkCIR9eKzKdbl+UHOPxPsjULun8qrbT3L40TyAVqkBCkiCzCd2qYN9s wcDggZmPJJycJEtCUMbGOmXIrcb+jCdttf1vnSoAZpc914kJ2OF6O9fx9AXN8PB3crCChpnIm64 psA5rkRaOhBinHI= X-Google-Smtp-Source: AGHT+IFd9fUuPqVAQa9mTZXhOpfr7hIeEFMAy2pYNMYQqmL9ZVmgAN40Ri7SqGoWSjTqZNVoBV7rlA== X-Received: by 2002:a17:907:2ce1:b0:ab7:be81:892a with SMTP id a640c23a62f3a-ab7f3714cf7mr70576066b.12.1739321179244; Tue, 11 Feb 2025 16:46:19 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7ce2e91e9sm378841266b.117.2025.02.11.16.46.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Feb 2025 16:46:17 -0800 (PST) Date: Wed, 12 Feb 2025 00:46:16 +0000 From: Wei Yang To: David Hildenbrand Cc: Wei Yang , rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/mm_init.c: only align start of ZONE_MOVALBE on nodes with memory Message-ID: <20250212004616.rjlip4jm7bltbtu5@master> Reply-To: Wei Yang References: <20250211082900.10877-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: CECB114000F X-Stat-Signature: 5sxcymo5ufu9b3un13w9ryipy8hraoxg X-HE-Tag: 1739321180-758856 X-HE-Meta: U2FsdGVkX1/ayFPiBES1cTrv9UpSbQbFR1uXP45iEZjXuNGqvx5ZrCgEGUAk+gvTh4991I4ce3ZxBDU6qw6L+JUeDAsmAUhtuJVvCnR7MEQEsdr8cydgzumVQlgleb7q0PDZA0Nm5UgWLQGEX3gM9ylZRwOYTTZ7VkE52/WK3xgwejlV5Ob/QRBfJ7uX+QwG2yMOLKF+leEa3DgVeQBACLiF9ZPhg6v1P8jO9A3tlDQ+B7/n1YpN1p52aR2AvzEDxu9ZDNY2WA2mYD/7kKRBHfNXOu5sah4NOjPJYqD8fyYXyJ80zhXUGvMH5WWfTfkis1ym1kX2HBNap/foktVRoAqYGzVnGQuXWvcK8xH5PpYQkHGWJiFK/zTBRWaA1Gh62BXg9Ib7YjYaL0hfkcJPAviAm9f/DPDVDyRJkpareA1AWK+zBwYvS/sjWhDvB2Qe7BTmB0wqNuAb/MGOxhiRZWvveeAhzxuoU5EkTrhqU2dzWMtRWTPdXEDnfunfDfDnYjeGL7ZHtBShvtxk0M1eA5jYrgIEu4WLwb44docAbR/xHdOjIz/IjCHthTY0ov1AvluJUgik3W4eH3nx3S1fzPl75n2spmwYMItcwi5DrH58IuYquKY0BdGQMIlLdrRdGs5BdjYkpRQ2s74GZjj+ZjYvWiaeuLkFvTJcaSaZZE3UAewdjy8VP0KrdTmIrwwR/Zf/xz8ybiD1mKTzoYb9jjyz1Pzn6Tir97hq1Y6VlGFFplQGKDiYmFXQ/Rl7Y89wNd+cOJFhzVHKvmOk+JuQ+fapQbxwwXI/1sWQK1H/mlJlsF0J25RRTgQQwn4ES/L2EK6VPYzofUrAZVAvQKPs+4XYHVMRC41pRdfmUzwg1xvGMmflLPi9UETjrX3PGWPYlXRqEb0bef+JAm6jVmwSCF4IrSbX/oui+V2OeCkzROhyzhXASaGW36dbGhAK2uMR4orebq5EIgv0DcGmEKl 7Nvp5XTh ZNs4vGyHrOSK6yCCOTd9zxzb3140t6C/qZHnXQe4H4XSQKYx0OD7cvueCzaEtVsYUIO7pz+QY88Edzx+YuAbRsqwYwd7LVoLngC+pFZPHhOGhCxMUCIGLqAmrn6pfADzhHvAYWJSICY1ag7RK+/Gl9ufkuzwX/rb+C8lutHx2tAheUWH/KsuY2tmCe2kc22Mno0JHBveInTZ5LnoLq1E5XgYZSHBuH1wUaeCpx0HhlBvAY6Rcb9cCWUvniMyEJmAIWS69OhKdyvWlvEd77KmtjIuRNR5dwYipbCvWzW8PZhi3I9YpBXvjjfSx6RuHAqt2CT/kf8CxFeuCBAGVqyJhAtYnC9LE8JmzB4g3z/svE/O9zLqT/J6A3LACLM9wfIBT4T0X0DgJB1WkWDFdAfP9w2PmM0It2e4c3wCgmGZ+PueY3azwNrVOvSLpn6TKCXLnxbR17EdLI2VTwJ1xMIypaiS1ODrSuX5sI0MHpv6EAGHdYoAyMn7oARyCLdE9MKHqoRAkfJ7CXFiSUPLdabDVXPSG1Iigq33NwbVhojICKXI0J3ma6dvFQZDXoLqwOA3cyhwYZe/Tzko1ofPEFzoDG5HNK/iz2ZCFpyYCnhfUbZkEIGdnKfZd0qA1QP4gjau5Nhja7ylBuqyQ7RCge5LANA1dZvbnt/UlIRv0VNTPradP4eQNmkDGajQktkAnk1Y95D2GcwhcStcNlbnw2V/R4ILqgq2GgAgu8mEhsRTfMkCH0vcBVRODoYeNXv6OlLAi5vPc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 11, 2025 at 04:26:26PM +0100, David Hildenbrand wrote: >On 11.02.25 09:29, Wei Yang wrote: >> At the beginning of find_zone_movable_pfns_for_nodes(), it has properly >> set node_states[N_MEMORY] in early_calculate_totalpages(). >> >> Instead of iterate on all possible nodes, we can just do the alignment >> on nodes with memory. >> >> Signed-off-by: Wei Yang >> --- >> mm/mm_init.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/mm_init.c b/mm/mm_init.c >> index 35754a8ae6c0..3ec50b5fda12 100644 >> --- a/mm/mm_init.c >> +++ b/mm/mm_init.c >> @@ -547,7 +547,7 @@ static void __init find_zone_movable_pfns_for_nodes(void) >> out2: >> /* Align start of ZONE_MOVABLE on all nids to MAX_ORDER_NR_PAGES */ >> - for (nid = 0; nid < MAX_NUMNODES; nid++) { >> + for_each_node_state(nid, N_MEMORY) { >> unsigned long start_pfn, end_pfn; >> zone_movable_pfn[nid] = > >I think this should work > >Acked-by: David Hildenbrand > Thanks :-) >-- >Cheers, > >David / dhildenb -- Wei Yang Help you, Help me