From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41EB4C0219B for ; Wed, 12 Feb 2025 00:26:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC552280001; Tue, 11 Feb 2025 19:26:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A75026B0088; Tue, 11 Feb 2025 19:26:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93C89280001; Tue, 11 Feb 2025 19:26:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 756FC6B0085 for ; Tue, 11 Feb 2025 19:26:44 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3078816110A for ; Wed, 12 Feb 2025 00:26:44 +0000 (UTC) X-FDA: 83109401928.08.890C197 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf19.hostedemail.com (Postfix) with ESMTP id 298F71A000B for ; Wed, 12 Feb 2025 00:26:41 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=l7VnD95X; spf=pass (imf19.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739320002; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cDi9b8nXfOgLC4OZ8uFrFGTWicCHZv9D3lGMNmGIIOQ=; b=OOX2WIUosuStJC7deyh1QZ1JU8Sg+9kg2Xt6boAgN8G16GCXecWSMwsc9ivBNVU8NJP2vH OulNejoD8jXEeUGQdTpIJ5lCcwqI6QAWTTsKrdSd4k4nuMTxZhNO9pS7H+yr3Z2dZovYxu ntBTEOA/8hA3j5jcRLvZmMMohUb+iGk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=l7VnD95X; spf=pass (imf19.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739320002; a=rsa-sha256; cv=none; b=rIPR0PTVfp04gLDWtEvSjc9IWhvkghkqxnKoeustt1RywpVQtGkiQNPIF4U7RvRVre1jao BDUMZK5TtIVG+pjD0i50rW8HRK5A+ak1ZDabBOYxAc7qzL0BEBltG6EbHIzCPBVxSKQpGX Pxs179XN4yeS6y5n9cmfA0irAevzQsY= Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-ab7ca64da5dso59043966b.0 for ; Tue, 11 Feb 2025 16:26:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739320001; x=1739924801; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=cDi9b8nXfOgLC4OZ8uFrFGTWicCHZv9D3lGMNmGIIOQ=; b=l7VnD95XEOd1EZvVb6gC6TioDOjTMe8aBi3QUaPUSzTwUF7GDxCZqMVbIsaCylbNMg hQ5pKaa7mpVDPoV8UQiqSAgciCJ6fKrbnma31JoMwCH6ra16faWjqi7NFVg/wSIwY8lC 27MT2/yjTcQGUrlz4ggrxF8fUl/bjXyFbazbtlSvV727GHym97n7/UVBXE7NHv16KsJc nQ8S1xwnEoS6dUPMVdOOuG/j6+A9jZyrPou4p8xDhPsyuWaX6njSjB6IGNckmn+36rdu dTZlLn1P08oKSn/2E2hTFSxg8ZsoSsCAvmD2jZvxhbHowuqBAo6K/LAVi42FlWXbBpke K+6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739320001; x=1739924801; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=cDi9b8nXfOgLC4OZ8uFrFGTWicCHZv9D3lGMNmGIIOQ=; b=L4cdzf8NEPIFU1bsjKPPDaOiuGRA6WCDq/7Miz+uIBeCpoZc4/9p5L1WKBAN0/mPe3 6SNcsfSgIDOIcZdc8EmbenW31E3top3Sx4VLJnOh6lgEKRwZEsNBEyJNomAJQDgwG5HY SUW0M9bcPZBP9SxoEsRdRfzrOpPO4G1zBgEU6Bv5uxKTPJczVt1zL/Elf5rbqlAp6it0 15nSceZckJ/qL+o1yr8c0VQf6unEvrygYlU3ADy1npezPqzsOg88UT52L3zyBkuQXkJi vCI6rjd/MV5fuxfmvcouFlVVUZBwAv6pQIu/9Ni+gJMzR/WtMwRRZZMFeBh1vzknSH6U KJbw== X-Forwarded-Encrypted: i=1; AJvYcCX7Vg451p6Axv3gug34WWlnYiSezVLnSeYYLQkytbgeg0rHlMrKejR8rWJhHSMkFijSA2H8dN6VeQ==@kvack.org X-Gm-Message-State: AOJu0Yze7fiCn8sThaYvgs5UomSMGBMTgebsz/+eiI0i2/gajk8wRcpO Dfw5O0IkzYt4ha75qvGOCqrrFu7clXN/8Ln1G3oPCdlcGGBCSa4J X-Gm-Gg: ASbGncvIstIlb/8/z+b3Z6xAoy2q/+qck66kwZ1Huo6E4gzaOkIh6JCyE9XkhkvbufT LvY3SZZm94Ilo+9E3aKa7ySGrPpkxemqHIGuVuvXmTFK+yxRTXHB1X/1gdRe9xueilp+jbGaX6c CGjNBMo6RJoPS+rQFeeTQdJxlkMte5HKHx6duaTC7YWcEPcsRpXv1sjM3kqFiURl829Skvrctb1 ACRpdXco2cRZHLiXVVY9vFhuj/5RAiDQ98Bo+1az7phuv98An4VEf+kWd2Rai7uFCy0HcERqJv4 MdfP5jNdaN9+ZeA= X-Google-Smtp-Source: AGHT+IEjSlp61Q6LQWyzaFOEGsjnlMCh/lUAcmzkLtMwEKIPuAbfFSjW71fS0ETLPZ9zmVLwo52EiA== X-Received: by 2002:a17:907:2d8a:b0:ab7:cf7c:f9ed with SMTP id a640c23a62f3a-ab7db5a5addmr412852166b.24.1739320000406; Tue, 11 Feb 2025 16:26:40 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5de5ef7029asm7229761a12.58.2025.02.11.16.26.38 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Feb 2025 16:26:39 -0800 (PST) Date: Wed, 12 Feb 2025 00:26:38 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [PATCH 1/3] maple_tree: may miss to set node dead on destroy Message-ID: <20250212002638.m5bp2qxo4rhrqkij@master> Reply-To: Wei Yang References: <20250208011852.31434-1-richard.weiyang@gmail.com> <20250208011852.31434-2-richard.weiyang@gmail.com> <42meyihs3gnp3bbvn5o76tzh6h2txwquqdfur5yfpfu36gapha@rtb73qgdvfag> <20250211074821.uw43qk5mk2shrndk@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Queue-Id: 298F71A000B X-Stat-Signature: w4zkg5onssnmxjzxo9kky1pbofxqbprx X-Rspamd-Server: rspam03 X-HE-Tag: 1739320001-97609 X-HE-Meta: U2FsdGVkX1+qeA3NtCDucohb8o31okVStd+auKxImRmwIezKjyTkJBDOuMc0D9JlPccZbnHsUzihoBK7s22F432xsiFUReaAtuUkUrhAly7r2UDLArCalz0xbJoAAMq+doh3Ljzh2ZlgHUDPmEYZo/hZ8jIXBU1sKiVEQyZmtFwPtsRsf/M5WnyippFZ3a7udZ9WwC/dbL+ICZWiEuI9tk9ZHaDY+rqS6qbqBA4Y3NOHt0vfdXenAFR4UaHvwV/kCPTusib888HnJsjU+jUf11/4R+VMaZK1uhOTneFLoGUY2klMRwFuZQ5fMbL25CncKGJWmuYgN1X3W1zfl7ddy61s2mjN49YKFO4tbmit6QXUySiSAIsyLO/+y+7F74CIC/u1IBx3HRekXmWKGsU7Sq7pyb563Wdk+GS03hP/i2S8SOEN6A7BOP3BbGHmernTnNJfGb7A82DTUSUNTXTVjd2VEufxuARrzzgmJfBqSJU4JLjLgnZ3o08TnIOcNcPC/8WdRNC+Ft7zMXuMZt1TqTJPVTatVEFWNdD9aksF9Y0e7f5R0t+U9WZ4TDTDm8SEqBbCYq9D57ZjS9NyshvOSFvN1vVipMm5CVnpgBSzIGKx9ASR6T37v+2DF9DyBEVGQfcFFVfjOYMMD99pm4mM2ipMfRegVgkNFGrsNZaB4TngosHXvxUNDsoBMlhkVnkEbWoknDoSpLW0qHHtFNvL5x1zX+OtAgLV4jUk2bVZ6Y/xC3v0j/eion6pF5FxLZljmEeLykWKcj1E6wgDS7bAmi/Svv15z1ye4RTYDV1So5X7TpiIKjrFqtuS/Z9vTQpGqTjAKzWbynOxqGU8fb/Zl9N4UtzXpqPHgsYJKSuIUmUQS3s07ucSRd+dYRbptuPifAgKTaKhZ6fO0ZE9HEKuz5TnkRiYcVAVjiTRYfhxjeunmFWMVRSfXmmthGT1TyXK1tb6zUZzkAF01S7DqYT 7sJxW7Aa hBkByHPc0YhVVgq4KnyzDzPRI2KpHEI14+IJThMYjMuHdzO+6R+WD+ih3T6Nr3GeRNGGLnvgdAFuylH4ur4yTq71DsLTrRWLrcD4Rf9J0xwOiU9u+ehBp/M1qM0LgQdX4iHMmr9ZosucYn3lR6SwfraNvJfbrFbfKGE8UjzpiWOFk+2iTOfIn8BMohYdQXmYlLU47GdfV0OljUX0hg1O81r6hBSUWENCBi1BDWxaN9NUU7c9CkdBvymESHcbGm/Y2VcsQrxTG7h0+XeJTUC3a6r7qvtPxsCb43uJi4Y1MjB4GCNdXMzXgoz7i4u2Ue3EcURqwpWVCRCy4ifxL08XjjWMjczYLo3q7rxX9OqT4Ok4la64ly+4oGms0i0unnmQ6Zy1V0hIyM0dT1bDf5h9THHA5USL7NumXb83zui0zU8S0AOb60O6dYj6eoK/nfcZoEP8xRYes8NlW8m80hvy4P2J9R8qvCF9Ku2skpPKbV282oWd0Q7xwtohHmsZLivGsy+7ogwL7z0yqV350dAPhXxx5n/BytSpKgfFNg7qZV67QXBAq8P15c6XqBng34dyC4rH9BB/NZq2OpfH4xJ26ZhxwqT5x7X2gpdFmcC98d4HoQBbpwhC/uxWz0CRCmRzEzasHJnIgJNjUaMTWvzoQ56BrVghYAeDVdpTGCh1H+YYiaehB0rPExiAGl8peLM6adZD4dtJDmBXv/rmXr12A08qSciEjVwKleoHqT7M1gMoNmm1X2/T1iE8QpuK8WVFw3qBvYbBp4R3mM/ARSvHARlS3Tw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 11, 2025 at 10:23:26AM -0500, Liam R. Howlett wrote: >* Wei Yang [250211 02:49]: >> On Mon, Feb 10, 2025 at 09:19:46AM -0500, Liam R. Howlett wrote: >> >* Wei Yang [250207 20:26]: >> >> On destroy, we should set each node dead. But current code miss this >> >> when the maple tree has only the root node. >> >> >> >> The reason is mt_destroy_walk() leverage mte_destroy_descend() to set >> >> node dead, but this is skipped since the only root node is a leaf. >> >> >> >> This patch fixes this by setting the root dead before mt_destroy_walk(). >> >> >> >> Fixes: 54a611b60590 ("Maple Tree: add new data structure") >> >> Signed-off-by: Wei Yang >> >> CC: Liam R. Howlett >> >> Cc: >> >> --- >> >> lib/maple_tree.c | 2 ++ >> >> 1 file changed, 2 insertions(+) >> >> >> >> diff --git a/lib/maple_tree.c b/lib/maple_tree.c >> >> index 198c14dd3377..d31f0a2858f7 100644 >> >> --- a/lib/maple_tree.c >> >> +++ b/lib/maple_tree.c >> >> @@ -5347,6 +5347,8 @@ static inline void mte_destroy_walk(struct maple_enode *enode, >> >> { >> >> struct maple_node *node = mte_to_node(enode); >> >> >> >> + mte_set_node_dead(enode); >> >> + >> > >> >This belongs in mt_destroy_walk(). >> >> You prefer a change like this? > >Yes. > Thanks, will adjust in v2. >> >> diff --git a/lib/maple_tree.c b/lib/maple_tree.c >> index e64ffa5b9970..79f8632c61a3 100644 >> --- a/lib/maple_tree.c >> +++ b/lib/maple_tree.c >> @@ -5288,6 +5288,7 @@ static void mt_destroy_walk(struct maple_enode *enode, struct maple_tree *mt, >> struct maple_enode *start; >> >> if (mte_is_leaf(enode)) { >> + mte_set_node_dead(enode); >> node->type = mte_node_type(enode); >> goto free_leaf; >> } >> > >> >> if (mt_in_rcu(mt)) { >> >> mt_destroy_walk(enode, mt, false); >> >> call_rcu(&node->rcu, mt_free_walk); >> >> -- >> >> 2.34.1 >> >> >> >> -- >> Wei Yang >> Help you, Help me -- Wei Yang Help you, Help me