From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B9EFC021A0 for ; Wed, 12 Feb 2025 00:24:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4D5E6B0082; Tue, 11 Feb 2025 19:24:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D63A6B0083; Tue, 11 Feb 2025 19:24:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8768F6B0085; Tue, 11 Feb 2025 19:24:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6863B6B0082 for ; Tue, 11 Feb 2025 19:24:24 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D71A84B705 for ; Wed, 12 Feb 2025 00:24:23 +0000 (UTC) X-FDA: 83109396006.16.79D59B9 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf13.hostedemail.com (Postfix) with ESMTP id D69F120006 for ; Wed, 12 Feb 2025 00:24:21 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=h7shQ549; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739319861; a=rsa-sha256; cv=none; b=eTcNIR0cYmsoAk3mhriB2uqtNWmMCPF8Z47KUDAyKdGtIx3SEgEnXYu+b2n9pa6ha/Hb+S 0UlDMThc5RoCBsa+ngTnrXoFRPc/9k1EZjXQTE8F25NEi3PTmLJNVU0PkEIAjye8YP7cMp ZFVW1KOpOArzjelAv4jdLMnx5iTKBUQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=h7shQ549; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739319861; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WkcoPS5d9Qtus9ZxP9nOBKRQwnWzrpZlnwEmP8BGGCg=; b=u9aBPTaakrKrPZGeTFUtlTobp3kQMQGOp44iCz1V5yYssDPokMq2FC5m9Et8R02fnzfcAP Z+/DUH4bjYM1t/diHJc95z577ymcv5mvqPM5GO1FNlwnBjPDa051+4aT4335yCCHrcE7Vs m5qHJsrkk6EkTOZXR0vULKGQCJaXPkE= Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-ab7d451f7c4so285592366b.0 for ; Tue, 11 Feb 2025 16:24:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739319860; x=1739924660; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=WkcoPS5d9Qtus9ZxP9nOBKRQwnWzrpZlnwEmP8BGGCg=; b=h7shQ549VKKy0AYzboEdbwK+9ACdvJdlBwSZdbx0RtUY36o2rm/ckp7OUMNqLUHP55 8nJXM9OejANoQUjo01XyGhW7IXjXjktna7YIIJq3P0zOXI8vsvyWX8gCS2mxMxpUk+zi +0VfAOSp7kdCPh8F7WxTlc3quJ0Yi0Li5GCkerRNmfPdYYqG4M7menk+0g7Kmxu6pi5T Nj2XFQT/iR3f7S2v/rgJ1KTi4ylc+llosd9yOlVwP9uzW7sGSRNP8IaQ1geHrEjDGmVR KCkMJRLLGEVmj/OSilS3/LyLCWrWJe7y1U5z5EtVQt74OpFLMsAJvxtaOUkSnjitRvLX kpxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739319860; x=1739924660; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WkcoPS5d9Qtus9ZxP9nOBKRQwnWzrpZlnwEmP8BGGCg=; b=DeD8ITrrflTZeqV6uWjT3MS/tFs+kVPUqfiENAP90louc44owxApB7uRDQ3cfDEe2D tsgnxCNVmw07LXpUPqRbC1drtvLWx/RLqTxcIRzkMVaP0izQ50iLpXUHbbQJIYJ7KbJe gRj6ip/4jUQwW3sGA7UVbw6AjdZQUpxa8lw3Lf5jVvJ8On3c0v8XuQPR98hmrLnGThGX FLMb08zEnZ/vszthMPs/Bs7aPQIE3eWqZHldZ0LR5uzwSMGp8z9TL320aVbrDO48gF0L PYROPSRKi/tOwhcOePOyrcDXSfSsAe0t6aezaU7vCAntx+aUnJFCwjHCzIvd09Aw91lY zH7w== X-Forwarded-Encrypted: i=1; AJvYcCWTJIXH8Y/ugtYz+1eYuZsciGOX4nrZ5CObQ8nmxWaPq5GWzsx0B8C9+Yh47h62pv4JDp4HGWpxlA==@kvack.org X-Gm-Message-State: AOJu0Yx2KV5kz8uEov852DYZWGEO7M0akYtGiK0ZCTWs/ksjstOsEWMQ Y7aEmhCVbotOSuKEB7gYUSWF5gWsRus/FvDu8izIFxkWLPOt1zBx X-Gm-Gg: ASbGncuDLaZyjIIwUV81CZEgZrCn8OP1lU5OJ47TPXsSNlxOj89bFTKwW6cd6IgVIEr 4X84dOqJ0vkoc10LmBIVwKCrfZuhS9/8Qo9Z78uRB+2Rzv5yec1I4n6T0Pr6aqg75WsCdi4tFnH Cqi46sxEHdFe416Rohwtk/JA48uIaniTzDJC0wT1/0nC9E1pqzGE9k+Y94yFeUx3FKyNyhMaeKd +7yThmPoH2Gfea/mh06xMSq6tPVzTHjHXcbY1YD4lCD9Cajv6yu5OFqcwL8ZTM8NzYM+U6kuKhi Vd4PQ1Q6ZbJaojo= X-Google-Smtp-Source: AGHT+IHctK1ehUzW7eNaBmXAbOrA4psc6OaCby+8FfLaPobgr8mNB4I7CnzCJfs/M2+gd2DH2O87wg== X-Received: by 2002:a17:907:728b:b0:ab7:ca9:44e4 with SMTP id a640c23a62f3a-ab7f3391a21mr70016266b.15.1739319860023; Tue, 11 Feb 2025 16:24:20 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7b033e39csm656898766b.85.2025.02.11.16.24.17 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Feb 2025 16:24:18 -0800 (PST) Date: Wed, 12 Feb 2025 00:24:16 +0000 From: Wei Yang To: Shivank Garg Cc: Wei Yang , rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/mm_init.c: use round_up() to align movable range Message-ID: <20250212002416.rpxemlqtd774qcq6@master> Reply-To: Wei Yang References: <20250207100453.9989-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D69F120006 X-Stat-Signature: exmm15ruudtubzsunzexpz4j1cu1on6x X-Rspam-User: X-HE-Tag: 1739319861-625031 X-HE-Meta: U2FsdGVkX18JtkxhZMYNb6PoEI4Z7eUfyU3EuzsvyYGljHsfB4E3H1yd96tP9O2HT2SPFzR0UrsOX/iOBeTKptunLiKC+nCDoBnPDBfO5peA6fHSJKnl6XZftkwrXSNBkYgZlsySwoGhPtCGUsy/OCAK/MY6bLh00qNxjrlF+VTFAKrvWO6JXLDppBZ+Re5czr8TatZqdUrmclt4wjbolDULO8SEwaAU4jVJDlaMvcLrBAclbO81eRZx7ZMJeES6+S6kKXabIulg/yvziaRHd3jeQGyRU/mTWyWmzLIEPPv7HsuCG8afevH680J7fbaXhDSpVRYBTXmyXEv3GpP0Y2bFLmwBpDAAlqb5+4fo6y0dlH92WV5Kaj+fjJZJp5eqPeu+fMdc2IQcTpUpb4NKDLkqHG9RwZwT0VdPlhA30IiQ6iGCiwwdYdYL03c8WNX74dgP5IVlQEinXezd2w6nVwO3QfjkvH8PQAYNTl+azapRn0iDxaowEF83y2qmQ63FZOTToxckqST14uHmi5baZFhYWiF2DLL+zFrzcfwj7ItWyPqQVvtimuefT84Zl25AdVCVMi7Ru7dvCtuH6fpX1yxNKzt6mLoH38x042mIkM//v/53MtFXUzaVOnBqly8wdlsSwUlITSCg9Ct35UHBMEsmhNXIziJdSRn6l8wFVyz2f2Tl69MzB/2Z6t7Hw4CTT7M7oQQ3YjcPv1Qn9zPQv7sTL7siu8xVS1pu136tuYIFYT9q+dqPaVmGhses0+Ev316n7rgJHm8URQdeZyg8+i5wca6f0KBceIQ1JfDFcRMKG74/e2JyY487ylkZnDKIrwYQAdumEQdtCcW7F9HF8aZlk1aikmIPwVsQfEMGTKCgQeZ88b3YkJwnD1t4BdWicTsGDgy5pzyMMEhL7oMNulw5GXtpQjQ/CCJ8FZmDeLjyMk8FUBJZi0iB6QqKzcjLW+6n7ChnR9R+XU6lkge CMJYjHe/ OTIHmUkimqOYJdur8/ilR/xIc4k/GeTq+HgwWiDlDMLpe5rIrB77c7REZL7NET4/3ncMQs3oj79UsM64Z5yAimtEIFVaJeTwffLmbIvJGxsaAfwS3a0JpVvhNtA3dbYhrqp/E2p2p7nNwMB/B9D9pJ1dzxiaeQK9elbSkc3za1gA6cdfkYdUu6dcx3qGxqiObz/EfyEOVM7qL7/xOs0bJLhm8KntFoMVqIZ6h5nqv6T+w0M3VmWE8wA1+noT30hHwd6LUr1REoAmebKH51gdc8wSPVxqs2cEp/R4VFa+kIBfouS+ePu31xTzy1JTiJXe+mGTFlFUerFcGLzz8rJ8/OyMw8cuJjbIyyPWOpGYUddqNF0cMuk9gmwzwGsEsgPMKeOyEXcr8WiIKbW4WLmSnzzKXUslq9ttO0k8tXqGQVZa7lwEBHbyzoV7Vwr0qhmn31L9tgmjG8hYdhxvpDsU8/epGAr8ngNf0RqEdz/NApez55HvajdEW47WXMUu9x3I1nEeOSFzJDF7OXkaKH8W59xKgZlwpjT6C3lSoyF5unrs2Bb+RTBhzd4tJFuR1CvQ8bomUl5+L/iEFzFB/JbX/y/b/7KWsnwGagOGih3JpATHnWcasoDFCOO7jnLGsyatHDQxz9gevReAgNebtNqp5QSZq3hVaWCwL6K/3pun/s3J4NB2RIgUWIqxsUf4UiBWRMr5xSJ29PQP42+JKYAZg7qJaLadFnjrwcwQGlRMBj9Uxywl7/vhS2H+VFmGXVNj2TgQL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000129, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 11, 2025 at 11:43:52PM +0530, Shivank Garg wrote: > > >On 2/7/2025 3:34 PM, Wei Yang wrote: >> Since MAX_ORDER_NR_PAGES is power of 2, let's use a faster version. > >Makes sense to me. > >Reviewed-by: Shivank Garg > Thanks for taking a look. > >I noticed two similar instances in the same file >where round_up() might also be applicable: > > mm_init.c (usemap_size): > usemapsize = roundup(zonesize, pageblock_nr_pages); > usemapsize = roundup(usemapsize, BITS_PER_LONG); > >Since both pageblock_nr_pages (1UL << pageblock_order) and BITS_PER_LONG (32 or 64) >are powers of 2, these could potentially use round_up() as well. Perhaps >worth considering in a follow-up patch? It looks reasonable to me. I would prepare one. Thanks. > >Thanks, >Shivank > > > >> >> Signed-off-by: Wei Yang >> --- >> mm/mm_init.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/mm/mm_init.c b/mm/mm_init.c >> index dec4084fe15a..99ef70a8b63c 100644 >> --- a/mm/mm_init.c >> +++ b/mm/mm_init.c >> @@ -438,7 +438,7 @@ static void __init find_zone_movable_pfns_for_nodes(void) >> * was requested by the user >> */ >> required_movablecore = >> - roundup(required_movablecore, MAX_ORDER_NR_PAGES); >> + round_up(required_movablecore, MAX_ORDER_NR_PAGES); >> required_movablecore = min(totalpages, required_movablecore); >> corepages = totalpages - required_movablecore; >> >> @@ -549,7 +549,7 @@ static void __init find_zone_movable_pfns_for_nodes(void) >> unsigned long start_pfn, end_pfn; >> >> zone_movable_pfn[nid] = >> - roundup(zone_movable_pfn[nid], MAX_ORDER_NR_PAGES); >> + round_up(zone_movable_pfn[nid], MAX_ORDER_NR_PAGES); >> >> get_pfn_range_for_nid(nid, &start_pfn, &end_pfn); >> if (zone_movable_pfn[nid] >= end_pfn) -- Wei Yang Help you, Help me