[PATCH] mm/vmstat: Revert "fix a W=1 clang compiler warning"

[PATCH] mm/vmstat: Revert "fix a W=1 clang compiler warning"

[Bart Van Assche]

Commit 75b5ab134bb5 enabled -Wenum-enum-conversion in W=1 builds. Commit
30c2de0a267c ("mm/vmstat: fix a W=1 clang compiler warning") fixed a
-Wenum-enum-conversion warning. Commit 8f6629c004b1 removed the
-Wenum-enum-conversion option again from W=1 builds. Since the W=1 compiler
warning fix is no longer necessary, revert it.

Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Matthew Wilcox <willy@infradead.org>
CC: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
Cc: Ivan Shapovalov <intelfx@intelfx.name>
Cc: David Laight <david.laight@aculab.com>
Cc: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 include/linux/vmstat.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h
index 9f3a04345b86..d2761bf8ff32 100644
--- a/include/linux/vmstat.h
+++ b/include/linux/vmstat.h
@@ -515,7 +515,7 @@ static inline const char *node_stat_name(enum node_stat_item item)
 
 static inline const char *lru_list_name(enum lru_list lru)
 {
-	return node_stat_name(NR_LRU_BASE + (enum node_stat_item)lru) + 3; // skip "nr_"
+	return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
 }
 
 #if defined(CONFIG_VM_EVENT_COUNTERS) || defined(CONFIG_MEMCG)

Re: [PATCH] mm/vmstat: Revert "fix a W=1 clang compiler warning"

[Vlastimil Babka]

On 2/11/25 21:59, Bart Van Assche wrote:
> Commit 75b5ab134bb5 enabled -Wenum-enum-conversion in W=1 builds. Commit
> 30c2de0a267c ("mm/vmstat: fix a W=1 clang compiler warning") fixed a
> -Wenum-enum-conversion warning.

We could expand? ... warning related to enum node_stat_item, but not all of
them.

>  Commit 8f6629c004b1 removed the
> -Wenum-enum-conversion option again from W=1 builds. Since the W=1 compiler
> warning fix is no longer necessary, revert it.

no longer necessary and incomplete anyway,

> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Matthew Wilcox <willy@infradead.org>
> CC: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
> Cc: Ivan Shapovalov <intelfx@intelfx.name>
> Cc: David Laight <david.laight@aculab.com>
> Cc: Nathan Chancellor <nathan@kernel.org>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

Thanks!

> ---
>  include/linux/vmstat.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h
> index 9f3a04345b86..d2761bf8ff32 100644
> --- a/include/linux/vmstat.h
> +++ b/include/linux/vmstat.h
> @@ -515,7 +515,7 @@ static inline const char *node_stat_name(enum node_stat_item item)
>  
>  static inline const char *lru_list_name(enum lru_list lru)
>  {
> -	return node_stat_name(NR_LRU_BASE + (enum node_stat_item)lru) + 3; // skip "nr_"
> +	return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
>  }
>  
>  #if defined(CONFIG_VM_EVENT_COUNTERS) || defined(CONFIG_MEMCG)