From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D775BC021A1 for ; Tue, 11 Feb 2025 20:48:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67DB06B007B; Tue, 11 Feb 2025 15:48:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 62DAF6B0082; Tue, 11 Feb 2025 15:48:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F4846B0089; Tue, 11 Feb 2025 15:48:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 32AE86B007B for ; Tue, 11 Feb 2025 15:48:55 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C24A114079A for ; Tue, 11 Feb 2025 20:48:54 +0000 (UTC) X-FDA: 83108852988.19.E3AA061 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 15238180009 for ; Tue, 11 Feb 2025 20:48:52 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bR5Frp6O; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739306933; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jqKToo2oyPQmLcc4x96MJPeeBIP9YcSRQcJT3GgEQgU=; b=eaxgE068P4Cug55saL+yXa6iIpYvuxMJiBAJDaOhY4YFpMI2pQ/X2LbMKShAXAJ6ldLuXV RzjTM73y2auTBvM1TUptgUwPsscxGBdDNNlexSXuV5bZsEi2tYS/qhSg9VFOI/N2H/FbSh ETE+EbYMDZ8aAy58SDGASvPlf5qpBCw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bR5Frp6O; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739306933; a=rsa-sha256; cv=none; b=jO2OHJNdmOrPqVdZtqhKAjYz3x4gp8KCX78aU4RhnD+OVM1BtL/AKDZfjFSgecYSotn5eo 8C3UvWycfag3oyEsq6rrEl0ggBrARjMHRCYBTKMgtosgITBWv+4KFQq9gtqEQRT4uJKXOE uQ6n8/2gOEO+9h6ns11v1QbBTwPo/Fk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 480A55C556E; Tue, 11 Feb 2025 20:48:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 544B0C4CEDD; Tue, 11 Feb 2025 20:48:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739306931; bh=Y9Wjbv7i05qi/Jmy83+M+upT0I2koCoE8smbuZ3a1Mg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bR5Frp6OVV/VylmLrk15xC4n5aIKhHk4d5GlkYoljC/FbdnnWEpBhpY7uOW66HiVQ HgQwrCzzcOOLvKcxH2DAhGAGTSH/vFwxr7AJ7djHRgmK3hdOg/54dqVlETPX2TwUj0 WQ3R854+kM90nZgzAX26W6+nC01CGkG3Yd2zTUYbEHJcxlISAlIZHgcYLLdERxjs2f 4ErSbB1ylpqiT2t/vgKVEQq/+TqrC3TIIbhgFCRLNIlxUOkX4JZ9QBUVx2Oh6Dabs3 nFzmgAyofSlrq9AfHmukiPnXhEvXoG4oR4Llnew/09KVtoBz0iCsvwSqfybqNkvlq4 wh5iwxWD16mig== From: SeongJae Park To: David Hildenbrand Cc: SeongJae Park , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, nouveau@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev, Andrew Morton , =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= , Jonathan Corbet , Alex Shi , Yanteng Si , Karol Herbst , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , Masami Hiramatsu , Oleg Nesterov , Peter Zijlstra , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pasha Tatashin , Peter Xu , Alistair Popple , Jason Gunthorpe Subject: Re: [PATCH v2 13/17] mm/page_idle: handle device-exclusive entries correctly in page_idle_clear_pte_refs_one() Date: Tue, 11 Feb 2025 12:48:47 -0800 Message-Id: <20250211204847.107933-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250210193801.781278-14-david@redhat.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 15238180009 X-Stat-Signature: 1npyi955etoutwdkck64bgeh56pmncoi X-HE-Tag: 1739306932-551960 X-HE-Meta: U2FsdGVkX1+OysdE9airZqXhgkxxT8NbE/sLZgbhnZIKaY/v70y/n22ujnbfLpjUPvi3yrnjAib4OOO+Pl0Rdpiu5noCiZagwlgyeqExmL4FtQXnbBoN2zWad4/TQakXsrVg1gzKZgS3JcOA2QMes+jgrWVyg+C9WZomDUMI+CiK69xuA8/ZDPky88zBtcWyUpiXsFqubvECdGNed89v2Mer4AF83L+/WL6BP9GYPZf/Ddmm41Kkc9Sm8WPhP8K+Qzc5mjY5hnJvPv3HTYEWiV12dAqt6gSIfrBiV/kF1t6RzkxjVY3/h41fIhr2YpV2JLeob0/7PoCdBPumhiZuJUibK9PzihUt2+OsyPFffazfpWHRN0fFYPik4KUggbIWbA30bqYaxVP/aBB9KT98tyDkne536pZk9BV0vmiq7+4Jnp1GBxD4lc41t6rf9K47/XoKJgIFbee9j0DUgQL7jh4tdDKRC5ColTVS+l9aDVxGPbV0CKVpOFYbbiqZSXdm4HXBFqBAVnxrU5OEsdumWJhO42qCpQI6rhAFtTPtSr3YXc83al0m2QIlFfWXAProPLLHtN52jO+r9sUaHSvTKltWnYkncyBl0H8q9QpZJ6znBGy9ys8tgQgu0j2C/OiJIc0bVOWi7YVpQ1MBJzARusJvEsfnxceV6aPdMq/bSF4juxXrFKyPVAzklpMxaOAKB/GxYpm2XOVi1JGayb3+EfToQinmDTDtwUME1hDciW4wON1hsepatGB3jkcd85tGuzUjJ0orB3EmrkLF7K0cSEaBP9wrk0r7bDLb9+iAPPjbNDcm+J/8nB8nht8eZoxAKcZnzR2T5bryeJVaz5W5/Wp8Lk1IhCgnNtumsvJtsV9KRbSWk+k8prNiUbe1wtqXh2mN1WP0SrV3RHj5LWy2kohagQmDzU4YMhrjFowa6r86kX90FoCV02UjFfToeHiOzgoyl85s3Pv9W43z47E n7WLzM+r +a+dKVUDFxpPhByoj9LinePaH8R4u4h1WQ9nwstSqqO5DqYjwUbjFrHmEvSuDsIIg+PJbi0D0Z2LH9rBcWwZBfU8X6ke5t3p8G/9QWST7Vip91pU3pkm7CMrm8LtJ0JxiYoovg+37+IR6SLJD6ZNMA+zESlM4inA/WRzA5u+Ts6Caw27lnTfzqzZPrIIKWRrlgyNRfoYuPNywbTUwLbiLVco9dRlvWOSCJRhhMO53xBuQYYsQ/NOeFv/czAb5Gci7ugxqOjBeSjSynwWrtHx8fOUfA+scq4GVSFnRuivx2QHZFzLVrsBlg8+45g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 10 Feb 2025 20:37:55 +0100 David Hildenbrand wrote: > Ever since commit b756a3b5e7ea ("mm: device exclusive memory access") > we can return with a device-exclusive entry from page_vma_mapped_walk(). > > page_idle_clear_pte_refs_one() is not prepared for that, so let's > teach it what to do with these PFN swap PTEs. Note that device-private > entries are so far not applicable on that path, as page_idle_get_folio() > filters out non-lru folios. > > Should we just skip PFN swap PTEs completely? Possible, but it seems > straight forward to just handle them correctly. > > Note that we could currently only run into this case with > device-exclusive entries on THPs. We still adjust the mapcount on > conversion to device-exclusive; this makes the rmap walk > abort early for small folios, because we'll always have > !folio_mapped() with a single device-exclusive entry. We'll adjust the > mapcount logic once all page_vma_mapped_walk() users can properly > handle device-exclusive entries. > > Fixes: b756a3b5e7ea ("mm: device exclusive memory access") > Signed-off-by: David Hildenbrand Reviewed-by: SeongJae Park Thanks, SJ [...]