From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2861DC0219B for ; Wed, 12 Feb 2025 00:17:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D16F6B0089; Tue, 11 Feb 2025 19:17:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A82D6B008A; Tue, 11 Feb 2025 19:17:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 896FE6B008C; Tue, 11 Feb 2025 19:17:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6B1836B0089 for ; Tue, 11 Feb 2025 19:17:57 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 12AC4140FEC for ; Wed, 12 Feb 2025 00:17:57 +0000 (UTC) X-FDA: 83109379794.15.1CA0D34 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 52319A000C for ; Wed, 12 Feb 2025 00:17:55 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=bkoKcMUZ; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739319475; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c5DV1ajInBtyyL2ScPUsFql7IzzFINgx1Fhk8Db2a2g=; b=eEJHuMAi33w5M8GTD20PQZfWXMANvNqBeMwhsZWmVTY3FaxkzsoYC1kxisg2juI28jBi9f d8TENKYMI9pmpIG/uRW5RLKCk79M07kA0Zg0rCAetsKb2FuZSFau5IUX8Qq64+tzh2rx7F qfhuc5xF1E2p/3ZVF7grYsTry8YXeII= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=bkoKcMUZ; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739319475; a=rsa-sha256; cv=none; b=8Vye4lp8asY1Zrf/6ZnyG7eHtMG9dcTs3EZMc7gWZlmkcvqDw+SEovMJwgYNMVHM+4/YSz TKojI8C2WdzSqpC22IT8tdCFiS0JoI5ldANCufemEoWFQhvfcTA+LZvUzXAheHGhsI6t8/ SwV0Vqk5JZlR/IyEQSvOCCr3JP/bijE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C5DC05C53CC; Wed, 12 Feb 2025 00:17:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72914C4CEDD; Wed, 12 Feb 2025 00:17:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1739319474; bh=32KkHloJYCtZwikjLtOAwLrz1z6Zc340EGeVc3fcy0g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bkoKcMUZ9hzvID14imCkkC6Nef+XzgMK++AqquQnrzkhY9s7CM9qD9vrQlxLichz5 N0L5EN1OV1BpSkCwmJFHjF86W4zr0a3VXLWVPvWCH7fGkC55yBvc7G/VcwCXnX4bMX xfz7AYlawh9FtzHE1isEi96n2LVKEE2bD464UipU= Date: Tue, 11 Feb 2025 16:17:52 -0800 From: Andrew Morton To: Joshua Hahn Cc: gourry@gourry.net, hyeonggon.yoo@sk.com, ying.huang@linux.alibaba.com, honggyu.kim@sk.com, rafael@kernel.org, lenb@kernel.org, gregkh@linuxfoundation.org, rakie.kim@sk.com, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, dave.jiang@intel.com, horen.chuang@linux.dev, hannes@cmpxchg.org, linux-kernel@vger.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com Subject: Re: [PATCH v5] mm/mempolicy: Weighted Interleave Auto-tuning Message-Id: <20250211161752.64dd397e66a2754097ab8c2a@linux-foundation.org> In-Reply-To: <20250208050606.800498-1-joshua.hahnjy@gmail.com> References: <20250207182009.7fc099c3074ad00338f25e0a@linux-foundation.org> <20250208050606.800498-1-joshua.hahnjy@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 52319A000C X-Stat-Signature: ohuer9qyuqqktxpxghhpi1mdm3feti3z X-HE-Tag: 1739319475-664263 X-HE-Meta: U2FsdGVkX19V8DbxT5UEZbupbFfr8aSFw6sUqr3OiePqs3mbbRnNCL7POjgtJTGssdtGJGVrEQmVTf7feGWhjP5WWfc73GC+CERPqKdD7xbCtXG7AKARstn6YyQsMjPAeTuFDyxPYOuhDHSR7b/XGI9t/WsVO0eaja3h1bJIuH+VAUky8r+rPWGzgvYXXO6NUpAxsO2elGLLKSXBdCi+zJBokYALcVsUHVxyB4IVQ6syZGgjsyfKPIqDEUSRPbriupKDBNoDnnHBJBfkjBh7Pt7biTAyLEW5LwTOcB/3gcjVlO3pqKHNnc1PunqL00wkW9etKDpZLdrsAfODfeXKxraq3xiOgu8tRhtNAChwKYm5RRx6WoUPCYpTHeODK63Mut7wYA8OFmEmN2D4ezOd/9j6wKsDpLf18cWpOrwY97AA3pSzZUVX+3b1BQzjs6QPUZ9TfZqRkeImcLYYA2ZxtsLaSEhWUXfdlOGtprY+AIJQjy9ESgIymfkMISPgsKTZG4ZrJHwmXw7oR2ZUSTPaSX9UQIgMiflGhScBXLpopxU1taj4ANNiNv/N1sfNgH8uIL8oyqbx5kNlZLMSO57hEON+/SsVTuekviv1cfYbpQgKWuy0xznOFKemWYBPSUT/NPLg+HGlc3JoAnv6bzdNh7eJhmMWxCsfS6Zsq1ZsQHCNefaKBbzSFeuh8kOM7/1b6dH3s3jNJPxMNyCx0A2sep2S4Tp9Oc72UTUzNyW5GN2XxlCmctJ8syfdycX/4M7uh5sqRLQOB9VIbD0YluNx8FYnQyqFmmClnhLXbMCKWIGgUsEy44TxjpA2Gyx/c4NLR2kq4WJ0xrDWweTBcP/La6lgdnQBFrdZOfGlaV5nY0beva+l1LuLNW8OSrL6rkmwZFV32UsojtLB8dsbiYZe/T2Eud0HbJZEQlPp/i6/j3TqQi7hNf3kwJlkgcTxpaPP9h/JNn1x6qJRP9oTA6O YWoke3y1 tv1RzyufvxtXUyDDtyOYx2U/7/hIebh+vYvAQy2T0bXGv2SxHd5WYirmkkVhEWENjbROV9Uc/XAo4xBlDcwZrqDX7BMXZyhPU6cC96iDsl70L3fE+HqffyD+/5Z/hBfx9ugtbKILfacijySV1ai7o6ZSskiGVRyDK6EuDzprdWIOgzTUWGn39MtFgvIxIbu+D7JT965br2iOYpIFpZ+h3CIrW0rtiL+Jyz/wLFDGfNqQZzIP+IqrIIolkDPWh6RiUJstMrzumGgjF+o8stJ9csrprph0EHuj/y25Q9R6KLtkFeuVcTrANDkBMXxkL/sf1KCEMeeQmtzC+IA5OcsEAGR5BCL2X3v5fOPAJdrCvaQVSTxvtNnORcYIzs5N9/4qfgLqlW0lxJDYmuIgAf3E7BLJgBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 7 Feb 2025 21:06:04 -0800 Joshua Hahn wrote: > On Fri, 7 Feb 2025 18:20:09 -0800 Andrew Morton wrote: > > > On Fri, 7 Feb 2025 12:13:35 -0800 Joshua Hahn wrote: > > > > > This patch introduces an auto-configuration mode for the interleave > > > weights that aims to balance the two goals of setting node weights to be > > > proportional to their bandwidths and keeping the weight values low. > > > In order to perform the weight re-scaling, we use an internal > > > "weightiness" value (fixed to 32) that defines interleave aggression. > > > > Question please. How does one determine whether a particular > > configuration is working well? To determine whether > > manual-configuration-A is better than manual-configuration-B is better > > than auto-configuration? > > > > Leading to... how do we know that this patch makes the kernel better? > > Hello Andrew, > > Thank you for your interest in this patch! > > To answer your 1st question: I think that users can do some > > ... > Interesting, thanks. Have we adequately documented all these considerations for our users or can we add some additional words in an appropriate place?