From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF85DC0219B for ; Tue, 11 Feb 2025 16:08:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 53320280003; Tue, 11 Feb 2025 11:08:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 50ABF280001; Tue, 11 Feb 2025 11:08:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AB72280003; Tue, 11 Feb 2025 11:08:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 10EAE280001 for ; Tue, 11 Feb 2025 11:08:57 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7B5B9140630 for ; Tue, 11 Feb 2025 16:08:41 +0000 (UTC) X-FDA: 83108146884.21.16A3A20 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 692AE16000A for ; Tue, 11 Feb 2025 16:08:39 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ImI/nPuS"; spf=pass (imf08.hostedemail.com: domain of longman@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739290119; a=rsa-sha256; cv=none; b=1XsOJDZ1wLn8NtRS3azL6t833xopzuD4am02fas+0531mM0mITE7cJgPzbLZ0DWIkzkiTi kL7oY8BUU16tmre9mETfvWlVdVtV6BPVA3xQj65ZYFOCfc0AdSwQQBgKbIF8aCBzji8ro0 FVYJk5h3Gm6zkOukNL/3CpAlIKEum/o= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ImI/nPuS"; spf=pass (imf08.hostedemail.com: domain of longman@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739290119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=UipiODYFsFgVF8vxMUdu6AW5VgLIbfrFFLlK7TYmKsA=; b=c/UfzlKTxeWg2dXL63+mNqawigADbBde1N2Hddll8pVi2fslrBZ5JYyB6oD70j3PJKob0t HwrHvqsVpQfv8gnAp9mUHFqicupWxTus5YMWZ0zZSNd4n3jlo04Bso9W2XYOjammbMHl2o 5ezBJXM1dbrXFqKYUW8Tcr3mdopmA4M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739290118; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=UipiODYFsFgVF8vxMUdu6AW5VgLIbfrFFLlK7TYmKsA=; b=ImI/nPuSejq58h0evYoQ5eND9oPL8qH2uITHtV8MvErZDEl5mij03F6MBBoDLWMXudf04r CAWD5s/PGOPGJy5l2INZG9lyJQPh4PxePDm+9uTwAP2X2WM1pWAanFOtcDeg5yXPGdUTe+ 7hyn+cJHhl1VgsOFkYLYbRgDk4OBTLE= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-487-o45N5vneMBKaSqLBsS2KlA-1; Tue, 11 Feb 2025 11:08:33 -0500 X-MC-Unique: o45N5vneMBKaSqLBsS2KlA-1 X-Mimecast-MFC-AGG-ID: o45N5vneMBKaSqLBsS2KlA Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4F35C19560A5; Tue, 11 Feb 2025 16:08:31 +0000 (UTC) Received: from llong-thinkpadp16vgen1.westford.csb (unknown [10.22.88.207]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8964A19560A3; Tue, 11 Feb 2025 16:08:27 +0000 (UTC) From: Waiman Long To: Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt Cc: kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, Nico Pache , Waiman Long Subject: [PATCH] kasan: Don't call find_vm_area() in RT kernel Date: Tue, 11 Feb 2025 11:07:50 -0500 Message-ID: <20250211160750.1301353-1-longman@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Rspamd-Queue-Id: 692AE16000A X-Stat-Signature: h3qjsfksesrs7soxi454r4yi8soyk7o9 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1739290119-943458 X-HE-Meta: U2FsdGVkX18X4DOLjtvDlEVvvXO/8LZ9TOGZ5n3PbBUVetcVMsADJMgmLuEwyQJVWnTNAKanI6xmhXD/5K/dlmlToir/nALmgC9MdzQt9sLCYD7I1dgvCw9/AiXoOPQlapib9HnzQTyAPVYSSYYx4rgvEF0wePU6vG4zn9O284bkLTJTCfCnUoKwKzbYUuctKpZhcz/cICk231JTkpdShLfLGXzhfdR6DcvFikeXO0dLoOiWDn1HJM5PH0X4uiMpGqm9NISIYLNQDxNAhpWMSpB5w9fJY+4jF2QKOx++mHvGWaNTcowpTmvuBslr2rvWlPonKj8AZm8qIRLo25s+HeiN77vnU8BpTo5H1/CTJzL8Upmlg5KX/ROhb1WKz7yNqzzGohUXOi2rOPdfeSvNZzBHg/faw4HrHu0j4GFEOUW1RuWAe2eh+FRk8eUwTAzIoE7lt6rS9ydpliEGzQu+hjU1CoIIGzr3G+xMYxmYZqh7f8JvsCr3RBCt6Sl5b/WHiFTFec2FIWsdH39BD43MNYk7LxYmPqriS97OmubnPLjD61dxD61D+oGYSe7bmBaKqSQXZE7jueBnIJf6q4g7JQnMcdulxutgJ64whvKXfJlJeoFvoknUFUEaYHHE+LDayFFxFI9fVtduDeFEO4qB9rUqnb0DhB5y6yTPew3Jp27+DT67Mcgwto9pxbXoQ5gu8IY/o6uihPt62bRySBxDhO+cKNxCves6Watf04NnIWLdWyA5I9qKpeNdiQWtZ3mTxYNAs/TtTZk7rjr9BZNDPRKKwbRqcCScoAyXQIS6b34CIhg3kkR0khAY4XvTWuaSrDtfLn3Y4p8Gs5qZdnuKYG14hS+qhLLBcjVtSqFzaopkTklS2b6seLZonIXGnvNCOg/90soMbR97ymIb2YS+GPFAr6elQSRHC6Jmxk3t6/wzcaqPEK1vBfvwPW6qpC859QjmyK/FWVQB3gCYoK8 BLpEsTke dvfYuqQmAiaiP0oNsfz7h21d5rkP3WIIJ565zM83J9tIFxFphhquyVSXVU/x6fwED3LvilhH6m33WkSN4xvv8soCraJFCVLFHYA6uTQ16ts194HjHndI/1cFGqm0fpWyRnBHggSsiQ6fV0JbhuxQtlX5YKoEi8y0TxroxmZCssDLyQy4olDTXqn1AOR7RPWKe4YsEy/pWFD0zQmrlqQOdGMEnCIE5/cYxZUl50K4PxFHJFSXXxFqv/6ZQSk8nzHhtF0zZI32paUv1Ke43e9gC+zt4L6l4OV48XCpQS20M0v8+Zx0BGmmD7kipqgcxbnKrz0iv0OnuNn1K5X7heERkPIIs4TV0QZhFnZ7dXFeSWbaSGXJDSIXdbhRTSFYs6lSobUj9l4WC8qBxPpkatiHu4bUTH++pOflkx9RzA6tKzwwl+LGsOxIjsPuglsFUKq5s27Fj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The following bug report appeared with a test run in a RT debug kernel. [ 3359.353842] BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48 [ 3359.353848] in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 140605, name: kunit_try_catch [ 3359.353853] preempt_count: 1, expected: 0 : [ 3359.353933] Call trace: : [ 3359.353955] rt_spin_lock+0x70/0x140 [ 3359.353959] find_vmap_area+0x84/0x168 [ 3359.353963] find_vm_area+0x1c/0x50 [ 3359.353966] print_address_description.constprop.0+0x2a0/0x320 [ 3359.353972] print_report+0x108/0x1f8 [ 3359.353976] kasan_report+0x90/0xc8 [ 3359.353980] __asan_load1+0x60/0x70 The print_address_description() is run with a raw_spinlock_t acquired and interrupt disabled. The find_vm_area() function needs to acquire a spinlock_t which becomes a sleeping lock in the RT kernel. IOW, we can't call find_vm_area() in a RT kernel. Fix this bug report by skipping the find_vm_area() call in this case and just print out the address as is. For !RT kernel, follow the example set in commit 0cce06ba859a ("debugobjects,locking: Annotate debug_object_fill_pool() wait type violation") and use DEFINE_WAIT_OVERRIDE_MAP() to avoid a spinlock_t inside raw_spinlock_t warning. Signed-off-by: Waiman Long --- mm/kasan/report.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/mm/kasan/report.c b/mm/kasan/report.c index 3fe77a360f1c..e1ee687966aa 100644 --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -398,9 +398,20 @@ static void print_address_description(void *addr, u8 tag, pr_err("\n"); } - if (is_vmalloc_addr(addr)) { - struct vm_struct *va = find_vm_area(addr); + if (!is_vmalloc_addr(addr)) + goto print_page; + /* + * RT kernel cannot call find_vm_area() in atomic context. + * For !RT kernel, prevent spinlock_t inside raw_spinlock_t warning + * by raising wait-type to WAIT_SLEEP. + */ + if (!IS_ENABLED(CONFIG_PREEMPT_RT)) { + static DEFINE_WAIT_OVERRIDE_MAP(vmalloc_map, LD_WAIT_SLEEP); + struct vm_struct *va; + + lock_map_acquire_try(&vmalloc_map); + va = find_vm_area(addr); if (va) { pr_err("The buggy address belongs to the virtual mapping at\n" " [%px, %px) created by:\n" @@ -410,8 +421,13 @@ static void print_address_description(void *addr, u8 tag, page = vmalloc_to_page(addr); } + lock_map_release(&vmalloc_map); + } else { + pr_err("The buggy address %px belongs to a vmalloc virtual mapping\n", + addr); } +print_page: if (page) { pr_err("The buggy address belongs to the physical page:\n"); dump_page(page, "kasan: bad access detected"); -- 2.48.1