From: Andrew Morton <akpm@linux-foundation.org>
To: I Hsin Cheng <richard120310@gmail.com>
Cc: zhengqi.arch@bytedance.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, jserv@ccns.ncku.edu.tw
Subject: Re: [PATCH] mm: pgtable: Unlock pml without branches when !start_pte
Date: Tue, 11 Feb 2025 15:50:16 -0800 [thread overview]
Message-ID: <20250211155016.857387cd35e19a463d779cae@linux-foundation.org> (raw)
In-Reply-To: <Z6rzC5MGG8xrjnnF@vaxr-BM6660-BM6360>
On Tue, 11 Feb 2025 14:49:47 +0800 I Hsin Cheng <richard120310@gmail.com> wrote:
> > if (ptl != pml)
> > +out_unlock:
> > spin_unlock(pml);
> > }
> > _
> >
> > but that's really ugly.
>
> I agree. Would you be so nice to suggest some test method for me so I
> can try to test how much benefit we can get from this?
>
> If the case happens frequently enough I think it might be worth it?
I expect this error patch is basically never taken - put a printk in
there and run some tests?
prev parent reply other threads:[~2025-02-11 23:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 10:09 I Hsin Cheng
2025-02-11 0:37 ` Andrew Morton
2025-02-11 6:49 ` I Hsin Cheng
2025-02-11 23:50 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211155016.857387cd35e19a463d779cae@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jserv@ccns.ncku.edu.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richard120310@gmail.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox