From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB165C0219E for ; Tue, 11 Feb 2025 07:48:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25B0328000C; Tue, 11 Feb 2025 02:48:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2081D28000B; Tue, 11 Feb 2025 02:48:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A87E28000C; Tue, 11 Feb 2025 02:48:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DE61D28000B for ; Tue, 11 Feb 2025 02:48:29 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 16EFE1A127E for ; Tue, 11 Feb 2025 07:48:29 +0000 (UTC) X-FDA: 83106886338.22.903D98D Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf02.hostedemail.com (Postfix) with ESMTP id 22B6880005 for ; Tue, 11 Feb 2025 07:48:26 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="ls6/sV86"; spf=pass (imf02.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739260107; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4Lco/NiUiU4FOOJ/aVWa7MAjUSliO26a1kIkwUe28IU=; b=weCMxd4hPqDCsEwDKJl+XC9CAGkMg34t6N1otRCNeU1TOANTMfrHu4yvVTrqsNNxR3GkYn iUSwIf5tLbcT+jHgOiHTGk2WOzvJ5ktR6Ppl21k8H6EixnWCrDVHD9s9Z+kZd+BAVJcV+8 +E05ZfyvGn41sRJ9SfuNdJ1i0BghB7c= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="ls6/sV86"; spf=pass (imf02.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739260107; a=rsa-sha256; cv=none; b=hF8OG/ocO5iHQG1B3qI4MOXUQarb2rSX1KApFCVxSd/IwU+lB1/fHfioeQf3wnLG0tTytV +4TjOnsse3mbjl6arNzqzolp5flKOOpqe5hbn4P/edjFRnP0WmUIPLjfYsOhbTbkvJ46ui S58o7vF5Q0p/pSanuq6w94rgWCZNviM= Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5dca468c5e4so7225151a12.1 for ; Mon, 10 Feb 2025 23:48:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739260105; x=1739864905; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=4Lco/NiUiU4FOOJ/aVWa7MAjUSliO26a1kIkwUe28IU=; b=ls6/sV86D9hQe4MWeGz05AiPrPzN7Bfv3GLk7cpa68mqnuO1jGQ7oc8YLHP+uyn5DV lPRXTKYoEj8k/NuC1LQ5315mh/MYgR00YNo7wXveHalr5tBjeTzSo0zmW0yAdfREJlHN eaWr6x9BpVDviA5C0EaHNR+z5TQS9xeCRZnX8o12cSj2n7Ly5GhzA9durJMVNFgMZqyi UitNiBABsqTUo5sg8cl/2cX4ZqhkRLuCWpohAdBsM7o4f7kYiOgjP37S7R0aZrBxZIKF PVEEy6gREosRK4dsqAU2d/DGrZpNeCFB3FwPa+iIgOWdgSsjhieV1UXHDaLJB3z3Bov+ oNaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739260105; x=1739864905; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4Lco/NiUiU4FOOJ/aVWa7MAjUSliO26a1kIkwUe28IU=; b=OFAOESm3LYY7Z28danbUbVF8culcaPzpBNePG3lZeTx2vXIC5DM9NQZk/d8uRHlQhe +ZWe0a9xHYFOJvATro2LBJP119oMwQeUwRpz/nswI6w1IJ3N1VgugaoTtCAxJ00Gn6OI Z19EBWvgDhdqYSHxtPbN/9AEF9cN/q0cNbFtuQoJAofQ/KIWJtOCpfZqA7u4QF02wXE7 HsbL4ew6Y8f7oXN3h3v9ne2JHkZDggiihd6Pr2x1WBK1L8NMthbKTb8vWZdFXLWChoL2 9UXr75hWkI7YfnH+QDGZj5P6mSzl6LCoX8bKnVcX8dUEtBlHTVyMeK4kDua6vLSXsxVX cJcw== X-Forwarded-Encrypted: i=1; AJvYcCWULocV+ycQ3HLOIwKJ/RctDENq1pwFiCsSZSBreZV2Bv0PXlR4JtdN/IQKNEJfj1MuXb00QomGUw==@kvack.org X-Gm-Message-State: AOJu0Yx8fmtQAPnSwnHGBYFUOO7JghuCWwDZZA6T8KWQaNPYl+/EMTAy SRgxsEJ7WpL91F8ml2Ij1cxlERaGSuYGo/DucSwmDb5+AyFz5DIRDlK5VhUU X-Gm-Gg: ASbGncvnraWulsmuDblaRbjaTTze3g+e3WtPCsYf3S+0WGo9S4LcksRUWoWWwtfLK6S GzeGbtkj6V6s26Gj8vyXkvjpyQYzI8eo4yOvIjVALP4+AwVOpg8k9xhF22OoaVdVVnwLCVQa3Z4 LFQgLOzJvxLQvQsidKSv7WtrqEevadvOBC5ZSAPEZAFT6sSM/OepmgulEhSPW6uPn2iOhKTP4z4 8yIAWtX3UNcsiLubBcl0xMo8BqaHthcELqhRkGjq/6kq+oeiwGnCCDTM7q7+x48b7QGVW2BplKb usuP8DYsqepgO/4= X-Google-Smtp-Source: AGHT+IFSA8kWoH4jOKBbAt4r5rTe1V2Nv0LS3cE4VqImV5sRNitQvfeFRSmzdfin6q2KuMw8ZMEahg== X-Received: by 2002:a05:6402:358f:b0:5dc:7f72:5eae with SMTP id 4fb4d7f45d1cf-5de4508dc87mr15326343a12.23.1739260105319; Mon, 10 Feb 2025 23:48:25 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5de5e6ac118sm6089594a12.17.2025.02.10.23.48.22 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Feb 2025 23:48:23 -0800 (PST) Date: Tue, 11 Feb 2025 07:48:21 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [PATCH 1/3] maple_tree: may miss to set node dead on destroy Message-ID: <20250211074821.uw43qk5mk2shrndk@master> Reply-To: Wei Yang References: <20250208011852.31434-1-richard.weiyang@gmail.com> <20250208011852.31434-2-richard.weiyang@gmail.com> <42meyihs3gnp3bbvn5o76tzh6h2txwquqdfur5yfpfu36gapha@rtb73qgdvfag> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42meyihs3gnp3bbvn5o76tzh6h2txwquqdfur5yfpfu36gapha@rtb73qgdvfag> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: 22B6880005 X-Stat-Signature: whmcqqnnf31yrfexdqgg388cwq8cxz1t X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1739260106-329485 X-HE-Meta: U2FsdGVkX1/lQ5kOa5Ovk70Hs/sTLq9uS4bbcR5/UwalvWoeW9UsmtnQ9Kebx02vJBWWUev1E6BOGGESyS8Br4h9i/nUBsmS3yU0yQjrYyApZnK66ZFt7DpnNQcPBjyQ7hXWkCvrBCTQaliPpkNk5+vVRcJjS43tJJLckfe4NCQ6zTVHQe6jzAYehjPdu8uQMIAL0KSjXSGNhNpWQF+dQbOIctzhwzQ2p5qE1m0eELF63hCP2Nt1aBS+UJADeZI2CAIxuIZ1fcWsBnx9Ci2lE582yAmbo7WlnjtQpuXE6x/p1GT1ktWHU+YSNfxTK/ENQmpe9AfU0FOXW937ubOLQH+ni7teqH1NJBU4ptILup4FLAianurFfn3tFqZYiJ15xGTwyNClbBXk0ZhCjch+JSpMm6vkYcO2u1sdmS/t2plJQhpx6yNJQTXfdrAAJKOojzlY6k4XOaczzXR6lvsW5ZGFZh2QDnrhwJyWiIrK4nJ/9erdXo4rLCyMmJgtTmB0YjstyrjozQYtig7hCAeg1F8W5Vq9u0GFay72BgCSDtnrH8AcXVUADQFNmjEX/fZehtDTub+okhN47HVQZgV+7+gNTtfPge9KFGbVQ7U7aZaYNtGbMczs3Pn4esKbkiUXpPBA7CaLZP57n/l+IskAGzBbx5tHhulAQ4CUbUgHmjNldFafZ8/110neyLOZb3HIIUaeHqoj2T0+WUhVoTtqiNhzUfpMCZRy8kBOKJ65/W7+5rAty9Jsg3ncFDYNMpBxckU3HxlUV1s9kZFNZ6/Yb/5J4v7uEG7w5baNUwANk6lqE6S3Y5Q/ODAU6eyncSiMR/qzOjL6PDk4PqIU7gBGr7S4NOjiGZHNlkZSHfPbw138f4JmDyFMRjiV/L9VzATO21BXjnLSAncjGK0pQwAwn4ioKriRDkrPNe5L56kUrEGE381uOqRjwqCGYYG0+COEsG0yqTMWEpjMCdb164W QMml83sM bzA+vGA9iHcRc40vzRDkuBTqNDkoDNWt4qEzPPBe/ZQrCk7c0zeBj1TFOWuHyvG0vEpxqwOaSV9Nm0rvpCMFMVj5UaKspF8UcTdXN75z9Wieus1XOYZI9HcIs23QFCH5Orzebder8iOZhElRnQwkQKMqwiW6VNWBto0PLBc5deXNtV5Di58eyUGdYU+ffQjt9pU9iizxegOK9bPR489+/6xx33z1bEzj7k8YSh13aKh2XFP1Y7IzKlJCtoqB2bjovzSJKuFzg51MtRWvOx4yPVJzbK6YHxh93o0X45hPSumxTV2jxUgVNQcIA6EJpxx4h5SG2tHlwHcJMhHj6sF8UaDaHqOrl2wIXb3IW50lSeLz4EW2GmY8Ht1w9lWof/ObyIr1RoVgfaTXc5gCMngqQKv3CMfA+YDtMIgA4PxCNUyYq2S8ORT87gZfapJdMng8Xfe5XvpTMnmVJV6f9k03Tb6Fe+RcQBKSVJyQjvuwFaLn/eNZotgnaxCeQCx/hDiukS2XpFvxXXaOat+Xn4YOfzEIK261HtEXT0P84OcSWiW3uCReOAN6oVVStBu/zGmdNXUXuW+tO8YWwoIiKWVBan9oVvi5u9knlzhJDjR1J76L8hiuHsrBC9N5DcMvdZ+R8/zm58ArNhHIEFQYd64ze3DQ0prw2LeZbrJZ7URNr5TFcGU8dQg7l6KYsSO/XrBnZfxmwhkXzDpkoao1QPCObQJAfW+rMYTLse/OlwuGczMggU68mSWKczwtB2s4aAEv7y4scLZHQWB7aLbMy4/H4RRfm5g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000145, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 10, 2025 at 09:19:46AM -0500, Liam R. Howlett wrote: >* Wei Yang [250207 20:26]: >> On destroy, we should set each node dead. But current code miss this >> when the maple tree has only the root node. >> >> The reason is mt_destroy_walk() leverage mte_destroy_descend() to set >> node dead, but this is skipped since the only root node is a leaf. >> >> This patch fixes this by setting the root dead before mt_destroy_walk(). >> >> Fixes: 54a611b60590 ("Maple Tree: add new data structure") >> Signed-off-by: Wei Yang >> CC: Liam R. Howlett >> Cc: >> --- >> lib/maple_tree.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/lib/maple_tree.c b/lib/maple_tree.c >> index 198c14dd3377..d31f0a2858f7 100644 >> --- a/lib/maple_tree.c >> +++ b/lib/maple_tree.c >> @@ -5347,6 +5347,8 @@ static inline void mte_destroy_walk(struct maple_enode *enode, >> { >> struct maple_node *node = mte_to_node(enode); >> >> + mte_set_node_dead(enode); >> + > >This belongs in mt_destroy_walk(). You prefer a change like this? diff --git a/lib/maple_tree.c b/lib/maple_tree.c index e64ffa5b9970..79f8632c61a3 100644 --- a/lib/maple_tree.c +++ b/lib/maple_tree.c @@ -5288,6 +5288,7 @@ static void mt_destroy_walk(struct maple_enode *enode, struct maple_tree *mt, struct maple_enode *start; if (mte_is_leaf(enode)) { + mte_set_node_dead(enode); node->type = mte_node_type(enode); goto free_leaf; } > >> if (mt_in_rcu(mt)) { >> mt_destroy_walk(enode, mt, false); >> call_rcu(&node->rcu, mt_free_walk); >> -- >> 2.34.1 >> -- Wei Yang Help you, Help me