From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3360C021A2 for ; Tue, 11 Feb 2025 07:00:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60855280005; Tue, 11 Feb 2025 02:00:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B810280004; Tue, 11 Feb 2025 02:00:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 459A2280005; Tue, 11 Feb 2025 02:00:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 25702280004 for ; Tue, 11 Feb 2025 02:00:09 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C3A40810A3 for ; Tue, 11 Feb 2025 07:00:08 +0000 (UTC) X-FDA: 83106764496.25.AD2DF85 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 0A34D40006 for ; Tue, 11 Feb 2025 07:00:06 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GI2gfjNc; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739257207; a=rsa-sha256; cv=none; b=7J8oiuZql9E5qFEN1TJkXCV154lUPlyCr9s+cM7nENK2+EDB/GEX9FRPAZVZRW7OChSM6J kU8weYGAmdWauJWPGFNJc9RlTLk3Qf+xv1SUh2mj+JC9gOysKcn/4dIiWteYMls9mjLlLE 1Wgtx8PCPKt53sVcvXh042m4qdQaLLY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GI2gfjNc; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739257207; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qrIPCxeM14+PtN1S1mDBsO8QlyL29cEMEU/F7JCMui0=; b=OlplbnyBanntsJy/7ljo3sIbdBBMgrjAsT0++TxDlLWj8ndV8P7rBgI6YUgLuziaYZ0vlT Qi1vRjax3L1aLjZ9MSTgcs7KZq74SbZATs1s5VptUq9VzkPo/8ReuLNN+FnjbQZNRT2AyC SopUfDnTDipQ3IZwVy24ciqBa2X4e3U= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 549FA5C141C; Tue, 11 Feb 2025 06:59:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E770C4CEDD; Tue, 11 Feb 2025 07:00:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739257205; bh=2Of0rA5FoGn4ZTHvRWUGZwrrx3D8metj3Q4juNaw1eM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GI2gfjNcDnwg7GzDatzEEZWfdJYDwAQFrC79MEvER1PMZLr7IEBISVpIOBY+WVS/O Gv8Lp5iEfvSod7fn0czmeJmEGHThHHxD6wpiXBFV1nkPXHa9njgo6XN2sS6Rx4U67S sK63mMvK5ma/GUUgHThjzPIYwzhBUYy6KcmWJ2zWLBgCMb0O+5DZpMFv0OzEoV4Kmt B5434/VJqwbdrTCswBVUb0QbiYOXhnKk4JdWUR5CiSq6lfFLOFAyW6GydavzlbWW19 6gVh1UsyCquTPBGSNfLBRtN9/TduDjrWCgMDEVYeiuiF24cPFXuKgba7glsc/7wRYn KUj/R737RmeTQ== From: SeongJae Park To: David Hildenbrand Cc: SeongJae Park , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, nouveau@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev, Andrew Morton , =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= , Jonathan Corbet , Alex Shi , Yanteng Si , Karol Herbst , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , Masami Hiramatsu , Oleg Nesterov , Peter Zijlstra , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pasha Tatashin , Peter Xu , Alistair Popple , Jason Gunthorpe Subject: Re: [PATCH v2 15/17] mm/damon: handle device-exclusive entries correctly in damon_folio_mkold_one() Date: Mon, 10 Feb 2025 23:00:02 -0800 Message-Id: <20250211070002.6005-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250210193801.781278-16-david@redhat.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 0A34D40006 X-Stat-Signature: k1ekxy8bsb3gryqi1tybykr1qku4zbao X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1739257206-609050 X-HE-Meta: U2FsdGVkX1+LvzzOGL2FVie5r8D7mX2fYhzO3R245oMQNmF9nVAogFtQJvLcYQA9rzRIP3uNKxc5Z4nU1BQlghAZ8c6Sea+r/zj4UC2DqMK5e9U1wDtybfVLKIGd9rl36fXXtzdSejuTXRsOokp6IHNAj8uEYrdbnNA4d55YqiItk1FOGYS5EVMcYJRoe/gvNWK7Y+VafKwZO1wxXIVaXVWnA+3u+CsNWeZ9diNQQA6QwI9jO6nNISzsajGtE5QmDKJTEo83b499iXGNNJgEbB+Om49qydrIqP4F08xu8FDdIU26x6tPUJQxTbt6HkMM7eB6d89AoeAeR7CYr6p9mNSLEyekmr3XZqU4F73tZShooaAlYK1+J/AEe9HC0li17nmUq1ZSNAVbG288spkdC9A6PgxyCbW6GXw8MO4NGrx3jG9o8ucykF0G/mzfImbCzppa3Y+nir95tERiHnZhZtQ4I/8wJdbY+1iSvapCpLK949/fHD3NioomcQQSswp/ETc+xbMThEjR1tdSJDpXwM5REIs/H1fWgzgcWQfywdtrBZ9EDsW3PjH66LXd9zg0zx0YR7lPBWqaiYRuOTpsIhPeoeBcp7na7Sy5KhyrTWsJbCLCYmdpcUMAHoIcrA+ni/aBuF1LN3ItCM9Kw8uy2Eaq4ewUbmEPE6ZrOjCfjXIfJnd9XkBVyD3V/MmWGN6l0cQwhxG3fMTsouq6SuKpLS3m8oYug1DyA0cNgPWnKUrhoTNzSGiCFQF8m1JjJ8FehaKt3hCJYdKYMYpKIgK/YlnvOFy49p8ApYybZ5en8xJTP4eNXMX/5I0nmEYwhCScaBjyq4CubMPhn/qU2l8YYwo8PwuXrWFUUzMBrb0QrK9rOarTfZElxDHj99j7mn8Mrsvm/K7nalbfC8eRehghYLOZ8qwHOI3p5rqEt7EThsH8wlnDEvG3kK6Lw17qjevxPmQnJmqMh/zfYkzcg8o TwgYfR8w Q1i80tlS0wxAc0CQA2m564w4AgpcaapF42Ghc6k6tw/ffkmjkmUMK9ZEZ2cg8GkgZfNQEbRMUkPE98QFVa/zTJ5YzvWSawPYd9GzHEdXAFCldVqR02QlVmsAdE5pncYcjzKdx/9alDTmOZRIZJm5iSBuaIc3Bht2YFFz7ezrUfwdGbGp4jX+nExTzn4DBV14qaOasqFpPNmwax5fVWOgw0t/uHbq/gkhH8JxBNaEWjZZDksrsox5Rui3w2GgJKXH+x/r1IIvu+JMcgCv8/EOf1qCabriDNMW1zIVGU5+CprXPTdeRqJi0ei0jog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 10 Feb 2025 20:37:57 +0100 David Hildenbrand wrote: > Ever since commit b756a3b5e7ea ("mm: device exclusive memory access") > we can return with a device-exclusive entry from page_vma_mapped_walk(). > > damon_folio_mkold_one() is not prepared for that and calls > damon_ptep_mkold() with PFN swap PTEs. Teach damon_ptep_mkold() to deal > with these PFN swap PTEs. Note that device-private entries are so far not > applicable on that path, as damon_get_folio() filters out non-lru > folios. > > Should we just skip PFN swap PTEs completely? Possible, but it seems > straight forward to just handle it correctly. > > Note that we could currently only run into this case with > device-exclusive entries on THPs. We still adjust the mapcount on > conversion to device-exclusive; this makes the rmap walk > abort early for small folios, because we'll always have > !folio_mapped() with a single device-exclusive entry. We'll adjust the > mapcount logic once all page_vma_mapped_walk() users can properly > handle device-exclusive entries. > > Signed-off-by: David Hildenbrand Reviewed-by: SeongJae Park Thanks, SJ [...]