From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF6BAC0219E for ; Tue, 11 Feb 2025 06:38:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24A5728000A; Tue, 11 Feb 2025 01:38:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F9AD280008; Tue, 11 Feb 2025 01:38:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09A5A28000A; Tue, 11 Feb 2025 01:38:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E2588280008 for ; Tue, 11 Feb 2025 01:38:02 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 850131C88D3 for ; Tue, 11 Feb 2025 06:38:02 +0000 (UTC) X-FDA: 83106708804.14.5A9697E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id DE8D71A0003 for ; Tue, 11 Feb 2025 06:38:00 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UCekxHfR; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739255880; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QRIpwzPg9rZjyK2gXTtSDP/+M9xjf4pdNu7X6w0vGL0=; b=teA3IiAGN1HHYK02e2laN9RXXGkFhfnz46wXKh5GibJQbB55bYTzjxv+weLQC88PNcfAnb Iwz359wtsF9iBhiNOXkSycSEn4DcpWhwFEmWBDuoc/c5uLpNwOXmPFxYkjCbKnDH+486GO 9Y5eda9nQ7kJ1eFi6e4Krac8BxmKCPE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UCekxHfR; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739255881; a=rsa-sha256; cv=none; b=K4FynuEFq8jZ+ePKorXTDEjSciMi9euT8h5vgZCyF15yGK4k778yk/EZEHbFwtFtY5Un18 P9mL+Rion+MGnUzPXb4LtK3O1MSGBYMNJWmuVKimk/Su9p4ngZFKMv8wJ25nNiAdcWiqHK JcCzrO459dGw4G+GYmAOK9amybF4jjw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0F64A5C10F4; Tue, 11 Feb 2025 06:37:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E975C4CEDD; Tue, 11 Feb 2025 06:37:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739255879; bh=6uZQgoR0uA6VEsip3oI4LwHkKy77TFCniPhoImzlKOc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UCekxHfR3Vwbv3V8w51eiJPq01SQgFoFy6WDbLi5JFN0sQymjeUpfZiz0r51D06Vg ztCTiCn/L5pMHlrdhh/gJbPeN84HGuJEMNDsaw/buy3N/nWpwEvnhJ59CtAP+F29VV WH44U/WtrWjXkx2vygzOG2vGkuL1gvRFhV0I6QXbHoulSihJmlQopL8BJCbQ++l8WP ilicZ9uBPek5stvyD6Snk0Wdr/G3AczCJv1Ai/z7stMpyWSHAHFeE2pgh4TyRD0Phw 1ekVM1AkRk+uK1YmYgRjEkoeZcz/XBlQCOTczDhjnMTeg6P/4kXN/E4Hka6Tvk/qP3 JMGFAnJtOv5jQ== From: SeongJae Park To: "Lai, Yi" Cc: SeongJae Park , Andrew Morton , "Liam R. Howlett" , David Hildenbrand , Davidlohr Bueso , Lorenzo Stoakes , Shakeel Butt , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org, yi1.lai@intel.com Subject: Re: [PATCH 4/4] mm/madvise: remove redundant mmap_lock operations from process_madvise() Date: Mon, 10 Feb 2025 22:37:55 -0800 Message-Id: <20250211063756.5195-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: i5g9phu8uu9by1deyjrjju7wdsdusrmu X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DE8D71A0003 X-HE-Tag: 1739255880-785635 X-HE-Meta: U2FsdGVkX1/SWH6eIITI1JwcnkV33B0TFJyEqEGMrqcT8E7YQBqjHSXQA19/Y2GMelQkkF0iYl1pEoGcfCgpHq0Han+91ZmucJrKUd5fY4WkwGzB0fuUy4XxA6gAXAVm1PtCV3XcACQsuvzcFKrV/aAi//Qq2KqWxpO2U5M4roa1HxIYZuj4JR67927Yw3hqNzrdHc44/Hx9gSuMS98rLsKDbeATOyzEMKt7wS6QRdUjRKi3gd6cotifZROek/OxyMahiqSDJ03Xip/YVIVsLiNhZHHpBC/U7uV/O9DBrUxIbkJz+SnXKVLh5yfdjuYp+lKFrUO9IPAzJxPqxFGR7+0xDmYOKJuTWLThpC3tY8EMyWVhkr20Ze+/omqLTwV1G3cd104ki5U4fk/kqdSyXfNl8gcLbcGh3BpoAe9GDcJfP7A8zpU9PnnaHTpPgpwpK9K7eLH6rDHbvbr288pqNKq5Ckf/YSNPBNAFfa9Rbr4XTK+eKSN1gWKogYtp+/RQLit0wO0fiL3LvUBiJIb3NMrpAYtdgD/6C0gzXFRQ7FRB57MEflJBC3nwT44Qpx4RRkjOT7lXF8tUZN2MEYmuyTa+3nzQLxpdyUXXzgIDdxBFet6QxmQ2bU9t6TV8AkqYF7MgIyvrfoYN+SVD4xk+U6oXHJPYTS+ZDVQu0cUQsVFNTqIAW3pDsMqgteOJIPZBw+O1vPLJJ9dOYY7P3SLaW6Ts4eKSNPwaOUVAhrGNeCjZ3tcz2Ket6yTyExkM/Vtexccx9CeTNOsCxXe5Jv3i8LY5ZmTEnjUKCtvCubUDH+PBVydQ+dJS3bBHPRLlkmGeTl+sQy5SvcOHwAe7FwUUODDtQp+KQ98qlq04A22BBW/wjWPwVlEW7pbHXVSOp/PXkK/WDnY1eybh6DwpOkw4SDd1zj5A0odgFH6/o5Y4OWw7YTqc8n2F3TCh72o6JAij0lcove4sWkf/HbYuN0m geZ7VK/v FFiY3/JrnWMJb6Y/BxOq00JOVmO9SNTuJsbgY764tifYfDkj8zN8yHwuPo6bbVYMgZjPkllAO2Y74f1TbcmOZNXTNBUQytT5yXXqPsMp9O0uOj+57zQymrbJAe2CoTVLA8sEzKbQ0qkNryzwRaaUWBUt0S0hgU2N9SIdxacGknFypS3eKYNUWPMXVmiQHORhWxgmGYudNvQsq8cGZD6sVmkuLCCwEL7ZpFCiUj7VA3UrQWsBeXA/dOepn9P1p4itNLBEhctNxn2X1wDZFd75e3K7GLm23XHrQPGKJltpRtaLaXmsb3dhUd5ONzg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello Lai, On Tue, 11 Feb 2025 13:30:49 +0800 "Lai, Yi" wrote: [...] > Hi SeongJae Park, > > Greetings! > > I used Syzkaller and found that there is WARNING in madvise_unlock in linux-next tag - next-20250210. Thank you so much for this nice report! I just sent a fix: https://lore.kernel.org/20250211063201.5106-1-sj@kernel.org > > After bisection and the first bad commit is: > " > ec68fbd9e99f mm/madvise: remove redundant mmap_lock operations from process_madvise() > " Nonetheless, I think the real first bad commit is f19c9d7b57cf ("mm/madvise: split out madvise() behavior execution"). I confirmed I can reproduce the issue using your reproducer on the commit. And I think the fix may better to be squashed into an earlier commit, 948a0a9ea070 ("mm/madvise: split out mmap locking operations for madvise()"). Please refer to the fix for details about why I think so, and let me know if anything seems wrong. Thanks, SJ [...]