From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CB14C02198 for ; Mon, 10 Feb 2025 21:21:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F27DA280031; Mon, 10 Feb 2025 16:21:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E6163280007; Mon, 10 Feb 2025 16:21:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2BC0280031; Mon, 10 Feb 2025 16:21:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A9840280007 for ; Mon, 10 Feb 2025 16:21:51 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5ADA54730D for ; Mon, 10 Feb 2025 21:21:51 +0000 (UTC) X-FDA: 83105307222.02.AEC5CE3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id B795B1C000B for ; Mon, 10 Feb 2025 21:21:49 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hneJpaSk; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739222509; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EvE1G6G0N+hlj0P4WFgMk7lvRC8yOW1eRJczpp6IPLw=; b=4uYUa90BOthDTnsDN2FzIuck74Zd+kvUvTw4N5FDmXejamGCX22vpc5rDdv0xh3GfeXRip wsE1MxH4c2nEkt9C8OfYHJJVmfkPV9nBRWqc0hHiixcz6+WbUZPIYXvrP2UH6pWvcY1dZI ccwMz2VI1JAzx7QlrO55WXARPQU8j24= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hneJpaSk; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739222509; a=rsa-sha256; cv=none; b=25EQAKLiIXyKhg3M2+3Hjc5EeHpREnjrubizhk1WOxqR7ORq3TR9pOEWUjHmIQyQ+iUveo e+yoOFeIAujwOprUmhPA4F9EvoZy1wKpLAyizK5cCk9gl72wXSDRIdpxV8PE8njqvjVEx2 kS4IhJrQ1zndi8QIk+OPydwyv3VSZwE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=EvE1G6G0N+hlj0P4WFgMk7lvRC8yOW1eRJczpp6IPLw=; b=hneJpaSkje1gE3BmYU7XmE57YP 45qNvECcBJYO6UPKtJWLaUrMG4mKEN/gikVhdzSwWuVGH6vGz6C3/hUFmUyIlMO+0cNl/D5wQF5f4 VeFzt+/9Fmt6K0HCYIukUnJOD+xOQ3VOcrr6nTLR6CDrFWjZuzUSPnh2Kc70cE6B0CI8fCENI9iTu IQSrmCdilnaNCm8JvlXRTwGPtcBzC6ELQhqFz6EZinTq9/qh/CXB7Jiy3KoGGpETgUtrVQRR3gQdq vq4ARsaOWQeMICdgDiCQ6rXgGszGhzk6JOmr3SmWeSv+CsP7Nzqz7y1itAZoJNEx4C7eHfUZfOQ8j 1ke6HaZQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1thbDt-0000000GnC2-0PjK; Mon, 10 Feb 2025 21:21:45 +0000 From: "Matthew Wilcox (Oracle)" To: linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , David Hildenbrand Subject: [RFC PATCH 1/3] mm: Constify folio_mapping() and swapcache_mapping() Date: Mon, 10 Feb 2025 21:21:39 +0000 Message-ID: <20250210212142.4002210-2-willy@infradead.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250210212142.4002210-1-willy@infradead.org> References: <20250210212142.4002210-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: B795B1C000B X-Stat-Signature: wwfmpu5cob8ofa6cbimggfeg8bn977fh X-Rspamd-Server: rspam03 X-HE-Tag: 1739222509-820739 X-HE-Meta: U2FsdGVkX18IO+YBoKIWVuvYhsM9iZHktXgnBu1CrbTDTrz+y8OnLKzpgs/hJlYT5J9Auf0JvgeGpHS0ICrAtBy7d/IarJboAfC4I5VXJgXb91fEa0l3Ub2Y/aM+7Yts5/XF9NmA46BhfXdDa11FD/laB8JZyeIeBQoZpuhk0dZlMnfmXkDJeSi45D0k3V/TFAZb4anNRRw1VtWIAq2oBE7/84JAZNVSKHSRb5i6cOggBnR9IGQBv3qU/hAYK7tXRaJaQqfeoMH/k4kOhjl4bfC+5TMTh41kl3AHs1wbtU9qsc7r3BVIJ7e1rpUXHDAvSPoTa167f8S/iOmzcevysaSQH+AFK9boXgezBhzXC0MtcmDOTZkaNZLDyZmSJZOdlP5PyC+f6lZZ+fm3JhtD3BEBlUpXPzaExJ2Eu6MZNg/XNVNK/IVCaNrUlEJJ8LU2mGJp56sHl+dzU8NHatK6XnoFAcJwrORfN1cTvNaDyF1BNYJCI2xNPxYe6g8ydcV20R44LSaBVmOE4FVuGxQWUfOymmloDjKyNuK8P7dK6iy66XiPzlj2zmXkmh/3PM6KMpDfUxzysQSTvvUi7xgX8jM/C8xwkJs+GO9p+AMr0/VIHrjtjjbh6GQaVTB8kFwPqfkQeQJEx8R1MMqAmXK/m960XrxQ0EhPEjWtHukUGFIX30tZ8m3N8TEAqDMMJiZcIwwOAUaz4U/rqfbeRmW6AvPp31aoyHVCdkDlRWNHXJ6o0GYCTkgmT8Uf4/LPllJr4BawitaGvVPjlT0nIeUFqI8RnzVhdKg2ieVQA1dcaq8OvKeAew1e0QLy4r3LHOhGGnzv1QgaJm8J3Pmi2muNhXkmVKMqYjq2QubIjN/RpZIDZ/P85T4FVQex4+L/HZdlSb7M8N47tTIuKppa9DHT0nGZHQNcS7ZMcydUw25imevVF9Ny4tXl5apyVtZS9K5HtM6eoZ1m7ZmFRkXoEfA KJQp9FO0 9LXVEYW4PFOaofv3rW0eg6qGq8QfFrtq5CnZy57+PvyjoQez/CmVVFkErpWQ3HuBWQkDm73lJxSeWJTK/WMmLrjIEoYj7OtwiXJ+B7ePIMHMUUDCcXlAXOlX0yUZVoAWqsPIOohp5stq2a2AEVMM+OIX4WYPIrjk0cM/eIakiR3TSHunz92/2obRclLFplmxFHwX+CYjHTDbJrVOAf4eHe2DGom1cqywixISaWw8CNQyZzy74Im+sTtWHsPl0PUsdENPyl7o3V9KI5ZH+LVN3vlZZw8W0L1IS5mIy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Neither of these functions modify their argument; make it const so the compiler knows this and can optimise accordingly. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagemap.h | 4 ++-- mm/debug.c | 2 +- mm/swapfile.c | 2 +- mm/util.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index 47bfc6b1b632..8a9b2d201706 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -532,8 +532,8 @@ static inline void filemap_nr_thps_dec(struct address_space *mapping) #endif } -struct address_space *folio_mapping(struct folio *); -struct address_space *swapcache_mapping(struct folio *); +struct address_space *folio_mapping(const struct folio *); +struct address_space *swapcache_mapping(const struct folio *); /** * folio_file_mapping - Find the mapping this folio belongs to. diff --git a/mm/debug.c b/mm/debug.c index 8d2acf432385..fa3d9686034c 100644 --- a/mm/debug.c +++ b/mm/debug.c @@ -67,7 +67,7 @@ static const char *page_type_name(unsigned int page_type) return page_type_names[i]; } -static void __dump_folio(struct folio *folio, struct page *page, +static void __dump_folio(const struct folio *folio, struct page *page, unsigned long pfn, unsigned long idx) { struct address_space *mapping = folio_mapping(folio); diff --git a/mm/swapfile.c b/mm/swapfile.c index 6e867c16ea93..ccaed8c2f761 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -3658,7 +3658,7 @@ struct swap_info_struct *swp_swap_info(swp_entry_t entry) /* * out-of-line methods to avoid include hell. */ -struct address_space *swapcache_mapping(struct folio *folio) +struct address_space *swapcache_mapping(const struct folio *folio) { return swp_swap_info(folio->swap)->swap_file->f_mapping; } diff --git a/mm/util.c b/mm/util.c index b6b9684a1438..682ecdb1b1c2 100644 --- a/mm/util.c +++ b/mm/util.c @@ -845,7 +845,7 @@ struct anon_vma *folio_anon_vma(const struct folio *folio) * You can call this for folios which aren't in the swap cache or page * cache and it will return NULL. */ -struct address_space *folio_mapping(struct folio *folio) +struct address_space *folio_mapping(const struct folio *folio) { struct address_space *mapping; -- 2.47.2