From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BC46C021A1 for ; Tue, 11 Feb 2025 05:00:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A6E828000A; Tue, 11 Feb 2025 00:00:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 75656280001; Tue, 11 Feb 2025 00:00:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F77E28000A; Tue, 11 Feb 2025 00:00:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3C3CB280001 for ; Tue, 11 Feb 2025 00:00:07 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9EF6F160E30 for ; Tue, 11 Feb 2025 05:00:06 +0000 (UTC) X-FDA: 83106462012.05.F79B253 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id CD9C21C0011 for ; Tue, 11 Feb 2025 05:00:04 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=S9loGqeQ; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739250005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TqJfXYLLX/FBxHKIdTpo25uYjZjQJDafI8EAFu4UOzo=; b=GPdqHDxT50WcLGoB3D0TwVX0FQ2ekPl5bUwQCuD34lOb09gb2cvUf/pKTGvJ+zaRj/as4F +R1E00AZJ0dSoqKZ9Qu4LWnudn30Osya8NeJIEWzR/EMF1Zbfwf9IOQmis2M4L/zsfCyfT KnCqWiZy0EZGiau1e3/C08/818bVZD8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739250005; a=rsa-sha256; cv=none; b=dX6Nhq8bKVQXMaHkmx4OYTO5z7V/UdyipZyWzz2+IWpLQShVsAuQCFzjqHJXUQeomenCIP hV5L7+dMczHhaHHXq3z91oU8wktoV9M8T4hBR5jzZLdpBrMZ324s+AAZy0L2AFqw8WYi2p 69IiRvPxm9uBEct/lYXKfvbkAYSvjbY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=S9loGqeQ; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C5AA45C054C; Tue, 11 Feb 2025 04:59:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1665BC4CEDD; Tue, 11 Feb 2025 05:00:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1739250003; bh=hSVMPStI+Sa06Zw2UUdsDpFB6PeSjrO7Ar0sTb6ValY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=S9loGqeQDU7+vM38oniXF9UbZSirIh9+AO7Zw4TASDwdfymSr+mlfND6bI6t+H591 EasGPa45my4fsaWku4WH92kHww4+2JkBwnl465H/iEUc11XXeQH/XfB+bBTEoAU8I8 4Q+hnPRTreXNg78LWQqzxO4EbCx+u8jUUn5NvycY= Date: Mon, 10 Feb 2025 21:00:01 -0800 From: Andrew Morton To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, nouveau@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev, =?ISO-8859-1?Q?J?= =?ISO-8859-1?Q?=E9r=F4me?= Glisse , Jonathan Corbet , Alex Shi , Yanteng Si , Karol Herbst , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , Masami Hiramatsu , Oleg Nesterov , Peter Zijlstra , SeongJae Park , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pasha Tatashin , Peter Xu , Alistair Popple , Jason Gunthorpe , Simona Vetter Subject: Re: [PATCH v2 03/17] mm/rmap: convert make_device_exclusive_range() to make_device_exclusive() Message-Id: <20250210210001.5dc68b38eb1bfa44d0fd78f6@linux-foundation.org> In-Reply-To: <20250210193801.781278-4-david@redhat.com> References: <20250210193801.781278-1-david@redhat.com> <20250210193801.781278-4-david@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: CD9C21C0011 X-Rspamd-Server: rspam07 X-Stat-Signature: sqri3chfewb4qsa8ufx93tww9bd9h5qi X-HE-Tag: 1739250004-660704 X-HE-Meta: U2FsdGVkX19Q+wUgfhHKpGzfoUZb15ZdSKjoh0WfQhhaMy7oGwa1GAJ3o6eWJu9MRA3wdtE2yB/xi51JpR3l5NGY6sEUNx7q6yTvB7g69PmqYzoYAcDRFCiWOgaBC7QvLzTa11lFf3pjxiofAN+imlN2d4bYy88QZH2pagTBPkXsZhGoTITaVaNU4PTC/nU4dxGQXSMhDLGKjfwamVzR6wyzMXySGnZaJuN9svXvw92K3rAnay68f9MKJyzEt1UwGKdueDrybeehTIcfCdV9z4jqI9ImdcP3h9qIdg6i3gLRQp7GuwXDcsMvNHrv1sbyrLbWbHZ0HeydQPmyEZOBO0vOUvx759ijgHC27sm4ReNcsUFoGzFPm89XcP/xTQA5db+9n82Yh68S1c13LPVmw3GiL05gaLn0C0TZws44BmqDYOG6gRC6LJi5DpzoGV61TCQqlKTj3bPd98mpN9jZFsdBfzBbJhvMp1y07e8uIzEaeS/p1DYt3cOhyJayZJwnuidF2LzNy0/vuvExv+zUPumcKpU3fO0PagL7S4dWuIUlddIPZ9ucE/TsKte/lol5doG/1ysmDYYzIn6X8GE0ZWqAPCHJZI0OVUY7/T+5ghUeOW3uwRd1I8w6eJF9ogWIFllxEO2LID/MdKGrAEBg7SVTHZoLwgh29TVB8mI1XwwgY2pg6H+akwE1BZxqPjhojQKlW55s71nNlS8nbnJ/VdAxqziOkjK4LxPiOu4rdEWNyaMofU+xaEt56At0dLdtrpZWsfPE7O02vFl8tFvpd8nHJfLgb5wMvsmYpFfPgNpK0jxQlU3q62ODKVD7fBPRfKkUsWAHEzG5HBVBxeLJUWROMFT4PCIs9QY38KE/yw7BnTDRpc/s68fvCtOHQPwHbekJrp+E4q7LdEm+wLoG8VM4rzCo62GCOlUnHwgHIQiaLX+htxJaE4BfA5d7SpoLIl4z/rqkHg9J+/eiZkF /SawWTAq H2yexqYxS5EDgzxCsUonHDuWasoFwp3HHiOzaMlnKaQwh+Z5RSekorD5fdo1uyUSIKEoJyeQgRdfnHiN3845EP5QLR9ck/3I//WavVEawZHxDGffERdpUmAj34LuyK3gWtnJTRHRx8br/MXb2BiDedIH9q91aJomUsWSXM4IzJ+L9vXv+wfbmk+ji+99Bk4sBGbq7+/z2yFt3p2hWQPpAUKIVt/DWY9k2LvFZ/YlrGWtjg+grs2+Nd6kH2gIxe2+cmp6zaklpbOmLhCtSlPVQgrWGOnm50+EAHzwI3aoMV0YmY30ufafI9iZGuZx9erDqde3o X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 10 Feb 2025 20:37:45 +0100 David Hildenbrand wrote: > The single "real" user in the tree of make_device_exclusive_range() always > requests making only a single address exclusive. The current implementation > is hard to fix for properly supporting anonymous THP / large folios and > for avoiding messing with rmap walks in weird ways. > > So let's always process a single address/page and return folio + page to > minimize page -> folio lookups. This is a preparation for further > changes. > > Reject any non-anonymous or hugetlb folios early, directly after GUP. > > While at it, extend the documentation of make_device_exclusive() to > clarify some things. x86_64 allmodconfig: drivers/gpu/drm/nouveau/nouveau_svm.c: In function 'nouveau_atomic_range_fault': drivers/gpu/drm/nouveau/nouveau_svm.c:612:68: error: 'folio' undeclared (first use in this function) 612 | page = make_device_exclusive(mm, start, drm->dev, &folio); | ^~~~~ drivers/gpu/drm/nouveau/nouveau_svm.c:612:68: note: each undeclared identifier is reported only once for each function it appears in