From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 648EDC0219D for ; Mon, 10 Feb 2025 23:29:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1CB2280008; Mon, 10 Feb 2025 18:29:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AA56A280006; Mon, 10 Feb 2025 18:29:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96CDD280008; Mon, 10 Feb 2025 18:29:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 75354280006 for ; Mon, 10 Feb 2025 18:29:02 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DE0FA80786 for ; Mon, 10 Feb 2025 23:29:01 +0000 (UTC) X-FDA: 83105627682.17.4DAB8A9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 2F5A4100002 for ; Mon, 10 Feb 2025 23:29:00 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=U6FpgS1h; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739230140; a=rsa-sha256; cv=none; b=JklRYB+kq8Y56uohLv0qCXdwvyF97YjjygszTOzaZu9vP4x/Y8IM00K6NNeiaLb/zL0nZ/ a12UinVYLQ4G6eswbvwUsvZnUg/B1F1woHEUNUmnSugF3I3rDLVCjhsyrDgUzpKx4obX3x 7lqo5dkU8mt9Bp76wbd8lNE2xN7McMw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=U6FpgS1h; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739230140; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ABh8ENE3n+roZEaWwm7ZCVISpY02cE6fy9HyLCb+htE=; b=SnmtxyQ/eXtgg0ujzvb1+SQ6xSK1kkZblgYq6KJfsq9J8XD+mo+n2V5CxVnYaxmhgaVDh+ QclGdijgY4/OLMh40vXVZ7HtP2zVOePiYk6bycX+uQrUoypLmGgOUjbKQXkgj3v/fCySba cJefJkob6UTrJ8gMiCKkUP0hT+M9GaY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id ADD885C5F8B; Mon, 10 Feb 2025 23:28:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABB34C4CED1; Mon, 10 Feb 2025 23:28:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1739230139; bh=VWwKenO3pHoeNahD4JXaMTHRRxYv4FgRe0zy5LWl2TI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=U6FpgS1h8JWx6/e7lpOWx0bk4AAxwgyk5CQXyRU/412J5S2J9cMfDWBmNjqMAd3CH /LuxvmXfFZNsX0dp2Bc5+WXjD0pJ5zCHBZgCDJtN2fESjTIFb9Z0GevkysNM8dUany wH0Sza9cbH4H7Km7VsEjwA5q8nA5VptULEK6V/Fw= Date: Mon, 10 Feb 2025 15:28:58 -0800 From: Andrew Morton To: Frank van der Linden Cc: Oscar Salvador , muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yuzhao@google.com, usamaarif642@gmail.com, joao.m.martins@oracle.com, roman.gushchin@linux.dev Subject: Re: [PATCH v3 00/28] hugetlb/CMA improvements for large systems Message-Id: <20250210152858.58e6ac26b9cd6e2a36aaac8f@linux-foundation.org> In-Reply-To: References: <20250206185109.1210657-1-fvdl@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2F5A4100002 X-Stat-Signature: yekf1ewtp6p8en9y6qeciyrmqfwj5kss X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1739230140-453017 X-HE-Meta: U2FsdGVkX186PIovL8ykf/bT0ntGE8G4O0LLfIBqPyKq0hW4rT+XwILjr2ViOflV3xhEFzd6DMf0daFIe2FP/5TKoEUQgm4mA+lzlpOsdYktjEgKdYGElgO+vBr/Kv5lvuUSl7ytHVHbfe9lW0GfmXYagKormDOVfSDZH99c+fgW5H6MLi8FIhQl2obrM78gJPt0MSYqkFBXHjKtMWfiFrNTu0ZqZFo9M1n4v54wFONeoHergFktXc932UuBGjamskiFuzwXiZaQJIW1xebkoDGpk3jQg3CGPDRP07mX8h0zNTm+yz86PFgeoaLA924zBARuGVUjMaCAxZtSV1KGzbnZYktffqjBJruuvUvBYqdM+li+aqRHv58b05lR+NZSuti14j5SFneROJn6pComvjVTVpMPHjPiOpak1ujLuu5vkvrKCR2/T5E2wuXiYcpDCB/SHKLpSX2Sh1rGAKK1EwTVdCZkp7N9QmNtCEeF0XWl+nmVDspzdOrTS7IaC9ZGWA/ASe6BHFfhKQ4ie6GZXue02s0zDWER9PmyztyLMUBD3JirEORtdDXSpdVGWzr6mg22ArpDqHGZNWikO9USlldrTvh6VER+Z4usClUrPmVIO+wBDFpNjVWBBAI8F/TLB6qEI8NKDuXLN0tNqE3VlQEtumcC0KYc+3412xBlD0bjQrCAfsljzcIDJtZ3/ZciykUkswljs+iZfupA/xnoq6s56uCLgXkqi6nBXtSSzksr52MAF1bZsOL3BgCAobZRoqG0SXsRwjZ9CgVrXX3yt0jY7Mqo/EO8UXIaDHqT5qUbl6YoA8CDHqaM8zqgpUFZ3275+Q5pjSAstRNFLCCFuTegrFMjQMTSHMZFCKWJYCT6WONPtYnI91TkzLS1S5i9v/oA5tYWZ6eFJkQD0E7QxuCj0h7OOvbYT4I8N7hCWeN48apQ5vxwzkXFB5tAxy/uZ6EBI+51Yht4yrgnYgb 5NLX6+Ba OQ2efRNG8A0ztJYp98WH5j213ypPwAdHr+hbC43AnW3TG8DLLiAM2fw37udCtK0DRjPcaHkNYQi8rVsZWlY9I+jJn59WMGwRXlxypIsQN3Xn17/Km95UG7gmdChN/4NdBEpxfW1XZfI8Lc6Db3eoj3KHLkhh20DqJinJZ1hVeej127CDJEi11IJSCge0wXN/JFUJWTOK9ei2r7i3xOz6qKF35Tl6AJkNgAJO0JcYUVIPnE260F2mTc3PLHZRyBWA3eAtkKLjUAUjwM6an+WyA5MQzYQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 10 Feb 2025 10:56:50 -0800 Frank van der Linden wrote: > > Hi Frank, > > > > While I plan to keep reviewing the series, I think it would make sense > > to split this patchset into two smaller ones. > > The way I see it, we are trying to deal with two different problems and their > > solutions. > > > > 1) pre-hvo at boot time > > 2) multi-range support of CMA (only used for hugetlb) > > > > I did not go through the entire patchset yet, so I ignore whether the > > respective patches to tackle these two problems are really dependent on > > each other, but I think that would be very interesting to consider a > > patchset per solution if that is not the case. > > > > IMHO, it would ease review quite a lot. > > Hi Oskar, > > Thanks a lot for reviewing this series. > > I certainly could split it up, but here are the dependencies (it's > actually 3 parts): > > 1. Multi-range CMA (used by hugetlb) (patches 1-4) > 2. Pre-HVO for hugetlb bootmem pages (patches 5-22) > 3. Enable hugepages= (and pre-HVO) for CMA (patches 23-28) > > 1 and 2 are independent. 3 depends on 1 and 2. > > So, I could post 1) and 2) simultaneously, and 3) would have to wait > until 1) and 2) are resolved. > > Andrew, do you have any thoughts on splitting it up? I don't see much trouble with the above dependencies - we can consider the three series to be an all-or-nothing thing. Such a splitup would be the same patches, packaged slightly differently. The main difference would be the presence of two more [0/n] cover letters, presumably also repackaging existing material. I don't see a lot of benefit personally.