linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: I Hsin Cheng <richard120310@gmail.com>
To: Liam.Howlett@oracle.com
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	maple-tree@lists.infradead.org, linux-mm@kvack.org,
	jserv@ccns.ncku.edu.tw, skhan@linuxfoundation.org,
	I Hsin Cheng <richard120310@gmail.com>
Subject: [PATCH] maple_tree: Remove redundant mte_to_node() in mte_dead_node()
Date: Mon, 10 Feb 2025 16:35:26 +0800	[thread overview]
Message-ID: <20250210083526.252955-1-richard120310@gmail.com> (raw)

In mte_dead_node(), it already assign "node" as "mte_to_node(enode)" in
the first place, calling "mte_parent(enode)" will result in the same
"mte_to_node(enode)" again which is redundant.

Refactor mte_dead_node() and utilize ma_dead_node() to perform the
parent check without the redundant "mte_to_node()".

Signed-off-by: I Hsin Cheng <richard120310@gmail.com>
---
 lib/maple_tree.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index f7153ade1be5..362f85c62678 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -584,13 +584,10 @@ static __always_inline bool ma_dead_node(const struct maple_node *node)
  */
 static __always_inline bool mte_dead_node(const struct maple_enode *enode)
 {
-	struct maple_node *parent, *node;
+	struct maple_node *node;
 
 	node = mte_to_node(enode);
-	/* Do not reorder reads from the node prior to the parent check */
-	smp_rmb();
-	parent = mte_parent(enode);
-	return (parent == node);
+	return ma_dead_node(node);
 }
 
 /*
-- 
2.43.0



             reply	other threads:[~2025-02-10  8:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-10  8:35 I Hsin Cheng [this message]
2025-02-10 14:51 ` Liam R. Howlett
2025-02-11  6:45   ` I Hsin Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250210083526.252955-1-richard120310@gmail.com \
    --to=richard120310@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=jserv@ccns.ncku.edu.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox