From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC371C0219B for ; Sun, 9 Feb 2025 19:00:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17D326B0082; Sun, 9 Feb 2025 14:00:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 12E7E6B0083; Sun, 9 Feb 2025 14:00:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F37186B0085; Sun, 9 Feb 2025 14:00:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D6AE86B0082 for ; Sun, 9 Feb 2025 14:00:08 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8E6DC161A30 for ; Sun, 9 Feb 2025 19:00:08 +0000 (UTC) X-FDA: 83101321296.11.3ACBB9C Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf27.hostedemail.com (Postfix) with ESMTP id 96D624000C for ; Sun, 9 Feb 2025 19:00:06 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Bin+Q3EU; spf=pass (imf27.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739127606; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9lvcmybcqSmJV69d37kVk3ARuIKqWRF/RWIOT4/WQv4=; b=IyJS/gBLFMf/XgtLOVCjHN6vMpvCnuo0ejO4kcYn1TPE9vTx0eJpZgg8RpthcLWX53V6Lw ExZk7Ehy9EJ2A2p+TwjFHzloQqvAsVIKjd+tlNEQ0ch3FFKpxjfPBzwJch9EioQ7luFKMZ 2pzAyW6K3MuZzzt4ykpNgxlRUuyd2IA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Bin+Q3EU; spf=pass (imf27.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739127606; a=rsa-sha256; cv=none; b=OJNN1x8jKv4VhxrsxxbTTaZHP9EcnDkXb2ohJ8TeoSpcQmwJntFYTOad2NeM+UqcfvF5gC d7fXj7dpUiuwHZ3BgtuOrFQnRxvyyt8LBtM3F/frjOAyHt4yOy0WU5HKhQ7HbvcmV2YBJc 0qsR5RmQ37FrxNw1ig4dKZcop/ChE1A= Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-436ce2ab251so24199515e9.1 for ; Sun, 09 Feb 2025 11:00:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739127605; x=1739732405; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=9lvcmybcqSmJV69d37kVk3ARuIKqWRF/RWIOT4/WQv4=; b=Bin+Q3EUXxG7sBwadyZgi061mMLPhJHglwc92ew5+rsdz0mDfXiDfPI7NfPk9atkf6 lHL5qwkTTX9130P6dd+K+A61lPF0PRAu6aHDnOM1FkZ/5CrZzxJeZCjx8ImVBwGujdQq T44S+KTU+GXdYMXPnrIj2Sfu0uOOarSn+A5LDPN9GBMR9FN3pBsDMiqGvChzLakiW2+6 UCINbe/gVZeajJbcVQoZ7CWEsABwHH6cCFfCXxXo5atyl9+NBAzUarSA9kzuzOUBTZCe hntLlvZGJFoc2S/9srlvT/8GBDBsL/cz7np0azyRlHQ/kFCt8X7/R1I9JY5wvrhumzLS jh1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739127605; x=1739732405; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9lvcmybcqSmJV69d37kVk3ARuIKqWRF/RWIOT4/WQv4=; b=XDWLfFZd9YVd8uGYOGowdGvSxVrCFJdaWE7sTrzTBzNYpauu6KS60RmZg5bT3c5nu5 XOBsSqRReIJyQKk2jWqeYEeY+NftZVRvfN4TctbQawujVC3H9KaJ3O8OveEYEo+18b9e MFOwPB6770i0+5bvZ/AGsF4JSkSY3e3zpVoZwiNBh1IBZLDk0Ff2mvoY3c+H9QTq0RKt Vy332iSTf/NEL+4BLufXwNCOyw+Ad3qDLphSYESNzmj34ZizbLDAqPYgVDeCoYdoDty2 rUfYy8wvVl704WhRTB+ss/uKXanT4eNK9o6Z4s0C+InBeUmqDPr0hppI9lD+CBDRE4BL NhfA== X-Forwarded-Encrypted: i=1; AJvYcCV9xJq+GPHfr48v5xFTnifKSU6dUcK0oPm+ScsuyPDnj8AtGoenGFEINFNwQpaYmcgGk9R56LGqXw==@kvack.org X-Gm-Message-State: AOJu0Yz3o6FF7EY/nbETqF7m10mcpP7oFvxx3AquAC9yYSgP4EMuKXae PXseUbUBa2a/zOZeioffFnOeY5JRHyUpQayCW0SSyubLVY5I1ZaC X-Gm-Gg: ASbGncsgRkByOyHqyMG4AtWXAwaI//J7ZUYnGiHfFimcUuy6cZhpx2hjm6oEkHGQE0G smL6/jvVLTXO7pMoDf+uAz1OGQ+30coPhHdY0oD88kAO3rbWh4Y7nwVqLdj6CnfJGHpS/FarFxy EZRHZSjOHbbQYD6Hlu6I0YdpvXSdNGakeSLmtraYB0vASV4SUkgN4ppw6E65X9c9sUMHoOKBQpV 5Nj8EJUvQezaSqNM5Yten8rZ9GReL1LYtKLfxsB8/rTyP1E0PsEzExOyBZqvjdXmw3C+W2i9mJV GUUOEFb1fMTya8eEc4UaSiPgMeEOi4HtcBC8P0eZSN4ARdx5fYCn6w== X-Google-Smtp-Source: AGHT+IE3vofKjpbREQ1MAELkIaFt3Er/nZu5pZY9Cd7q6ezuSdBAdBXun+LkMT0OQki/bAoKdHA8pw== X-Received: by 2002:a05:600c:4f50:b0:436:ed50:4f8a with SMTP id 5b1f17b1804b1-439249841b4mr97057775e9.10.1739127604819; Sun, 09 Feb 2025 11:00:04 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-439452533ecsm3110945e9.0.2025.02.09.11.00.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Feb 2025 11:00:04 -0800 (PST) Date: Sun, 9 Feb 2025 19:00:03 +0000 From: David Laight To: Jason Gunthorpe Cc: Andrew Morton , Linus Torvalds , linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, Jan Kara , John Hubbard , Peter Xu , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov Subject: Re: [PATCH 1/1] mm: Remove the access_ok() call from gup_fast_fallback(). Message-ID: <20250209190003.661db659@pumpkin> In-Reply-To: <20250209182422.GK3660748@nvidia.com> References: <20250209174711.60889-1-david.laight.linux@gmail.com> <20250209182422.GK3660748@nvidia.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 96D624000C X-Stat-Signature: oyttmhoiiqo61un8oe7o3t6eiiiy64qq X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1739127606-853130 X-HE-Meta: U2FsdGVkX19DoZaFqehlnN8VNQ+dXgQNl6eqiHcZQvDHhI+ov87lhj5xUlRUW1LxBnAgj6NTTPUf86r/JYtqyP+cs38O3fNL8lTxdd/u2CRu2fo9SG4SnSLVGdHarXMZgVCtuNdeSDyOm/qYPXcPx0oyNK0vAoHOTNQgyeSnjNZFoAClzxgpgqb2sqF4loiqaq/M7Bo6tnFxgXS4dlilgKonQn2uceyHr+/PmiyCdu1vRdldosA8W2etfp+qnP/S31Ia1AGNVh6DacufEhj2NIDTTU4cLy+jT+jlxbbAIDm9oiJzX15XlOhVR+wx1VgwNxIiqZ/cuwX1N0X/EgEL12SQmnWmeHjvhHXneFrmZJg6GKhgAAKGUt4heYkK8YRwfy3DWTyhLW1KQbw2lGfglTShGsjBHUvYXjgt2L2bztXdL3DYi0jdr8IXe+yFg4PCJ+5ha/yRxGKKWQIaE7yW9kg5MaER+3oMDgmCn6C0p1TaFCML3Khms5/nyUjnwLOvVt6rVmmunDngaWz/0Y9NuTlgFJF6174NFruhoimlCXcsSsvhphkQB2cINCvmfg/WRzBhX0KFETne3O1pSEWdYf5tnqu59q1u3OKPZyYy/Yjd36Uj6eitfifqS739ZsyPWR22OnxrEoE/6sL3I0s2iLwH0Nqrl7QIk/pI0OUFRswoIqisOFPEBXcAm87E80T/WuegU98/J1jJrHmlSZFwg2CYCQbbvaerAX7vdSTPT9OfMhKmJcwb+hJo8IvP9UKY/B7WLf0tuvqJ+YzUk66qU8S5V1eoLHRRiHmjbzVM/lGf6wHdRiID/GYWWZsQvCxSBeznRy52s12Ea2SyP2enACzDArlAcFLhc+5C2dR7P3JI+q++B00ciKCpAhaZTLCCqOcn1vosL7aO16+MjaALbu6K/dwvkNuTGV+ns31oJTqdfM/hnqVC/LjBdDLfibwMQ3dInJZsrVcWEfxUBdz MixWX0TL N7m8UETf0efFg+eHgSrxZyVsnxfmmsYbbj6TzbbHQfMXWvlRLaFDT8vuJX7e9RyTIt5hxaATUizRJsXyYx4k7fiFXdpLpgspX6Ap8N8adoD4i+GLcTZO+MjdRwiqnukHEgCG36Xp+Lf0YFeeldu+ZKNPwMEGyAaqFja+tkPUWNo0oYxclziL4whg7Hs5NrFlKi0yrg/HtOLNwR/M6K55WZGRpedBWIg/S2XESLKtfTm51fp4Q3lRRKRfKsFdV1Lrbn1quK+XI/qBS7AMwK0bp8BmJygC0xJN52ktXfeoqC9xH6y9p4fbPe5XwaAS9EAY8iWQwaRm1qiixbI1/cjobKPUzM95Io1lJMb/Gj1i5AFNVXZ0eoj0QM9x2uHzpE/7cvxOWzKOxTjSbojobO+WcEA9PwKzL8zoejUr+DpoRpotte/K/3eoez0G2To+4dER6oxSqwqSMfuloX8MjDP/AeH1anWvoz+hJdaqfhEFR0UM1nnQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 9 Feb 2025 14:24:22 -0400 Jason Gunthorpe wrote: > On Sun, Feb 09, 2025 at 05:47:11PM +0000, David Laight wrote: > > Historiaclly the code relied on access_ok() to validate the address range. > > Commit 26f4c328079d7 added an explicit wrap check before access_ok(). > > Commit c28b1fc70390d then changed the wrap test to use check_add_overflow(). > > Commit 6014bc27561f2 relaxed the checks in x86-64's access_ok() and added > > an explicit check for TASK_SIZE here to make up for it. > > That left a pointless access_ok() call with its associated 'lfence' that > > can never actually fail. > > So just delete the test. > > > > Signed-off-by: David Laight > > --- > > mm/gup.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > Reviewed-by: Jason Gunthorpe > > I often wonder about about access_ok() calls, if they still do > anything.. They still do 'stuff' and end up containing a slow memory synchronising instruction (to avoid speculative accesses controlled by the application). But there are better ways to handle bad user pointers. So, mostly access_ok() isn't needed outside the architecture code that handles userspace accesses. David