* Re: [PATCH] blackhole_dev: convert self-test to KUnit
[not found] <20250207-blackholedev-kunit-convert-v1-1-8ef0dc1ff881@gmail.com>
@ 2025-02-08 18:26 ` kernel test robot
2025-02-08 18:36 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2025-02-08 18:26 UTC (permalink / raw)
To: Tamir Duberstein, Andrew Morton, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Simon Horman, Shuah Khan,
Nathan Chancellor, Nick Desaulniers, Bill Wendling, Justin Stitt
Cc: oe-kbuild-all, Linux Memory Management List, netdev,
linux-kernel, linux-kselftest, llvm, Tamir Duberstein
Hi Tamir,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 2014c95afecee3e76ca4a56956a936e23283f05b]
url: https://github.com/intel-lab-lkp/linux/commits/Tamir-Duberstein/blackhole_dev-convert-self-test-to-KUnit/20250208-074037
base: 2014c95afecee3e76ca4a56956a936e23283f05b
patch link: https://lore.kernel.org/r/20250207-blackholedev-kunit-convert-v1-1-8ef0dc1ff881%40gmail.com
patch subject: [PATCH] blackhole_dev: convert self-test to KUnit
config: riscv-randconfig-r123-20250208 (https://download.01.org/0day-ci/archive/20250209/202502090248.Ed6S8p8J-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 14.2.0
reproduce: (https://download.01.org/0day-ci/archive/20250209/202502090248.Ed6S8p8J-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502090248.Ed6S8p8J-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> lib/blackhole_dev_kunit.c:55:27: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be16 [usertype] payload_len @@ got unsigned long @@
lib/blackhole_dev_kunit.c:55:27: sparse: expected restricted __be16 [usertype] payload_len
lib/blackhole_dev_kunit.c:55:27: sparse: got unsigned long
vim +55 lib/blackhole_dev_kunit.c
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 26
a644885645ce867 lib/blackhole_dev_kunit.c Tamir Duberstein 2025-02-07 27 static void test_blackholedev(struct kunit *test)
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 28 {
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 29 struct ipv6hdr *ip6h;
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 30 struct sk_buff *skb;
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 31 struct udphdr *uh;
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 32 int data_len;
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 33
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 34 skb = alloc_skb(SKB_SIZE, GFP_KERNEL);
a644885645ce867 lib/blackhole_dev_kunit.c Tamir Duberstein 2025-02-07 35 KUNIT_ASSERT_NOT_NULL(test, skb);
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 36
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 37 /* Reserve head-room for the headers */
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 38 skb_reserve(skb, HEAD_SIZE);
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 39
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 40 /* Add data to the skb */
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 41 data_len = SKB_SIZE - (HEAD_SIZE + TAIL_SIZE);
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 42 memset(__skb_put(skb, data_len), 0xf, data_len);
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 43
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 44 /* Add protocol data */
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 45 /* (Transport) UDP */
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 46 uh = (struct udphdr *)skb_push(skb, sizeof(struct udphdr));
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 47 skb_set_transport_header(skb, 0);
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 48 uh->source = uh->dest = htons(UDP_PORT);
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 49 uh->len = htons(data_len);
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 50 uh->check = 0;
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 51 /* (Network) IPv6 */
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 52 ip6h = (struct ipv6hdr *)skb_push(skb, sizeof(struct ipv6hdr));
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 53 skb_set_network_header(skb, 0);
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 54 ip6h->hop_limit = 32;
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 @55 ip6h->payload_len = data_len + sizeof(struct udphdr);
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 56 ip6h->nexthdr = IPPROTO_UDP;
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 57 ip6h->saddr = in6addr_loopback;
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 58 ip6h->daddr = in6addr_loopback;
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 59 /* Ether */
843a8851e89e2e8 lib/test_blackhole_dev.c Breno Leitao 2024-02-02 60 skb_push(skb, sizeof(struct ethhdr));
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 61 skb_set_mac_header(skb, 0);
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 62
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 63 skb->protocol = htons(ETH_P_IPV6);
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 64 skb->pkt_type = PACKET_HOST;
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 65 skb->dev = blackhole_netdev;
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 66
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 67 /* Now attempt to send the packet */
a644885645ce867 lib/blackhole_dev_kunit.c Tamir Duberstein 2025-02-07 68 KUNIT_EXPECT_EQ(test, dev_queue_xmit(skb), NET_XMIT_SUCCESS);
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 69 }
509e56b37cc32c9 lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 70
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] blackhole_dev: convert self-test to KUnit
[not found] <20250207-blackholedev-kunit-convert-v1-1-8ef0dc1ff881@gmail.com>
2025-02-08 18:26 ` [PATCH] blackhole_dev: convert self-test to KUnit kernel test robot
@ 2025-02-08 18:36 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2025-02-08 18:36 UTC (permalink / raw)
To: Tamir Duberstein, Andrew Morton, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Simon Horman, Shuah Khan,
Nathan Chancellor, Nick Desaulniers, Bill Wendling, Justin Stitt
Cc: oe-kbuild-all, Linux Memory Management List, netdev,
linux-kernel, linux-kselftest, llvm, Tamir Duberstein
Hi Tamir,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 2014c95afecee3e76ca4a56956a936e23283f05b]
url: https://github.com/intel-lab-lkp/linux/commits/Tamir-Duberstein/blackhole_dev-convert-self-test-to-KUnit/20250208-074037
base: 2014c95afecee3e76ca4a56956a936e23283f05b
patch link: https://lore.kernel.org/r/20250207-blackholedev-kunit-convert-v1-1-8ef0dc1ff881%40gmail.com
patch subject: [PATCH] blackhole_dev: convert self-test to KUnit
config: i386-randconfig-062-20250208 (https://download.01.org/0day-ci/archive/20250209/202502090223.qCYMBjWT-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250209/202502090223.qCYMBjWT-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502090223.qCYMBjWT-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> lib/blackhole_dev_kunit.c:55:27: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be16 [usertype] payload_len @@ got unsigned int @@
lib/blackhole_dev_kunit.c:55:27: sparse: expected restricted __be16 [usertype] payload_len
lib/blackhole_dev_kunit.c:55:27: sparse: got unsigned int
vim +55 lib/blackhole_dev_kunit.c
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 26
a644885645ce86 lib/blackhole_dev_kunit.c Tamir Duberstein 2025-02-07 27 static void test_blackholedev(struct kunit *test)
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 28 {
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 29 struct ipv6hdr *ip6h;
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 30 struct sk_buff *skb;
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 31 struct udphdr *uh;
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 32 int data_len;
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 33
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 34 skb = alloc_skb(SKB_SIZE, GFP_KERNEL);
a644885645ce86 lib/blackhole_dev_kunit.c Tamir Duberstein 2025-02-07 35 KUNIT_ASSERT_NOT_NULL(test, skb);
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 36
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 37 /* Reserve head-room for the headers */
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 38 skb_reserve(skb, HEAD_SIZE);
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 39
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 40 /* Add data to the skb */
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 41 data_len = SKB_SIZE - (HEAD_SIZE + TAIL_SIZE);
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 42 memset(__skb_put(skb, data_len), 0xf, data_len);
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 43
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 44 /* Add protocol data */
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 45 /* (Transport) UDP */
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 46 uh = (struct udphdr *)skb_push(skb, sizeof(struct udphdr));
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 47 skb_set_transport_header(skb, 0);
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 48 uh->source = uh->dest = htons(UDP_PORT);
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 49 uh->len = htons(data_len);
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 50 uh->check = 0;
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 51 /* (Network) IPv6 */
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 52 ip6h = (struct ipv6hdr *)skb_push(skb, sizeof(struct ipv6hdr));
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 53 skb_set_network_header(skb, 0);
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 54 ip6h->hop_limit = 32;
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 @55 ip6h->payload_len = data_len + sizeof(struct udphdr);
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 56 ip6h->nexthdr = IPPROTO_UDP;
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 57 ip6h->saddr = in6addr_loopback;
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 58 ip6h->daddr = in6addr_loopback;
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 59 /* Ether */
843a8851e89e2e lib/test_blackhole_dev.c Breno Leitao 2024-02-02 60 skb_push(skb, sizeof(struct ethhdr));
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 61 skb_set_mac_header(skb, 0);
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 62
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 63 skb->protocol = htons(ETH_P_IPV6);
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 64 skb->pkt_type = PACKET_HOST;
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 65 skb->dev = blackhole_netdev;
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 66
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 67 /* Now attempt to send the packet */
a644885645ce86 lib/blackhole_dev_kunit.c Tamir Duberstein 2025-02-07 68 KUNIT_EXPECT_EQ(test, dev_queue_xmit(skb), NET_XMIT_SUCCESS);
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 69 }
509e56b37cc32c lib/test_blackhole_dev.c Mahesh Bandewar 2019-07-01 70
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread