From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2F14C02194 for ; Fri, 7 Feb 2025 18:23:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90550280004; Fri, 7 Feb 2025 13:23:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B57E280001; Fri, 7 Feb 2025 13:23:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77DAF280004; Fri, 7 Feb 2025 13:23:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5ADD1280001 for ; Fri, 7 Feb 2025 13:23:46 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 066E91CA25D for ; Fri, 7 Feb 2025 18:23:46 +0000 (UTC) X-FDA: 83093972052.01.AE5D910 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf14.hostedemail.com (Postfix) with ESMTP id 2505910001A for ; Fri, 7 Feb 2025 18:23:43 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=D+AigdkV; spf=pass (imf14.hostedemail.com: domain of 3rk-mZwgKCCsQHJRTHUINVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3rk-mZwgKCCsQHJRTHUINVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738952624; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fy+A0BJTVU2hr6pJvVs0Jz3qZZ0sqYmlzW+g3ladcuk=; b=TXmHPlio7ozrpm3fuZmd6bvPOByplWYHQxY+ZGqKUW37K77NUHjzCkTJjmvYKdpnm+GGk2 Ji7ZmCe0rGO6J4sxgrX1cXUVzgBBt0XH69jtjRnGO/vjCGRoLpgA7sCzqHRYpcnav5tx06 RYT6667JhefSJ3G/XbW5BbDChjXCFT4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=D+AigdkV; spf=pass (imf14.hostedemail.com: domain of 3rk-mZwgKCCsQHJRTHUINVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3rk-mZwgKCCsQHJRTHUINVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738952624; a=rsa-sha256; cv=none; b=8jptGqJle/HpvrxIq3R2m+LLNcZMHlYvkyVjhj6IwxJuXRigK6BLUbopTq8Zf+4Vu1UJ8n CQlhLd5obxvCxdIYar3SoKr1SR/5yii0Mi+W9LA/2HmHXI8fuq+I7gUB+zgMrAYHGFaLsk ShlrS4br0kA3Gj89UkgURrb6qM45xVo= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43621907030so20450645e9.1 for ; Fri, 07 Feb 2025 10:23:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738952622; x=1739557422; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=fy+A0BJTVU2hr6pJvVs0Jz3qZZ0sqYmlzW+g3ladcuk=; b=D+AigdkVm9GJSMGMYkC9Ufvc6pWKPo3hAq1bD0GhDsiPPsI6YoriwGQVrt1op8X2zf daTD/mBX7T3RnzItqM3zraTDz4EtCjJEWuHrnl5ZzVFowLkKXGIW3XqR9W0v5kUUBckj Yb7XnUSkWTmwQElliz1bga7daGRvg2DP8KNdN5p+lt7SzjfYUVCnpV/L6KzP/iB9314B nLz5TnGLwS+bH3bDBDlUZNv1SUNiymXhNZyEVzjb1+EZfjIPQPcKfWt5difO8RODW5sW 6bM6KMGKYP0DMSv4odZDWhv5IUcw/Nv/D3SSQHVdQ6LRXGJtBeFkhLbiC5UxF8F631GI ZbDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738952622; x=1739557422; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fy+A0BJTVU2hr6pJvVs0Jz3qZZ0sqYmlzW+g3ladcuk=; b=SqoxFYD6QMUWhUdEIyEYD7/N9oIo9kxo3gOjQQq/b8fMqbx2IDMDlai0nZHaxPTEXs ptCFxsjxnfvmFp7X/2Tn8Q4HYc8CEyvNz3Mt5U4FrFebZPNU8qforXnTK8ggGclXTiNk 5dXo5EfNQaRSqCwc/aVT36HPDsH+q6BCov/tf7IZ+N8vy6wWWHX95pXR7q1Zo9c9nscd yyP30TvWmj2G96H8AOYGx48BUBHmIsZzzXNK6WqqfcC7Su1ReI1D+0Uj90GIyYYfhk6s y+Nf51ZNmqvPOfIsuGKwm7MNZUolxjv0CbeE3hDcrTJejgCDbItDpyNeesYRdWsBnHwX gWmQ== X-Forwarded-Encrypted: i=1; AJvYcCV58T7exQnFf+iwB5b5wSiBzq4UzRlY8koBkWeTGe+jIsQjdvMoEQAkunIg6rTa1rjUMPVnLLllhA==@kvack.org X-Gm-Message-State: AOJu0YyTDntWhaOsm+ByekdKLsx6obOTiJ4bgWoHOEI5j4C92oIF54is QYi27YdtgcL780+U/S+TDK+4ffOeU/5B0WgAxv4QIrOjW5uIiqg2o3oUDEkWH8PsQg54KEzerP1 eKFfPqDPeWA== X-Google-Smtp-Source: AGHT+IF0r9EDeoYUbGdOeir4cT79QE6cJ1wI46X/b9nUOSqR/hwuAICUK4oTJ/AhAu/x2PqR6cIURo8JgD0LVQ== X-Received: from wmbbd6.prod.google.com ([2002:a05:600c:1f06:b0:436:d819:e4eb]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3b1f:b0:434:f753:6012 with SMTP id 5b1f17b1804b1-43924991384mr45690035e9.17.1738952622634; Fri, 07 Feb 2025 10:23:42 -0800 (PST) Date: Fri, 7 Feb 2025 18:23:36 +0000 In-Reply-To: <20250206044346.3810242-1-riel@surriel.com> Mime-Version: 1.0 References: <20250206044346.3810242-1-riel@surriel.com> X-Mailer: git-send-email 2.48.1.502.g6dc24dfdaf-goog Message-ID: <20250207182336.1839092-1-jackmanb@google.com> Subject: Re: [PATCH v9 00/12] AMD broadcast TLB invalidation From: Brendan Jackman To: riel@surriel.com Cc: akpm@linux-foundation.org, andrew.cooper3@citrix.com, bp@alien8.de, dave.hansen@linux.intel.com, jannh@google.com, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhklinux@outlook.com, nadav.amit@gmail.com, peterz@infradead.org, thomas.lendacky@amd.com, x86@kernel.org, zhengqi.arch@bytedance.com, Brendan Jackman Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 2505910001A X-Stat-Signature: e58uxe1ew6kfcuimz5fujh7ox81f5mca X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1738952623-915847 X-HE-Meta: U2FsdGVkX19sqcTlxzdky/ZzGUGRECLFvjFIxYuDbMVEa7//JZpli2AvGlnSuuCBzCOuDl+eQbkOpANThfVrx0ZrAChnHt8LFx4AGVvJzgKNgQUVPyZV1cS57RfAy63XXYQSB4n/gyD4M34Tt7T09BqZc7oa/8yXu2nkqOIoIUPlspWX+fqbACn6R1bYcKHezkx3lmoJ8gW2eFbPz99cVy7gH5pk0Nr/an4lqs8rve5GztMKrxfx3IYGiGYRHdw6qla4A/mM1PAdsjlw64/zE6FInG/2qIgVbIr+LHwfjYozidcdpkCGgFAHaIZ8RipbzIQ29No5ZIsL+CdPj041DHD4YWgtZcAIqx7RypbLfIEvHKq48c2yR7bCwb3nPN/jxPF2Qr8aoynaxpLAHpR9BHSMXpjiXhnOqnjfRQqPzSSahokmKySx/c3rFdEV9L6pk7tHJwnrygfC7w2hsm3aeBmnOY0+vC2gKPIA6DIYcDozEBFKU1j7xidz1qKPp8QgWnmMx2VX1TNtMdoBd9KcTMI4JOUTbW/MpxUo6AjnBTOOQKaVD/1bSDKwbKpd+J4lmbtno6d2A34l/i14Y3x8+rS+Wl/Xwxc2zo8emjBxjTtlLAYtJKmeDYEFs+OF17TF8rwmcXvrj9YOiesVWB2UrRc2pGrLbbqMgQVRfkfWx18MwtTL9fUDs2ERM0BOIUhxDyUjdInHkmXF8T9DRz31325m31LCbQS3eX9/KA0Ffig1ccTgbsA0KWpcwZ7AKdino6sywlcXiLksBvuLBOfEQ968GV5ifGdmFaR+H4VxiQZXKDI3gIPuktlqE7jElBTnll3mJNHfEr1bmKMNMFvM4wlbFAHZzZvcr6tOy+e/kPswB4/+K69sHy2X47hIjoZDp/pADm7M5Ajf4xSLGCnjojeV/QyQmvgqCHh0EeEidh86NKEbyFhrQ5VNJTeYgDF5NerdA0Kf4Jpy7O0K64S PRK3yOxc OWR7Yd/s2M/AkvHGPAe1Cp0mW9nvLK/czjnNu8Px9dT+MqaNU6443Oj7eArQhCcUUpWG6mfoWxPhcldNTynIQk4XxAdKBQOcbZPGzKCRcg9+y+nOIYisSZKVplcJwPyYtUE75CMJam1kwdOrI/Dvy1TLaeXHZN+Bnkj9YFJRK8BYfo2O0mUFd9cs0JUpwUTVQiFwVahB2YMB/zpIHcNQsn2QDbaJfhaT5jEnIv/4sp9o+JBUfyyYiM5EJCI5OFEp+N67WUGfDx2qri6LfWqWFbs4Dq8jNqb3Is2B7UX3lqAqBE3WDnnb8eM8y7YBaT2oJAz8UKa8kcwSTsyqD/u89cStnFZNgUw8OY+Om2MDKRNWsegp+Vu4Da423rGtSj5pdmcGks2Zvy/QQqhPvvmaqJWrnkndu/jvIB9j4R4ZFj2qkUs+dpYiKxuSMl5s0ecRrxA5mcOPyQgWWvJ6DCyXrP+Q4Fum5oIdt0TnihiA4dID1vxaeYOutOx49H+TZ6VMzueMhdiXsLTMgyFe5/OKsaVjSOH6CKm/nG7S3HIu440nLelc19TUXL5qJpInT0QjfUX/9PqOXQQ+5XWFVWgPEPlx6Dj49hM7stAi858SPB2P5JpGKnpg2O4W05nwltFykhSqclXwaS5NnIRU9gOsQ3wsjdA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000200, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > Add support for broadcast TLB invalidation using AMD's INVLPGB instruction. I applied this to 60675d4ca1ef0 ("Merge branch 'linus' into x86/mm, to pick up fixes"), booted it and ran some selftests on a Milan and a Genoa machine, no issues, although I didn't have CONFIG_DEBUG_VM or anything like that. I did see the warning reported by Oleksandr [0] on QEMU. I tried to test Turin but there's some unrelated brokenness. Due to other unrelated issues I also couldn't test with lockdep. Anyway I guess that counts as: Tested-by: Brendan Jackman I couldn't get any performance data either, more unrelated brokenness. Maybe I can try again next week. I posted some bikeshed review comments but I haven't grokked the interesting bits yet, will try to do that next week too. [0] https://lore.kernel.org/linux-kernel/12602226.O9o76ZdvQC@natalenko.name/ Cheers, Brendan