From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB1FAC02194 for ; Thu, 6 Feb 2025 16:53:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56A566B0083; Thu, 6 Feb 2025 11:53:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F28B6B0088; Thu, 6 Feb 2025 11:53:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39327280001; Thu, 6 Feb 2025 11:53:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1A89B6B0083 for ; Thu, 6 Feb 2025 11:53:43 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8E29747086 for ; Thu, 6 Feb 2025 16:53:42 +0000 (UTC) X-FDA: 83090116284.19.059700D Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf05.hostedemail.com (Postfix) with ESMTP id EDCA0100006 for ; Thu, 6 Feb 2025 16:53:40 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=e54vJHQp; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738860821; a=rsa-sha256; cv=none; b=Opp8bTFTmLYc7dCKfl+WAYZmzxnwZtdRDz1wAgbJduetdrJW7XbG9rNpabSJVUfpIuGRm+ 5sAxBN5CqnI0WpvjEd03mgMOlQBtuiO8xYcAraJNtfWNLDA5cQ+hfIMgk1nQuk2+8/4h6J LRUt6kt7muRSuQ0qscAvs4xSym0Vnxc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=e54vJHQp; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738860821; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G5zEx9tqVR4kWpVjB2a9jq+Z4FPhY/9BbJKoZvcZg98=; b=XtUBYxwTnD+5ErljHLyrJKPhzhY1H228lMHXJ89YXRzoQf0uW2QFaHyiFxpIz1Bqz69DrS 3WH+i4esuv8cMp4vNEQEa0lYhAAhCnm3lKDtHlmsdxOCijioJPAYONTggOvxbIpQPqBwZJ vgAS0ycuCODeWofzBxMNuYmvpmDITmA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 4926AA44223; Thu, 6 Feb 2025 16:51:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0431C4CEDD; Thu, 6 Feb 2025 16:53:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738860819; bh=GprxOyHnQtSNu0PySsnNnGui8NBb/92gUrmZKWURi58=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e54vJHQpC2fICYi7U9+ZX73tXsHG9K3XHukYrLYKL1hKqoC2S1iUywXsMalmTcp63 nFVVdh9c+692gO1J9oLlTlqLHhh+nJShwiVdopo+9XudS95YZEGrzJLG6umIZDpl27 4LmjIO5mS2R9wloWnL9BdXqpOKsUtdNwaT3u8NovhZDDRfTaM0N1WicsUgGZKBpfwB I/LIXj/PgcRVvuxAiwND6lTfAuknG7EDai44pcd2axp/XFiiYvRg6LC/RnNnxTUJvs hPlZGUcqjpyIDwT3abwNlW+lx5eDiDiHVMC/qNCFXUJ0ZUOtlg2/RZ59ghgVaN0mKd tiqTolQ2GK6wQ== From: SeongJae Park To: Lorenzo Stoakes Cc: SeongJae Park , Andrew Morton , "Liam R. Howlett" , David Hildenbrand , Davidlohr Bueso , Shakeel Butt , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 4/4] mm/madvise: remove redundant mmap_lock operations from process_madvise() Date: Thu, 6 Feb 2025 08:53:37 -0800 Message-Id: <20250206165337.6285-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <048896fe-69cf-479c-a89c-0242da88f84e@lucifer.local> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: EDCA0100006 X-Stat-Signature: y1idaytybwy31hkhup7pdjq4rej4mnyj X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1738860820-924447 X-HE-Meta: U2FsdGVkX18r1ZY9zqoAmHu7L1cxq0MRHs9xGoByNT+BIyz8lSSOqNjGP8FxQQB/98IvSSL5Dj2gEuYmLXaa2Zex9XIox7AGRa4xVI7slfUWBOoraczDVJWzjZ1HAg+BkKr+X7HCyzuUQLTjBcZM051ddqcKBEt1rIs0wWDD1jwBV2yw8JiXMLB4JBW9zhaMaPhcH1r2q8QkGqfwG1ZYFhG8LQmHov/KCLofQ9rDhCC52s897Yl5pgY6dTXgQzf1fNenDCsF6dC0+CHTyr4h1XVHRFuaKuZQBPRs03QTs9uyvfB9jfTX4Xl8gfGSShEi877ncCxzNziaycmymfg2Ogkjo0lnEB7I9Yius1p8vB7uIS61g4wtqmZrnStG/raV9skkfeO8fCrsox/IhflNikpY7GjqezUYPVaiifeeiJ4XzpoIvhiyQbtjxVRoiid3By/RMCXwDWA2Bho6A7fpbcspkrmlOmT4lTpDBTtYRRKP8Zo2bHOvnw7yxn8krc+g9BuD7C4AT6C96HHMY5+3Q5lG+Tin7FSv8e+Qh7IdCI9hxaVGQ1SLhMZi8rh+ntWdtsLl8v6sA8Hq3Caj+ot/9o47zoh27rwnu5Be+9/1IPqvn9vDvn2PsbiMcsFKOZNSX5uLxscK2N23bytQ9laxgm/yRDv7leRX8cEPCvcmj46HIdEGZtiHD3V07+7BCu/VBclllgj9HyJKp9ZJGDI18GpQNdv0tAz/3/bB+NZqBoZV3Ooch7WirbaQqVQuaU1Po+fYFyOoIv5t/4wJHjCYsv985Pv25gez1hYNbwwFjjsqD6FtCk/HtgujmfT/WbqzdUEG670V4RG74mdSEV/QXOIq1v+yiMRe2uAIAeXySTdJ5LkHQaqega5KhZoG1oUu5EkJMNhXDWPWTlA9MRLN1gXSPJTyg3XkZFwETr6SyJumsmfuROLy73D4UameJ7gxZIeG0IjYH3WhakgMeKI GbiVcPtc fL4JPY9Jhu77PqdKz6946zpl3YjtxcNpuSQ9RzOjgYbpNThU2mD306MhHl2keDze7l5EKIplldGGRwcgmhuUOdccXkYPn25sgdbrOMEM23AWSUVO7lyRiJRd/gNrtP5I9d3idb33G6ea0IVZIbwizi+d44OfyCAFwY3Tq1FyeY4wJnG8Jkew6b6HjaJ5uD4s/EqOFaiwTkWRCrcc78yCTJvF9IKScrUXblHVAGim/5PdCmNCVDN1Ihze/D1DZFtjU+8vIRMTCVE5nrkhOE3QcjML7WRUu/7msm9AUiUCpu0nkUzpHCeyjh63KL3M+vUcg25eP8372p2uRryw6AZLd9fl/eKW64d3VSSpy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 6 Feb 2025 13:04:53 +0000 Lorenzo Stoakes wrote: > On Wed, Feb 05, 2025 at 10:15:17PM -0800, SeongJae Park wrote: > > Optimize redundant mmap lock operations from process_madvise() by > > directly doing the mmap locking first, and then the remaining works for > > all ranges in the loop. > > > > Reviewed-by: Shakeel Butt > > Signed-off-by: SeongJae Park > > Reviewed-by: Lorenzo Stoakes > > But please fixup the comment as below. Maybe Andrew could do it if I am > giving enough info to go on, otherwise it could be a quick fix-patch? I > attach a lazy attempt at a fix-patch in case that's useful. Thank you for your reviews and this fixup! Since Andrew already picked this patch in mm-unstable, I will keep my eyes on the tree and make some action if needed, to ensure your suggestion is applied. Thanks, SJ [...]