From: Mateusz Guzik <mjguzik@gmail.com>
To: ebiederm@xmission.com, oleg@redhat.com
Cc: brauner@kernel.org, akpm@linux-foundation.org,
Liam.Howlett@oracle.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Mateusz Guzik <mjguzik@gmail.com>
Subject: [PATCH v6 2/5] exit: hoist get_pid() in release_task() outside of tasklist_lock
Date: Thu, 6 Feb 2025 17:44:11 +0100 [thread overview]
Message-ID: <20250206164415.450051-3-mjguzik@gmail.com> (raw)
In-Reply-To: <20250206164415.450051-1-mjguzik@gmail.com>
Reduces hold time as get_pid() contains an atomic.
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
---
kernel/exit.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/exit.c b/kernel/exit.c
index 9d7acd7b0040..8c39c84582b7 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -248,9 +248,10 @@ void release_task(struct task_struct *p)
cgroup_release(p);
+ thread_pid = get_pid(p->thread_pid);
+
write_lock_irq(&tasklist_lock);
ptrace_release_task(p);
- thread_pid = get_pid(p->thread_pid);
__exit_signal(p);
/*
--
2.43.0
next prev parent reply other threads:[~2025-02-06 16:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 16:44 [PATCH v6 0/5] reduce tasklist_lock hold time on exit and do some pid cleanup Mateusz Guzik
2025-02-06 16:44 ` [PATCH v6 1/5] exit: perform add_device_randomness() without tasklist_lock Mateusz Guzik
2025-02-06 16:44 ` Mateusz Guzik [this message]
2025-02-06 16:44 ` [PATCH v6 3/5] pid: sprinkle tasklist_lock asserts Mateusz Guzik
2025-02-06 16:44 ` [PATCH v6 4/5] pid: perform free_pid() calls outside of tasklist_lock Mateusz Guzik
2025-02-06 16:44 ` [PATCH v6 5/5] pid: drop irq disablement around pidmap_lock Mateusz Guzik
2025-02-06 17:14 ` [PATCH v6 0/5] reduce tasklist_lock hold time on exit and do some pid cleanup Liam R. Howlett
2025-02-07 9:18 ` Christian Brauner
2025-02-07 9:42 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206164415.450051-3-mjguzik@gmail.com \
--to=mjguzik@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox