From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A6C5C02194 for ; Thu, 6 Feb 2025 15:09:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4322280003; Thu, 6 Feb 2025 10:09:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DF417280001; Thu, 6 Feb 2025 10:09:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C95C6280003; Thu, 6 Feb 2025 10:09:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A97AF280001 for ; Thu, 6 Feb 2025 10:09:37 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 579B21A11E0 for ; Thu, 6 Feb 2025 15:09:37 +0000 (UTC) X-FDA: 83089853994.15.392A403 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf18.hostedemail.com (Postfix) with ESMTP id 678941C000A for ; Thu, 6 Feb 2025 15:09:35 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=ESG6W7Ut; spf=none (imf18.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738854575; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7PnrjZRFTqLvEtvRHv+8ucyPFuvDArddQ1Wq7UL4EbY=; b=8iwvUJiMFg1I1Gih/VbXdGuP/aEvHDMcfF8LdJunFVxFCs+TjVlv/V+wAks19PLbq7cMz+ axH8a0U4e9/3AtkyF2pQv56uHMomMPmC7aNCSd4lXLUjfp9K4pgLYPbHZnmrBq+CT0txEe H5fw4vsScEIeGDOaue2zPho0I4GUEmQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=ESG6W7Ut; spf=none (imf18.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738854575; a=rsa-sha256; cv=none; b=WPV6R7Jy6dpMMh1MpyB/wDMGU1WUq74NrW/n5p0/NLRnfU9srMbmbS3UoAxNDdOCODiZ0G XbByHQzab2yXedSeRBmewqDo3EfyMdfkwBoRRfDu8z5oguMc0uiBNsz+6gOdswi2Q5hHLY HU4yJwyzZY323iYJOWGRORieRm/gFto= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7PnrjZRFTqLvEtvRHv+8ucyPFuvDArddQ1Wq7UL4EbY=; b=ESG6W7Ut9sm6CGovvRv9w/3m1w gVTcdbwKYaDx8C6BihkI7ezfS0ws10WXXJ+hyWxOaX77rcfnLGRrO97H8MRdp5ay/4Az/KM6vz8ln uackznOcjH/M37ZSy1r+OpoRD8HMWK5eivGXKv3zUN6CTBaYyGO5BxuxAGbT/g4jx4LB7LOIQmB0j lZcHHGDxqeFgCkjNL42iZxsrATTMdwRw6WQosVHFvyo5vkq3BOAR4rR+CkKZeWhnT0NsLjUDPwFSo GP++6L9QjfIYhEqYkoi4cxUe29r8Nj/Fh/rtXKCGlhQlhyNN6ansmKExkpNAoMqelKkk67ndpjg0p TP1Jm3Qg==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tg2ma-0000000Gy2X-3or3; Thu, 06 Feb 2025 14:23:09 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 1394C300318; Thu, 6 Feb 2025 15:23:08 +0100 (CET) Date: Thu, 6 Feb 2025 15:23:08 +0100 From: Peter Zijlstra To: Rik van Riel Cc: Oleksandr Natalenko , x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com Subject: Re: [PATCH v9 00/12] AMD broadcast TLB invalidation Message-ID: <20250206142308.GR7145@noisy.programming.kicks-ass.net> References: <20250206044346.3810242-1-riel@surriel.com> <12602226.O9o76ZdvQC@natalenko.name> <8111558b52cec1152746b05a9c1d657d18df0fe2.camel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8111558b52cec1152746b05a9c1d657d18df0fe2.camel@surriel.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 678941C000A X-Stat-Signature: nmqpszb9o3bjgz9k9x9uaq667dm4wjjg X-HE-Tag: 1738854575-827540 X-HE-Meta: U2FsdGVkX19MVgGMbttjravZtN9fTzvOsNvFwsUoFtaKnOYoV+Xk7LFj/VvQ3Gww+ZATB/8dkRYYtzcti9vTE0KjH3K9BbQpWOr8kA9c7dU0clV3YfOXJD+wE2yJ/QKH/J9I3gsOIpm3sdYtxECCQB6R4pzwhfVunmwVT2OPeISgaixz4UDdQfNE1/fTgrxsoCynvnkWl1cjShgsfBopttWGhQVjaw/ceBLhehEGB8XMUl+j0U462QCNoMNlLlXzCq/uRzUi+5i6wgABqcqjsHEmwtWbxwAs6l1as8ll7QLepiokeY2NtQ6wS07xbVzg1Iapwy86Bz84z9AdIG+4OLqfCjslyTR/7RcLfYoKkqbV8DwqXuYGB1XEpJaGwCwMQmq6MI9DHNeLjhHS3CrvomyzpLeOQKo8YOob383hQjOgbi+GhMbpPXCGv1aRmLzIfxFpIskfZ8yDLsiLS0fpa/QWGFM1IrclGuhPkEUww1bi4rjKpeHU+jeEEns3WokCVrKEvxyoC5hq9QMyJ3y763806koagCfqRFSqFjBW6WQVwAQwhUpqpcDm3y447vU9J4Zs55g1v7PGqJynIjdaFf/oqpWceI6Ld8iTW4AHr2cIL8MSwJLMKhXBlSVVE2jUDAaAarQ75d7zW83Va3Or3XFMZnxXN6Ct7VmP0K8c9RhrZ4NWsZDjfCKUSpWu+4ahiNGlSwPHjxAubZH0/heEqLtN9CTsrhMM0LayoqO04zndcPUScA808yKN7+kPV68Es9YoHKiO8ueYRleEao+JDjss0EA0J/KGp9h3BDrQVK/TWkLdj4rcGwSat5OVyr6px9v07Q9pxLFWbFf2OLzNNlY9MRcLjDAIbSVe73jUNxw0ui0HIOejn5wsrh2k6acS7CiPDUF9Sp0YXskOoL1vn8oVPvAW/XYf8ntoBPoD6s9Acrr7RpiTbllO/X7B9P4Wq1IzJy5YUq9pwx35Lfd EqLNWGth W5orVBCF7SOJZ4+abLvHJUR+IXUQ/gl8PKl8IFWnM6sF7t2EeR02HpY7rArsIx0t1Oev9itw9ewZHeTd4bii2n/s79fQVi/HdaRIK2ez5IjrhmPr0VVosGbmSSOxJEpd1jsgneR/VG9vmvshq+lENGQIhIL99eGBhTqCc86SyBSTyY0MxQc68evsS4Nxyyn+0kGNJO9NhHDgcASmpBh5baEln0205Cx+ftF+8169PecNg8wRCknedifYfkyQ7HgOsd/EUS7g1oW54l+k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 06, 2025 at 09:16:35AM -0500, Rik van Riel wrote: > This can result in flush_tlb_mm_range being called > with a stride_shift for 2MB pages, but a range ending > on a 4kB aligned (not 2MB aligned) boundary. > > Peter, how should we solve this one? I don't think that's wrong per-se, since all we really need is for end to be past the end, one byte, one page, or one stride don't matter much. Anyway, I'm in desperate need of a break, so I'm not quite sure what the best way forward is.