From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E7F6C02196 for ; Thu, 6 Feb 2025 10:40:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA00E6B0089; Thu, 6 Feb 2025 05:40:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D50BA6B008A; Thu, 6 Feb 2025 05:40:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3F726B008C; Thu, 6 Feb 2025 05:40:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A93AB6B0089 for ; Thu, 6 Feb 2025 05:40:27 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5BB30C0F44 for ; Thu, 6 Feb 2025 10:40:27 +0000 (UTC) X-FDA: 83089175694.10.0CDD676 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf27.hostedemail.com (Postfix) with ESMTP id ADF3C40042 for ; Thu, 6 Feb 2025 10:40:25 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CCc0u3Br; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of brauner@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738838425; a=rsa-sha256; cv=none; b=bh1tAfcvdDoeBGmk4kAX+BVjndVgOt6fnSy5iv6QdOVj0FP8DzCX4HIsanLzTkyRx6FJ2a TumjxhmbhUFNJs7Q17hv0/n+a1qZHiG719W2ddrJkXvSkVpPFvFIYgLpzCUFdEp3GUZoIF P6+fqnlGL8G3sNHcXeScYz7wGKoF2sc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CCc0u3Br; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of brauner@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738838425; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hpImk2Yd/1mS91+RmT7YpRVKMFQKBmUjXg5ppBuTyz8=; b=YcfQDqLNsNOTcECS9YLJWhiQMVVvQT3P87atrPgp2cpHv2xj+jggjLuWP1ptxBNYiW0QX2 WovdNALNG/QHVxFCe4u88dFEmmEkn9AkI2K75fAakg+/I2NMv4CshjhFfQY6MyHq0pQWCa ag5WRPhvqOi07z33CQJCA9dtzLaYFgQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id EA078A440B7; Thu, 6 Feb 2025 10:38:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3354C4CEE4; Thu, 6 Feb 2025 10:40:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738838424; bh=8+oWvRnLl/BloxMfzylmfeSwP95E2qJF+2cAaIFDswE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CCc0u3BrufwBUYlCC2VPvQFv0wo9hnkGVu6ecBgwz1S9i61AHm9sl/qLknvt3aEyh SRiL4SzDjE8ZhItvVh0AIBiEKPBBl1INX7z6xdmt069mWbfE8OOjpc4VY7o/DEA3JK OTaQ7y5Oapex9fzEetePkHCdSIhUSSymm74zLu63qWfTnNZ/ApNwWnH9fjQTYow/dx YjPWZ6Bwg90UU4g2n7DkSP2Mtf/hkaCQpe1g9/lH+2H2UijXQqL8oR2Y7bVj8phJtO CemLlYiEHWI+4/AKuu1JJUqI1Aiz01RWwHS7VUbKFnTqtVFl7qEaxFx2CIjz5RSovA cwxLLkW7dapQg== Date: Thu, 6 Feb 2025 11:40:19 +0100 From: Christian Brauner To: Oleg Nesterov Cc: Mateusz Guzik , ebiederm@xmission.com, akpm@linux-foundation.org, Liam.Howlett@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/5] exit: perform add_device_randomness() without tasklist_lock Message-ID: <20250206-pfirsich-fortbestand-fd0fa94edde8@brauner> References: <20250205200929.406568-1-mjguzik@gmail.com> <20250205200929.406568-2-mjguzik@gmail.com> <20250205205655.GD8754@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250205205655.GD8754@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: ADF3C40042 X-Stat-Signature: jkzhxstgokqsapc498mrc3oq6d5gb3ej X-HE-Tag: 1738838425-880921 X-HE-Meta: U2FsdGVkX18WybsVpvPLB0spOcRCljej9XpdMj9SPbEIjnjWw7OV6TJWQlf7Eqgh6fGsGYlKkheioaHE76qe4/iObIeZKypL86ZtwtnAADykMSl35ZXWfpiPSE0o2zwYCVGo8i7hyqpEOlLn02P+a7u6r+P8uJTewFSbtmgVmMzrn3iOSeLVFqheXyfPj6N/QKP3RleUO/07LqvIkCDP2TEE7WIPzoov2wSjdI2IxT89co5U/xNPkxl2dp0E+Zi8PviLS3AiatO8pL0RzhTbAYpLCOeboCQr/+tExLIb0gg0MbhqkoRUn5zVzgiuD5ukt8t9ebHrWMQQc+h5WjE2/B6cz1Zxa1ThIbKX8npkGymdDrzWUM/WsU8eq/pw/h+Ypj20N/2eiioyIjQ+cI0b9n1yZJSMXMuGMjDiJyT7A5khXXkqKj3khHjEFkr5bhE1vvRxww7GD38BaYysyOl9Mfgt3RlIAcQiOJHZ6/A3RzLwgwCsgc61ohdmmp5hTZFwbYNnJVkwPME61oQA/W6/EDZPlvj9QkpKXGshxFCO+Se+RqftiS5Q81FRPEaxmdOBf5BnCVdPpKM2CgXg3bUz8yWyleFLSzlGAF9diGyl3ek2OwJhmRFFWwCtZbPr9un8QI86/7XBSwWfBDxPubsUu2uSbOyVLwdZFihQYrkswHJ3ZyzkpNh1wUGhCbdxhFHwuX1dpoPYLv7Vfr4DQSYjKpaU0ZJwktovXYiOGZz4riwqE8yvLQtYFFFCffyk/iokf323TQz5NiAB9bDbA77Y6mm4e+cTaNZz5Mfi6BQH/8XIwyX9o3vBVknqZBMcJRXqoj9uVYWAziSTlcnrr8U4qdZEbtLeFOBeKs/RNgsCo8z5S52QnP7LBumN6DyC8evtr1QHhihRCdTZuWMFX8r65GPZW/oUy+qwjkxppynqvMIV+hrLVHrkcIPGJV5u86YIV064GeRcEkyUE4dwAWn zuAcU6i6 83SETlkM2biVwaW+UuPqn7xBa9QJqRMcNKSroZ84FSmDKUAadvutOx3ZBqwgBwx/fNDiFzduCO6AH7b+YKytFTBNuIv10ltwjSaDesLGQQiTVMahgSPgFj69s6cwyCiAJ9BhSZyNW4TOx1KvId5gmxgFNHlt1krTp7mGc7LhL/F3yCvkhp+TF7cIhoDY4ljyCuR1/QbMgfC422MJskAZwkwD6BWUdr6pbW2AQ4tHcsJl/qGnI9MJ1XB/E6TmNaIX7Jitiu2HU+k8jRSn18zdkhbHk01bWrfnOlJzkCW7vXdZ0dLgHl5cUoPCaoups6Po2JyZBUl48XD50XBoQPi8C9VY0kAzWJ3bERevDYbwH+gZ0/1k9aQVm3NhWwg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 05, 2025 at 09:56:56PM +0100, Oleg Nesterov wrote: > On 02/05, Mateusz Guzik wrote: > > > > Parallel calls to add_device_randomness() contend on their own. > ... > > + add_device_randomness(&p->se.sum_exec_runtime, > > + sizeof(p->se.sum_exec_runtime)); > > OK, but > > > + free_pids(post.pids); > > wait... free_pids() comes later in 4/5 ? Yes, that seems to be an accidental leftover. A git rebase -S -i v6.14-rc1 -x "make -j7 O=build.v1/ kernel/" caught this right away. Removed.