From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26D7AC02192 for ; Wed, 5 Feb 2025 21:44:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A5A9F6B0085; Wed, 5 Feb 2025 16:44:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A0B2B6B0088; Wed, 5 Feb 2025 16:44:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D2686B0089; Wed, 5 Feb 2025 16:44:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6FDF66B0085 for ; Wed, 5 Feb 2025 16:44:30 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 284C9A0C17 for ; Wed, 5 Feb 2025 21:44:30 +0000 (UTC) X-FDA: 83087220300.13.DBEF7EF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 774A840005 for ; Wed, 5 Feb 2025 21:44:28 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CGUoq9+s; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738791868; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fvpDbP/jsH2P/cnPMSqZ8kcmQirfkdrwNphCGsW1gHc=; b=NFIAJfHmu1pnRq7z6aHfTFp92ON/y2UaEagnFbpGoM5tYUUbJMh65Y5NtoT2KXvg9e0wGX z4NrpX3c0DaVFlUSeA9R5RKhSI6MpFS+xoMRQ6HngwMxyKLgk1TpLEJj0lAevv5+/OCvJR MYlCY/PVR7YzjpHFq7kqvEBwbHDJ7SI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CGUoq9+s; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738791868; a=rsa-sha256; cv=none; b=muuFgYJlS18BbOF5YmJsFAH2l46gkK6brVF+6yX+om5J4eQjhccMku7zdKuOVamwCXL8ne 0cEUz5sf16qYyoenb19oz7JHJ9H8jRN5g9wILbuZsr0cVaa/Cx7m+7H4qBjS6PZVX8ezlM rrOrUJAJd2hTPkYdx76tnyQXIpY4Qcs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AE07F5C5603; Wed, 5 Feb 2025 21:43:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA0DCC4CED1; Wed, 5 Feb 2025 21:44:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738791867; bh=zwpk8ivjbp2tDW2TdfvJlWP4WNbGXDP645Klw4KbNb8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CGUoq9+sIAI+u9/4OP9OTh70labvdLs/JrqZTEz99zRswo+wGsQyW4JIerlDovphc /TZpSTYo/m9w6lLBOxlqhNsPg4xteiZQHCO4PGJMGIWc8TH/RTrU0apoYMtRs7UmyX OMbU0AGKIBHtNvTL5QUHVg8uUlsosfvz/HpK5a7wL/atui3eGIeDD7pGtrdOPoCLOe pgywiQw8kVKWyWplilfZBA9uToPmUFzUeVZ4sDo/6uzC/5GtlrZxrHkbUqYLWkX1sz Gpw/qv2kNrp7kAmXPb6ykoKXasJiYVf8Ict6xrdgXIt6foq+5LlvvRvaMgR7xKI2Be 4kFzbsJEkT35A== From: SeongJae Park To: Usama Arif Cc: SeongJae Park , akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, hannes@cmpxchg.org, david@redhat.com, kernel-team@meta.com Subject: Re: [PATCH v4 3/6] mm/damon/sysfs-schemes: add files for setting damos_filter->folio_size Date: Wed, 5 Feb 2025 13:44:22 -0800 Message-Id: <20250205214422.60201-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <591085b2-4566-429e-9ee4-991be41062f7@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 774A840005 X-Stat-Signature: ue8kkymcz61zzbrrwf39tftzh8dexqpf X-Rspam-User: X-HE-Tag: 1738791868-388863 X-HE-Meta: U2FsdGVkX19bZ9NtVOuRA210N5UA40urjaXKhRINUdvQGIERXtccrU7gmIrew6oArP8qRxo7uRm06K99OvzSD/Uywl2m0mCvS6FQTcflhLV5ktBOcvHAvJeXS+3+dg1YcpTwmQPowtZelVQ6+DZnukXh2pfaktnChBwxyi7aBZtXcDsM88JG/84Zg/4r6QZFjdnWXvL/l4WJfIWBp4F3CmsujiamhjL95mPLPjNpanOeyuDbLiu2WPXnRHEMxHXL15CnszSU6sCzkkUWwG+oku1rbLX2lOB4W35T1oJMRShTkFooFriT8fn6gGCGeZ4NBGj7KSltplYJNEwlPEr5/iTr2c2p6s8z/TWWYlUaqfkSiYigpZkR1S0SpQRxOjDM5MUtYnGSo86rJVV885GUYOs/yliGzJ03ghZK04lMGIcU+HrBbx5BJEko6EKY220PeA4kJf3AQywQt4gaQnMwufQiZ9xVWQhRlos8BNAE2wKSd9zSmscDgOBcVC+hX9SpeTUhavwK6+NfHkSgP3bDxq/SjpjYedSI5ahP+oeZpc6kEARdqKFRGsypkV7CuVXPneXDd0EmbiV9noESSeqYDXd+IW9Ib6ue4HsPjvwXsApoX0UeVPXQJllLXWjrHIHraIIc+7yTvfZT2xQrseQyEQn5vwGASKEdetd0Ug4ZHfXBi0Ue+1AsLvvJypTTKWGwzwN1HfTkEUdwpO1d4Iv2mMeWiJctUNYr5orpVOOKK/19ceslQAwUmB6TAK5NUjZ4//7zXCcOJNTAVMmrGi5/AdRhWAkMrwjQ8Az58KbSjPNrUOA8yH/DTsMLZknm0DfR6yFbBL+smRXVjUVuos22YBbu0N6Ng66XLVw3N+5nFEN4OqTqf5/uWBmwB4LOShI+CLTA5v9c1kF0xMOhKLiqdwIOYKw7lJYdz3V0Lj4hAhEB39PgRy1QqiOzmPMakr/+wgDbKu3Xh4ouZsyTsWr oh8Ed4vP mwmjA4X3aru9K0NfYzR/VHfSph7Ft+YNn3+CaQNVJkqRJc4oMS76qb2UsDcdfCTOJPYTwVBhDmDxWhaovUfdcvIEDB/B5zFU9vctv7voEuzI9MYCL92NSgBDsaRjRmzqpl+JKxqlf852ol7BmOnhMHFAZiBmW/kJoIHONlbQ/ji7gybUaUjU8N6duiEATYY9RHrl+Plze1Q6/ASpZHdHroPtmxPRnUbnrDCmJtM8Sx1EHRAux30txrP2GH1IUY9F+y/qbYKf8T78KopdZrTfyBE4HEKxg6kvtaZfBAcHIxMFoGmtwRkA2oxaKfJvvsSF4o+2K X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 5 Feb 2025 13:57:05 +0000 Usama Arif wrote: > > > On 04/02/2025 23:10, SeongJae Park wrote: > > On Mon, 3 Feb 2025 22:55:30 +0000 Usama Arif wrote: > > > >> Add min and max files for damon filters to let the userspace decide > >> the min/max folio size to operate on. This will be needed to decide > >> what folio sizes to give pa_stat for. > > > > I'd prefer implementing the logic with API interface first, and then > > implementing sysfs interface on top of the API. > > > >> > >> Signed-off-by: Usama Arif > >> --- [...] > >> @@ -1953,6 +1999,13 @@ static int damon_sysfs_add_scheme_filters(struct damos *scheme, > >> filter->addr_range = sysfs_filter->addr_range; > >> } else if (filter->type == DAMOS_FILTER_TYPE_TARGET) { > >> filter->target_idx = sysfs_filter->target_idx; > >> + } else if (filter->type == DAMOS_FILTER_TYPE_HUGEPAGE) { > >> + if (sysfs_filter->folio_size.min > > >> + sysfs_filter->folio_size.max) { > >> + damos_destroy_filter(filter); > >> + return -EINVAL; > >> + } > > > > I don't think letting users set invalid min/max is a real problem, as long as > > the implementation will handle the case (no memory matches the filter). Let's > > just allow it, like addr_range case. If we really need to disallow this, it > > would better to do that from damos_commit_filter() like central point. > > > > hmm, does addr_range allow it? it addr_range.end < addr_range.start it returns an error. > I did it in a similar fashion for hugepage filter if min > max it returns an error. Oh you're right... Maybe I was just out of mind, sorry. Please keep this part as is your version to be consistent with the address range code. Thanks, SJ > > > Full code of damon_sysfs_add_scheme_filters below: > > } else if (filter->type == DAMOS_FILTER_TYPE_ADDR) { > if (sysfs_filter->addr_range.end < > sysfs_filter->addr_range.start) { > damos_destroy_filter(filter); > return -EINVAL; > } > filter->addr_range = sysfs_filter->addr_range; > } else if (filter->type == DAMOS_FILTER_TYPE_TARGET) { > filter->target_idx = sysfs_filter->target_idx; > } else if (filter->type == DAMOS_FILTER_TYPE_HUGEPAGE) { > if (sysfs_filter->folio_size.min > > sysfs_filter->folio_size.max) { > damos_destroy_filter(filter); > return -EINVAL; > } > filter->folio_size = sysfs_filter->folio_size; > } > > > > >> + filter->folio_size = sysfs_filter->folio_size; > >> } > >> > >> damos_add_filter(scheme, filter); > >> -- > >> 2.43.5 > > > > > > Thanks, > > SJ