From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BBCAC02192 for ; Wed, 5 Feb 2025 20:57:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03AEF280003; Wed, 5 Feb 2025 15:57:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F0616280001; Wed, 5 Feb 2025 15:57:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D57A1280003; Wed, 5 Feb 2025 15:57:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AF904280001 for ; Wed, 5 Feb 2025 15:57:34 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1AD2980B61 for ; Wed, 5 Feb 2025 20:57:34 +0000 (UTC) X-FDA: 83087102028.22.41299B7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 2195E40002 for ; Wed, 5 Feb 2025 20:57:31 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SimlkidK; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738789052; a=rsa-sha256; cv=none; b=HOE/lbHxBMzVJW+WjllETWojLvfm3kNz/5YW2IoQHDni4n4VMxaXIF7mKzCF8dF3Z3S+J3 d04irYoFp/SLeMkLYGQ360WDm705J/diWAMh30Qp766rZ/Z8k2TiCv55U34GYDE8Qce8EN fJe7JgNa8EfRS+2gY9ZckWqcaXipu+I= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SimlkidK; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738789052; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XtyPT3Ya4wbpniWLKwUkiZca6R2spTBS6GUr4+S9pCM=; b=ZnxEkfFroM5AIOBzNo4JRQ8jvyGXbsN/doXWxoLiFjBqA4++8Ua3VDEQmg9zZztXp4aMMZ 0+o1BUGNIAND0kfkPLidWC76RLiuw+vvsZMUdmqXrEieIOitFgE9lqc0Q7qIeXb/imDWuP KW2tkP+gK+1fTSkyMcPGLtG2AYK6LM4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738789051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XtyPT3Ya4wbpniWLKwUkiZca6R2spTBS6GUr4+S9pCM=; b=SimlkidKmuW4HzscmVKGJ6unuGZ7MQIKrJC2u2NasbFrjhTngRnODqe2CZRIPgoli6/4ha xm5Wp/HLcwz/M3SO76Gs/7LybwC57osan/6AYbmyfuCv1lSw18ZM5Ce73nrw+vaDPiaUx+ hvdjae/Ww0IMZsgE0CiTvlBjWdjKGbs= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-551-rLwk5WnTOWq4dRoYnN1h0Q-1; Wed, 05 Feb 2025 15:57:28 -0500 X-MC-Unique: rLwk5WnTOWq4dRoYnN1h0Q-1 X-Mimecast-MFC-AGG-ID: rLwk5WnTOWq4dRoYnN1h0Q Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EC0D8195608C; Wed, 5 Feb 2025 20:57:26 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.10]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id DC4DF1955BCB; Wed, 5 Feb 2025 20:57:23 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Wed, 5 Feb 2025 21:57:00 +0100 (CET) Date: Wed, 5 Feb 2025 21:56:56 +0100 From: Oleg Nesterov To: Mateusz Guzik Cc: ebiederm@xmission.com, brauner@kernel.org, akpm@linux-foundation.org, Liam.Howlett@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/5] exit: perform add_device_randomness() without tasklist_lock Message-ID: <20250205205655.GD8754@redhat.com> References: <20250205200929.406568-1-mjguzik@gmail.com> <20250205200929.406568-2-mjguzik@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250205200929.406568-2-mjguzik@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2195E40002 X-Stat-Signature: rj6bht1py49ohygabrrdt1hg33ntsiyk X-Rspam-User: X-HE-Tag: 1738789051-656973 X-HE-Meta: U2FsdGVkX19hC7blTFAVw/wgHIrbbGjysE9wk/1RoHyMTszSMrmYqjhv6TCT9Huhcbr96NhI3NSu0wwS8CQnqg8FKKDwxiqVmEFV5zDoS528b8qWzNgWnmmeY/pv5cP74WKnmqKvZXsEEDF+xKzXWJJT+GvXD9lMNRcpeDh8TWRDPFwHfOfCk1T6tePj4azQL971np1m6g42a/GmYAf7TzCwFo0ZH+yCicVmJ3cjNBvcXalOtZPH+ldg5K+FAWbol9c4nZFdfBMvdSVpJt4T4GXy8+GwdqF8ReUpV+2qPVV8k8zNuMuo+BRhiUvAQUBSrsCJjpqhi6ehNfzUuGoB7vOTDW67Pu+jt9Vpak9bHr+gdX6Tra0Y0UitaL7y1LGcQGENYfMq4UzH6fntyjl8cRbYKcznnonufdzXki3JUBXMsO4CWmiUXutNhk73ZNv6Y+rELg9MUdMC/Z1TQ+f5KiqstK7UpS5rqlCjfcvyhp7zciiWy7pTjIayoNj6DYfz6b6eMJoJS7FKRiIPDUd3+1iyme1Mkv6X6+sSelVOhrCBuNzVhBKLmS1KJ5yUj9tNGv+uXjDv4q5W6w+a72iONRwoUNwGZSOJtsUoK1w+bfClGlzUZ4eqDpODewj8FxlO+TqzoiKQuiMK7OiNkjluM62KneCnOvyzqCoi58ba/S9j9t9MQr1oJ8iocHllirmXqxwLWe7VLQcc/Ox9CUJ8/M/xgX3ayovUDSIrOcPEdYSUaPJDxnCvMOuOh96pbY7dpqnYNqSB/e6+HaA3C/atUvyoqKnNYyo4/lqneab6fVN61/CaPDgUywND0yVrAXOk99A7LgF64kyismRX+C1LmMAW8lmvto9Z85LfE58HVc6McXwY4eiFKmDG28qwF8QSwsa1a25rhfKdeiC+UA0dAm3fYEPF3//tHJpj9qWP5hzw8fbSA7fIHwpyqewRTZ3mcMiGWUvlOdP1meUqygT ffDW/WQK UcepfnTVCt4NQKLvls+aonGkrWCuY0kRVJppyd7EACWGcMnCn161MlWigrrSpKSHSE8Ln06ln21BPUaZa6RmvBkkUFUHfHnd6kAW/Iq+/q/t7mEyji7yxKuIDqo5gI1CvgOFw6F8FNWCpX+t53lElaUgupjjJydg22BwBPL/bqiUBpJk3wosOY8iJ+Gl7KvDr3etARrAtN34dQrEvtZIhODuCSiTA+y1O1mL5k/XjiEYkxOddeQE+JiTrKv3gV9ibcZjHw4B/62QQcsim0ZANW5Z7yshnRHIUcyKzzhxTW3GLATdEni41gN8T3zwyS1WKyCfQd2orE3ahIwJcnH4ATt1zpNl6LCMdkoG1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.035045, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/05, Mateusz Guzik wrote: > > Parallel calls to add_device_randomness() contend on their own. ... > + add_device_randomness(&p->se.sum_exec_runtime, > + sizeof(p->se.sum_exec_runtime)); OK, but > + free_pids(post.pids); wait... free_pids() comes later in 4/5 ? Oleg.