From: Oleg Nesterov <oleg@redhat.com>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: ebiederm@xmission.com, brauner@kernel.org,
akpm@linux-foundation.org, Liam.Howlett@oracle.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/5] exit: perform add_device_randomness() without tasklist_lock
Date: Wed, 5 Feb 2025 21:56:56 +0100 [thread overview]
Message-ID: <20250205205655.GD8754@redhat.com> (raw)
In-Reply-To: <20250205200929.406568-2-mjguzik@gmail.com>
On 02/05, Mateusz Guzik wrote:
>
> Parallel calls to add_device_randomness() contend on their own.
...
> + add_device_randomness(&p->se.sum_exec_runtime,
> + sizeof(p->se.sum_exec_runtime));
OK, but
> + free_pids(post.pids);
wait... free_pids() comes later in 4/5 ?
Oleg.
next prev parent reply other threads:[~2025-02-05 20:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 20:09 [PATCH v5 0/5] reduce tasklist_lock hold time on exit and do some pid cleanup Mateusz Guzik
2025-02-05 20:09 ` [PATCH v5 1/5] exit: perform add_device_randomness() without tasklist_lock Mateusz Guzik
2025-02-05 20:56 ` Oleg Nesterov [this message]
2025-02-06 10:40 ` Christian Brauner
2025-02-05 20:09 ` [PATCH v5 2/5] exit: hoist get_pid() in release_task() outside of tasklist_lock Mateusz Guzik
2025-02-05 20:09 ` [PATCH v5 3/5] pid: sprinkle tasklist_lock asserts Mateusz Guzik
2025-02-05 20:09 ` [PATCH v5 4/5] pid: perform free_pid() calls outside of tasklist_lock Mateusz Guzik
2025-02-07 18:31 ` Mark Brown
2025-02-07 19:45 ` Mateusz Guzik
2025-02-07 19:51 ` Mateusz Guzik
2025-02-05 20:09 ` [PATCH v5 5/5] pid: drop irq disablement around pidmap_lock Mateusz Guzik
2025-02-05 20:29 ` [PATCH v5 0/5] reduce tasklist_lock hold time on exit and do some pid cleanup Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250205205655.GD8754@redhat.com \
--to=oleg@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mjguzik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox